Bug 123474 – Add a crypto algorithm abstraction

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Alexey Proskuryakov]

Add a base interface that individual algorithms could implement.

[Alexey Proskuryakov]

Created attachment 215432 [details]
proposed patch

[WebKit Commit Bot]

Attachment 215432 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/crypto/CryptoAlgorithm.cpp', u'Source/WebCore/crypto/CryptoAlgorithm.h', u'Source/WebCore/crypto/CryptoAlgorithmParameters.h', u'Source/WebCore/crypto/CryptoAlgorithmRegistry.cpp', u'Source/WebCore/crypto/CryptoAlgorithmRegistry.h', u'Source/WebCore/crypto/mac/CryptoAlgorithmRegistryMac.cpp']" exit_code: 1
Source/WebCore/crypto/mac/CryptoAlgorithmRegistryMac.cpp:31:  Should have a space between // and comment  [whitespace/comments] [4]
Source/WebCore/crypto/mac/CryptoAlgorithmRegistryMac.cpp:32:  Should have a space between // and comment  [whitespace/comments] [4]
Source/WebCore/crypto/CryptoAlgorithmRegistry.h:32:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/crypto/CryptoAlgorithm.h:29:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/crypto/CryptoAlgorithm.h:57:  The parameter name "data" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 5 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Build Bot]

Comment on attachment 215432 [details]
proposed patch

Attachment 215432 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/17508002

[Alexey Proskuryakov]

The build failure is OK, this just depends on one of the previous patches.

[Build Bot]

Comment on attachment 215432 [details]
proposed patch

Attachment 215432 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/17158150

[Sam Weinig]

Comment on attachment 215432 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=215432&action=review

> Source/WebCore/crypto/CryptoAlgorithm.h:32
> +#include <wtf/Vector.h>
> +#include "CryptoAlgorithmIdentifier.h"
> +#include "CryptoKeyFormat.h"
> +#include "CryptoKeyUsage.h"

Sort please.

> Source/WebCore/crypto/mac/CryptoAlgorithmRegistryMac.cpp:39
> +//    registerAlgorithm(CryptoAlgorithmHMAC::m_name, CryptoAlgorithmHMAC::m_identifier, CryptoAlgorithmHMAC::create);
> +//    registerAlgorithm(CryptoAlgorithmSHA1::m_name, CryptoAlgorithmSHA1::m_identifier, CryptoAlgorithmSHA1::create);

We don't usually check in commented out code.

[Alexey Proskuryakov]

Committed <http://trac.webkit.org/r158363>.