RESOLVED FIXED 123470
[iOS] Upstream Source/WebKit/ios/ 
https://bugs.webkit.org/show_bug.cgi?id=123470
Summary [iOS] Upstream Source/WebKit/ios/
Andy Estes
Reported 2013-10-29 14:33:38 PDT
[iOS] Upstream Source/WebKit/ios/
Attachments
[iOS] Upstream Source/WebKit/ios/ (403.15 KB, patch)
2013-10-30 13:02 PDT, Andy Estes 		sam: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andy Estes
Comment 1 2013-10-30 13:02:10 PDT
Created attachment 215556 [details] [iOS] Upstream Source/WebKit/ios/
WebKit Commit Bot
Comment 2 2013-10-30 13:04:14 PDT
Attachment 215556 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/ChangeLog', u'Source/WebKit/WebKit.xcodeproj/project.pbxproj', u'Source/WebKit/ios/ChangeLog', u'Source/WebKit/ios/DefaultDelegates/WebDefaultFormDelegate.h', u'Source/WebKit/ios/DefaultDelegates/WebDefaultFormDelegate.m', u'Source/WebKit/ios/DefaultDelegates/WebDefaultFrameLoadDelegate.h', u'Source/WebKit/ios/DefaultDelegates/WebDefaultFrameLoadDelegate.m', u'Source/WebKit/ios/DefaultDelegates/WebDefaultResourceLoadDelegate.h', u'Source/WebKit/ios/DefaultDelegates/WebDefaultResourceLoadDelegate.m', u'Source/WebKit/ios/DefaultDelegates/WebDefaultUIKitDelegate.h', u'Source/WebKit/ios/DefaultDelegates/WebDefaultUIKitDelegate.m', u'Source/WebKit/ios/Misc/EmojiFallbackFontSelector.cpp', u'Source/WebKit/ios/Misc/EmojiFallbackFontSelector.h', u'Source/WebKit/ios/Misc/MemoryMeasure.h', u'Source/WebKit/ios/Misc/MemoryMeasure.mm', u'Source/WebKit/ios/Misc/WebGeolocationCoreLocationProvider.h', u'Source/WebKit/ios/Misc/WebGeolocationCoreLocationProvider.mm', u'Source/WebKit/ios/Misc/WebGeolocationProviderIOS.h', u'Source/WebKit/ios/Misc/WebGeolocationProviderIOS.mm', u'Source/WebKit/ios/Misc/WebNSStringDrawing.h', u'Source/WebKit/ios/Misc/WebNSStringDrawing.mm', u'Source/WebKit/ios/Misc/WebNSStringExtrasIOS.h', u'Source/WebKit/ios/Misc/WebNSStringExtrasIOS.m', u'Source/WebKit/ios/Misc/WebNSStringExtrasIPhone.h', u'Source/WebKit/ios/Misc/WebUIKitSupport.h', u'Source/WebKit/ios/Misc/WebUIKitSupport.mm', u'Source/WebKit/ios/Storage/WebSQLiteDatabaseTrackerClient.h', u'Source/WebKit/ios/Storage/WebSQLiteDatabaseTrackerClient.mm', u'Source/WebKit/ios/WebCoreSupport/PopupMenuIOS.h', u'Source/WebKit/ios/WebCoreSupport/PopupMenuIOS.mm', u'Source/WebKit/ios/WebCoreSupport/SearchPopupMenuIOS.cpp', u'Source/WebKit/ios/WebCoreSupport/SearchPopupMenuIOS.h', u'Source/WebKit/ios/WebCoreSupport/WebCaretChangeListener.h', u'Source/WebKit/ios/WebCoreSupport/WebChromeClientIOS.h', u'Source/WebKit/ios/WebCoreSupport/WebChromeClientIOS.mm', u'Source/WebKit/ios/WebCoreSupport/WebFixedPositionContent.h', u'Source/WebKit/ios/WebCoreSupport/WebFixedPositionContent.mm', u'Source/WebKit/ios/WebCoreSupport/WebFixedPositionContentInternal.h', u'Source/WebKit/ios/WebCoreSupport/WebFrameIOS.h', u'Source/WebKit/ios/WebCoreSupport/WebFrameIOS.mm', u'Source/WebKit/ios/WebCoreSupport/WebFrameIPhone.h', u'Source/WebKit/ios/WebCoreSupport/WebGeolocation.mm', u'Source/WebKit/ios/WebCoreSupport/WebGeolocationInternal.h', u'Source/WebKit/ios/WebCoreSupport/WebGeolocationPrivate.h', u'Source/WebKit/ios/WebCoreSupport/WebMIMETypeRegistry.h', u'Source/WebKit/ios/WebCoreSupport/WebMIMETypeRegistry.mm', u'Source/WebKit/ios/WebCoreSupport/WebSelectionRect.h', u'Source/WebKit/ios/WebCoreSupport/WebSelectionRect.m', u'Source/WebKit/ios/WebCoreSupport/WebVisiblePosition.h', u'Source/WebKit/ios/WebCoreSupport/WebVisiblePosition.mm', u'Source/WebKit/ios/WebCoreSupport/WebVisiblePositionInternal.h', u'Source/WebKit/ios/WebKit.iOS.exp', u'Source/WebKit/ios/WebView/WebFrameViewWAKCompatibility.m', u'Source/WebKit/ios/WebView/WebMailDelegate.h', u'Source/WebKit/ios/WebView/WebPDFViewIOS.h', u'Source/WebKit/ios/WebView/WebPDFViewIOS.mm', u'Source/WebKit/ios/WebView/WebPDFViewIPhone.h', u'Source/WebKit/ios/WebView/WebPDFViewPlaceholder.h', u'Source/WebKit/ios/WebView/WebPDFViewPlaceholder.mm', u'Source/WebKit/ios/WebView/WebPlainWhiteView.h', u'Source/WebKit/ios/WebView/WebPlainWhiteView.mm', u'Source/WebKit/ios/WebView/WebUIKitDelegate.h', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/Configurations/WebKit.xcconfig']" exit_code: 1 Source/WebKit/ios/Misc/EmojiFallbackFontSelector.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Source/WebKit/ios/WebCoreSupport/SearchPopupMenuIOS.cpp:20: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 2 in 64 files If any of these errors are false positives, please file a bug against check-webkit-style.
Andy Estes
Comment 3 2013-10-30 13:19:46 PDT
(In reply to comment #2) > Attachment 215556 [details] did not pass style-queue: > Source/WebKit/ios/Misc/EmojiFallbackFontSelector.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] > Source/WebKit/ios/WebCoreSupport/SearchPopupMenuIOS.cpp:20: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] > Total errors found: 2 in 64 files > > > If any of these errors are false positives, please file a bug against check-webkit-style. Pretty sure this is <https://bugs.webkit.org/show_bug.cgi?id=48639>. WebKit doesn't have config.h.
Sam Weinig
Comment 4 2013-10-30 13:22:42 PDT
Comment on attachment 215556 [details] [iOS] Upstream Source/WebKit/ios/ r=me
Build Bot
Comment 5 2013-10-30 13:33:23 PDT
Comment on attachment 215556 [details] [iOS] Upstream Source/WebKit/ios/ Attachment 215556 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/17058276
Build Bot
Comment 6 2013-10-30 15:26:15 PDT
Comment on attachment 215556 [details] [iOS] Upstream Source/WebKit/ios/ Attachment 215556 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/17108319
Andy Estes
Comment 7 2013-10-30 16:30:44 PDT
(In reply to comment #6) > (From update of attachment 215556 [details]) > Attachment 215556 [details] did not pass mac-ews (mac): > Output: http://webkit-queues.appspot.com/results/17108319 Oops, I missed a few #if PLATFORM(IOS) guards around the new files. I'll add them before landing.
Andy Estes
Comment 8 2013-10-30 16:51:08 PDT
Committed r158327: <http://trac.webkit.org/changeset/158327>
Note You need to log in before you can comment on or make changes to this bug.