Bug 123459 - Make SimpleLineLayout::Layout a variable size object
Summary: Make SimpleLineLayout::Layout a variable size object
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 123505
Blocks:
  Show dependency tree / graph
 
Reported: 2013-10-29 12:46 PDT by Antti Koivisto
Modified: 2013-10-30 03:23 PDT (History)
5 users (show)

See Also:

Attachments
patch (7.64 KB, patch)
2013-10-29 12:51 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
better patch (7.68 KB, patch)
2013-10-29 12:58 PDT, Antti Koivisto 		kling: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2013-10-29 12:46:56 PDT 
less memory
Comment 1 Antti Koivisto 2013-10-29 12:51:53 PDT 
Created attachment 215411 [details]
patch
Comment 2 Antti Koivisto 2013-10-29 12:58:39 PDT 
Created attachment 215412 [details]
better patch
Comment 3 Andreas Kling 2013-10-29 13:00:16 PDT 
Comment on attachment 215412 [details]
better patch

View in context: https://bugs.webkit.org/attachment.cgi?id=215412&action=review

Very cool. r=me

> Source/WebCore/rendering/SimpleLineLayout.cpp:61
> -#endif
> +#endif       

why

> Source/WebCore/rendering/SimpleLineLayout.h:62
> +    Run runs[0];

You may need some #pragma tomfoolery to placate MSVC. See ElementData.h
Comment 4 Build Bot 2013-10-29 13:40:57 PDT 
Comment on attachment 215412 [details]
better patch

Attachment 215412 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/16938053
Comment 5 Antti Koivisto 2013-10-29 13:48:39 PDT 
https://trac.webkit.org/r158214
Comment 6 Csaba Osztrogonác 2013-10-30 03:23:40 PDT 
(In reply to comment #5)
> https://trac.webkit.org/r158214

It made almost all tests crash on GTK and EFL, see https://bugs.webkit.org/show_bug.cgi?id=123505 for details.