Bug 123454 - SessionState.h should not include WebBackForwardList.h
Summary: SessionState.h should not include WebBackForwardList.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gavin Barraclough
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-29 11:35 PDT by Gavin Barraclough
Modified: 2013-10-29 12:41 PDT (History)
1 user (show)

See Also:

Attachments
Fix (5.20 KB, patch)
2013-10-29 11:38 PDT, Gavin Barraclough 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2013-10-29 11:35:40 PDT 
WebBackForwardList is a UIProcess type, SessionState is in shared code.
Also, WebBackForwardListItemVector should be in WebBackForwardListItem.h, not WebBackForwardList.h (the vector type is used in the WebProcess, the item header is shared but the list type is in the UIProcess).
Comment 1 Gavin Barraclough 2013-10-29 11:38:48 PDT 
Created attachment 215406 [details]
Fix
Comment 2 Geoffrey Garen 2013-10-29 11:39:30 PDT 
Comment on attachment 215406 [details]
Fix

r=me
Comment 3 WebKit Commit Bot 2013-10-29 11:40:57 PDT 
Attachment 215406 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Shared/SessionState.cpp', u'Source/WebKit2/Shared/SessionState.h', u'Source/WebKit2/Shared/WebBackForwardListItem.h', u'Source/WebKit2/Shared/WebPageCreationParameters.h', u'Source/WebKit2/UIProcess/WebBackForwardList.h', u'Source/WebKit2/WebProcess/WebPage/DrawingArea.cpp', u'Source/WebKit2/WebProcess/WebPage/WebPage.cpp']" exit_code: 1
Source/WebKit2/WebProcess/WebPage/WebPage.cpp:88:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Gavin Barraclough 2013-10-29 12:41:48 PDT 
Fixed in r158210