Bug 123446 – Multiple runs per line on simple line path

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Antti Koivisto]

More coverage.

[Antti Koivisto]

Created attachment 215389 [details]
patch

[WebKit Commit Bot]

Attachment 215389 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/rendering/SimpleLineLayout.cpp', u'Source/WebCore/rendering/SimpleLineLayout.h', u'Source/WebCore/rendering/SimpleLineLayoutFunctions.cpp', u'Source/WebCore/rendering/SimpleLineLayoutResolver.h']" exit_code: 1
Source/WebCore/rendering/SimpleLineLayoutResolver.h:98:  Missing spaces around &&  [whitespace/operators] [3]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Andreas Kling]

Comment on attachment 215389 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=215389&action=review

r=me.

> Source/WebCore/rendering/SimpleLineLayout.cpp:263
> +        Vector<Run, 4> lineRuns;
> +        lineRuns.append(Run(lineStartOffset, 0));

This can be an uncheckedAppend() since we know there is space in the inline capacity here.

> Source/WebCore/rendering/SimpleLineLayoutResolver.h:45
> +        Run(const Iterator&);

explicit

>> Source/WebCore/rendering/SimpleLineLayoutResolver.h:98
>> +        Iterator(RunResolver::Iterator&&);
> 
> Missing spaces around &&  [whitespace/operators] [3]

explicit

> Source/WebCore/rendering/SimpleLineLayoutResolver.h:244
> +    rect.unite((*it).rect());

No need to declare "rect" before this line.
LayoutRect rect = (*it).rect();

[Antti Koivisto]

https://trac.webkit.org/r158196