Bug 123446 - Multiple runs per line on simple line path
Summary: Multiple runs per line on simple line path
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-29 08:11 PDT by Antti Koivisto
Modified: 2013-10-29 09:59 PDT (History)
4 users (show)

See Also:

Attachments
patch (23.30 KB, patch)
2013-10-29 08:18 PDT, Antti Koivisto 		kling: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2013-10-29 08:11:28 PDT 
More coverage.
Comment 1 Antti Koivisto 2013-10-29 08:18:38 PDT 
Created attachment 215389 [details]
patch
Comment 2 WebKit Commit Bot 2013-10-29 08:19:12 PDT 
Attachment 215389 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/rendering/SimpleLineLayout.cpp', u'Source/WebCore/rendering/SimpleLineLayout.h', u'Source/WebCore/rendering/SimpleLineLayoutFunctions.cpp', u'Source/WebCore/rendering/SimpleLineLayoutResolver.h']" exit_code: 1
Source/WebCore/rendering/SimpleLineLayoutResolver.h:98:  Missing spaces around &&  [whitespace/operators] [3]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Andreas Kling 2013-10-29 08:29:53 PDT 
Comment on attachment 215389 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=215389&action=review

r=me.

> Source/WebCore/rendering/SimpleLineLayout.cpp:263
> +        Vector<Run, 4> lineRuns;
> +        lineRuns.append(Run(lineStartOffset, 0));

This can be an uncheckedAppend() since we know there is space in the inline capacity here.

> Source/WebCore/rendering/SimpleLineLayoutResolver.h:45
> +        Run(const Iterator&);

explicit

>> Source/WebCore/rendering/SimpleLineLayoutResolver.h:98
>> +        Iterator(RunResolver::Iterator&&);
> 
> Missing spaces around &&  [whitespace/operators] [3]

explicit

> Source/WebCore/rendering/SimpleLineLayoutResolver.h:244
> +    rect.unite((*it).rect());

No need to declare "rect" before this line.
LayoutRect rect = (*it).rect();
Comment 4 Antti Koivisto 2013-10-29 09:59:27 PDT 
https://trac.webkit.org/r158196