Bug 123445 - [Curl] Cookies are sometimes not set in download request.
Summary: [Curl] Cookies are sometimes not set in download request.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-29 07:51 PDT by peavo
Modified: 2013-10-30 10:29 PDT (History)
3 users (show)

See Also:


Attachments
Patch (2.01 KB, patch)
2013-10-29 07:58 PDT, peavo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description peavo 2013-10-29 07:51:47 PDT
Sometimes downloads are failing for me. I have traced this down to be caused by missing cookies in the download request.
I believe the reason for this is that when the download tries to read from the cookie file, it fails to open it,
because it is already opened for writing by the ResourceHandleManager.

This can be fixed by using the share handle in the ResourceHandleManager to get the cookies, instead for reading the cookie file.
This will also be a performance improvement, as there is no need to read and parse the cookie file all over again for each download.
The multithreading issues are already handled by the ResourceHandleManager.
Comment 1 peavo 2013-10-29 07:58:21 PDT
Created attachment 215388 [details]
Patch
Comment 2 Brent Fulgham 2013-10-30 10:04:43 PDT
Comment on attachment 215388 [details]
Patch

r=me
Comment 3 peavo 2013-10-30 10:26:40 PDT
(In reply to comment #2)
> (From update of attachment 215388 [details])
> r=me

Thanks for reviewing!
Comment 4 WebKit Commit Bot 2013-10-30 10:29:54 PDT
Comment on attachment 215388 [details]
Patch

Clearing flags on attachment: 215388

Committed r158277: <http://trac.webkit.org/changeset/158277>
Comment 5 WebKit Commit Bot 2013-10-30 10:29:55 PDT
All reviewed patches have been landed.  Closing bug.