This code path has been disabled for months, better to remove it once for all.
(In reply to comment #0) > This code path has been disabled for months, better to remove it once for all. I think it is better to keep it because in the end we should use it, but the problem is that the native controls have problems and also need a redisign.
Well, now that we have hw accelerated decoding/rendering I don't think this is needed anymore.
Yes, and we always have the possibiilty of bringing the code back from repository.
Created attachment 215927 [details] Patch Removed all references to NATIVE_FULLSCREEN_VIDEO related to GStreamer code.
Comment on attachment 215927 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=215927&action=review Nice clean-up! > Source/WebCore/ChangeLog:8 > + No new tests (OOPS!). The commit hooks don't like OOPS!. Can you also please provide a short explanation and at least mention this is about removing dead code?
Forgot to mention the dependency on gstreamer-video-1.0 can perhaps be removed now, needs double checking though.
(In reply to comment #6) > Forgot to mention the dependency on gstreamer-video-1.0 can perhaps be removed now, needs double checking though. Though I could remove the use of some headers, I cannot remove that dependency because it is still used.
Created attachment 215935 [details] Patch Removed some header declarations and updated changelogs.
Comment on attachment 215935 [details] Patch Clearing flags on attachment: 215935 Committed r158656: <http://trac.webkit.org/changeset/158656>
All reviewed patches have been landed. Closing bug.