Bug 123436 - [Mac] Rationalize user defaults override code
Summary: [Mac] Rationalize user defaults override code
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
Depends on:
Reported: 2013-10-29 00:31 PDT by Alexey Proskuryakov
Modified: 2013-10-29 10:46 PDT (History)
2 users (show)

See Also:

proposed patch (13.31 KB, patch)
2013-10-29 00:40 PDT, Alexey Proskuryakov
mitz: review+
Details | Formatted Diff | Diff
patch for landing (13.31 KB, patch)
2013-10-29 10:16 PDT, Alexey Proskuryakov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2013-10-29 00:31:05 PDT
DumpRenderTree and WebKitTestRunner use a variety of techniques to change user defaults, from registering a default to setting application preferences to overriding via argument domain.

There is no reason for this variety as far as I can tell.
Comment 1 Alexey Proskuryakov 2013-10-29 00:40:32 PDT
Created attachment 215368 [details]
proposed patch

Let's see if EWS agrees that this doesn't change behavior...
Comment 2 mitz 2013-10-29 07:19:18 PDT
Comment on attachment 215368 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=215368&action=review

> Tools/DumpRenderTree/mac/DumpRenderTree.mm:694
> +        @"AppleLanguages": @[@"en"],

Spaces around @"en", please.
Comment 3 Alexey Proskuryakov 2013-10-29 10:16:05 PDT
Created attachment 215394 [details]
patch for landing
Comment 4 WebKit Commit Bot 2013-10-29 10:46:01 PDT
Comment on attachment 215394 [details]
patch for landing

Clearing flags on attachment: 215394

Committed r158199: <http://trac.webkit.org/changeset/158199>
Comment 5 WebKit Commit Bot 2013-10-29 10:46:02 PDT
All reviewed patches have been landed.  Closing bug.