123426 – Web Inspector: Remove old Inspector.json version files and generators

Bug 123426 - Web Inspector: Remove old Inspector.json version files and generators

Summary: Web Inspector: Remove old Inspector.json version files and generators

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	Web Inspector (show other bugs)
Version:	528+ (Nightly build)
Hardware:	All All

Importance:	P2 Normal
Assignee:	Nobody

URL:
Keywords:	InRadar

Depends on:
Blocks:

Reported:	2013-10-28 16:26 PDT by Joseph Pecoraro
Modified:	2013-10-29 11:36 PDT (History)
CC List:	10 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (251.29 KB, patch) 2013-10-28 16:27 PDT, Joseph Pecoraro	joepeck: review- joepeck: commit-queue-	Details \| Formatted Diff \| Diff
[PATCH] Proposed Fix (254.16 KB, patch) 2013-10-28 16:38 PDT, Joseph Pecoraro	timothy: review- buildbot: commit-queue-	Details \| Formatted Diff \| Diff
[PATCH] Proposed Fix (277.87 KB, patch) 2013-10-29 10:21 PDT, Joseph Pecoraro	no flags	Details \| Formatted Diff \| Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Joseph Pecoraro 2013-10-28 16:26:58 PDT

We do not have a use for Inspector-0.1.js and Inspector-1.0.js. They do not correspond to any known releases and use outdated syntax.

Comment 1 Radar WebKit Bug Importer 2013-10-28 16:27:21 PDT

<rdar://problem/15337192>

Comment 2 Joseph Pecoraro 2013-10-28 16:27:36 PDT

Created attachment 215342 [details]
[PATCH] Proposed Fix

Comment 3 Joseph Pecoraro 2013-10-28 16:36:27 PDT

Comment on attachment 215342 [details]
[PATCH] Proposed Fix

Missed removing from Xcode project and something else.

Comment 4 Joseph Pecoraro 2013-10-28 16:38:23 PDT

Created attachment 215343 [details]
[PATCH] Proposed Fix

Comment 5 Build Bot 2013-10-28 17:07:54 PDT

Comment on attachment 215343 [details]
[PATCH] Proposed Fix

Attachment 215343 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/16018034

Comment 6 Build Bot 2013-10-28 17:17:56 PDT

Comment on attachment 215343 [details]
[PATCH] Proposed Fix

Attachment 215343 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/16258040

Comment 7 Build Bot 2013-10-28 17:21:06 PDT

Comment on attachment 215343 [details]
[PATCH] Proposed Fix

Attachment 215343 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/16158036

Comment 8 Timothy Hatcher 2013-10-28 21:42:23 PDT

generate-inspector-protocol-version uses the files to detect compatibility errors. We should just remove generate-inspector-protocol-version. We do a good job at compatibility without it.

Comment 9 Joseph Pecoraro 2013-10-29 10:21:55 PDT

Created attachment 215395 [details]
[PATCH] Proposed Fix

Comment 10 WebKit Commit Bot 2013-10-29 11:36:33 PDT

Comment on attachment 215395 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 215395

Committed r158203: <http://trac.webkit.org/changeset/158203>

Comment 11 WebKit Commit Bot 2013-10-29 11:36:36 PDT

All reviewed patches have been landed.  Closing bug.