RESOLVED FIXED 123426
Web Inspector: Remove old Inspector.json version files and generators 
https://bugs.webkit.org/show_bug.cgi?id=123426
Summary Web Inspector: Remove old Inspector.json version files and generators
Joseph Pecoraro
Reported 2013-10-28 16:26:58 PDT
We do not have a use for Inspector-0.1.js and Inspector-1.0.js. They do not correspond to any known releases and use outdated syntax.
Attachments
[PATCH] Proposed Fix (251.29 KB, patch)
2013-10-28 16:27 PDT, Joseph Pecoraro 		joepeck: review-
joepeck: commit-queue-
DetailsFormatted DiffDiff
[PATCH] Proposed Fix (254.16 KB, patch)
2013-10-28 16:38 PDT, Joseph Pecoraro 		timothy: review-
buildbot: commit-queue-
DetailsFormatted DiffDiff
[PATCH] Proposed Fix (277.87 KB, patch)
2013-10-29 10:21 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2013-10-28 16:27:21 PDT
<rdar://problem/15337192>
Joseph Pecoraro
Comment 2 2013-10-28 16:27:36 PDT
Created attachment 215342 [details] [PATCH] Proposed Fix
Joseph Pecoraro
Comment 3 2013-10-28 16:36:27 PDT
Comment on attachment 215342 [details] [PATCH] Proposed Fix Missed removing from Xcode project and something else.
Joseph Pecoraro
Comment 4 2013-10-28 16:38:23 PDT
Created attachment 215343 [details] [PATCH] Proposed Fix
Build Bot
Comment 5 2013-10-28 17:07:54 PDT
Comment on attachment 215343 [details] [PATCH] Proposed Fix Attachment 215343 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/16018034
Build Bot
Comment 6 2013-10-28 17:17:56 PDT
Comment on attachment 215343 [details] [PATCH] Proposed Fix Attachment 215343 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/16258040
Build Bot
Comment 7 2013-10-28 17:21:06 PDT
Comment on attachment 215343 [details] [PATCH] Proposed Fix Attachment 215343 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/16158036
Timothy Hatcher
Comment 8 2013-10-28 21:42:23 PDT
generate-inspector-protocol-version uses the files to detect compatibility errors. We should just remove generate-inspector-protocol-version. We do a good job at compatibility without it.
Joseph Pecoraro
Comment 9 2013-10-29 10:21:55 PDT
Created attachment 215395 [details] [PATCH] Proposed Fix
WebKit Commit Bot
Comment 10 2013-10-29 11:36:33 PDT
Comment on attachment 215395 [details] [PATCH] Proposed Fix Clearing flags on attachment: 215395 Committed r158203: <http://trac.webkit.org/changeset/158203>
WebKit Commit Bot
Comment 11 2013-10-29 11:36:36 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.