Bug 123414 - RenderElement::style() should return a reference.
Summary: RenderElement::style() should return a reference.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-28 13:27 PDT by Andreas Kling
Modified: 2013-10-28 19:57 PDT (History)
8 users (show)

See Also:


Attachments
Snack for EWS (1.18 MB, patch)
2013-10-28 13:29 PDT, Andreas Kling
no flags Details | Formatted Diff | Diff
Snack or EWS (1.18 MB, patch)
2013-10-28 14:17 PDT, Andreas Kling
no flags Details | Formatted Diff | Diff
Snack for EWS (1.19 MB, patch)
2013-10-28 14:54 PDT, Andreas Kling
eflews.bot: commit-queue-
Details | Formatted Diff | Diff
Patch (1.19 MB, patch)
2013-10-28 16:45 PDT, Andreas Kling
eflews.bot: commit-queue-
Details | Formatted Diff | Diff
Patch (1.19 MB, patch)
2013-10-28 17:02 PDT, Andreas Kling
eflews.bot: commit-queue-
Details | Formatted Diff | Diff
Patch (1.19 MB, patch)
2013-10-28 17:32 PDT, Andreas Kling
no flags Details | Formatted Diff | Diff
It's happening! (1.19 MB, patch)
2013-10-28 17:58 PDT, Andreas Kling
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2013-10-28 13:27:42 PDT
Oh yes it should.
Comment 1 Andreas Kling 2013-10-28 13:29:09 PDT
Created attachment 215325 [details]
Snack for EWS
Comment 2 Andreas Kling 2013-10-28 14:17:17 PDT
Created attachment 215334 [details]
Snack or EWS
Comment 3 WebKit Commit Bot 2013-10-28 14:20:06 PDT
Attachment 215334 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/accessibility/AccessibilityMediaControls.cpp', u'Source/WebCore/accessibility/AccessibilityObject.cpp', u'Source/WebCore/accessibility/AccessibilityRenderObject.cpp', u'Source/WebCore/accessibility/AccessibilitySlider.cpp', u'Source/WebCore/accessibility/AccessibilityTable.cpp', u'Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceText.cpp', u'Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm', u'Source/WebCore/bindings/objc/DOM.mm', u'Source/WebCore/css/CSSComputedStyleDeclaration.cpp', u'Source/WebCore/css/CSSGradientValue.cpp', u'Source/WebCore/css/CSSGradientValue.h', u'Source/WebCore/css/StyleResolver.cpp', u'Source/WebCore/dom/Document.cpp', u'Source/WebCore/dom/Element.cpp', u'Source/WebCore/dom/Node.cpp', u'Source/WebCore/dom/NodeRenderStyle.h', u'Source/WebCore/dom/Position.cpp', u'Source/WebCore/dom/PositionIterator.cpp', u'Source/WebCore/dom/PseudoElement.cpp', u'Source/WebCore/dom/Range.cpp', u'Source/WebCore/editing/ApplyBlockElementCommand.cpp', u'Source/WebCore/editing/ApplyStyleCommand.cpp', u'Source/WebCore/editing/CompositeEditCommand.cpp', u'Source/WebCore/editing/DeleteButtonController.cpp', u'Source/WebCore/editing/DeleteSelectionCommand.cpp', u'Source/WebCore/editing/Editor.cpp', u'Source/WebCore/editing/EditorCommand.cpp', u'Source/WebCore/editing/FrameSelection.cpp', u'Source/WebCore/editing/HTMLInterchange.cpp', u'Source/WebCore/editing/InsertLineBreakCommand.cpp', u'Source/WebCore/editing/InsertParagraphSeparatorCommand.cpp', u'Source/WebCore/editing/ReplaceSelectionCommand.cpp', u'Source/WebCore/editing/TextIterator.cpp', u'Source/WebCore/editing/VisibleUnits.cpp', u'Source/WebCore/editing/htmlediting.cpp', u'Source/WebCore/editing/ios/EditorIOS.mm', u'Source/WebCore/editing/mac/EditorMac.mm', u'Source/WebCore/editing/markup.cpp', u'Source/WebCore/html/HTMLAppletElement.cpp', u'Source/WebCore/html/HTMLAreaElement.cpp', u'Source/WebCore/html/HTMLCanvasElement.cpp', u'Source/WebCore/html/HTMLElement.cpp', u'Source/WebCore/html/HTMLFormControlElement.cpp', u'Source/WebCore/html/HTMLInputElement.cpp', u'Source/WebCore/html/HTMLMediaElement.cpp', u'Source/WebCore/html/HTMLOptionElement.cpp', u'Source/WebCore/html/HTMLPlugInImageElement.cpp', u'Source/WebCore/html/HTMLTextFormControlElement.cpp', u'Source/WebCore/html/RangeInputType.cpp', u'Source/WebCore/html/TextFieldInputType.cpp', u'Source/WebCore/html/parser/HTMLResourcePreloader.cpp', u'Source/WebCore/html/shadow/MeterShadowElement.cpp', u'Source/WebCore/html/shadow/ProgressShadowElement.cpp', u'Source/WebCore/html/shadow/SliderThumbElement.cpp', u'Source/WebCore/html/shadow/TextControlInnerElements.cpp', u'Source/WebCore/inspector/InspectorLayerTreeAgent.cpp', u'Source/WebCore/inspector/InspectorOverlay.cpp', u'Source/WebCore/loader/cache/CachedImage.cpp', u'Source/WebCore/page/Chrome.cpp', u'Source/WebCore/page/DragController.cpp', u'Source/WebCore/page/EventHandler.cpp', u'Source/WebCore/page/Frame.cpp', u'Source/WebCore/page/FrameView.cpp', u'Source/WebCore/page/PrintContext.cpp', u'Source/WebCore/page/SpatialNavigation.cpp', u'Source/WebCore/page/animation/AnimationController.cpp', u'Source/WebCore/page/animation/CSSPropertyAnimation.cpp', u'Source/WebCore/page/animation/KeyframeAnimation.cpp', u'Source/WebCore/platform/efl/RenderThemeEfl.cpp', u'Source/WebCore/platform/graphics/mac/ComplexTextController.cpp', u'Source/WebCore/platform/gtk/RenderThemeGtk.cpp', u'Source/WebCore/platform/gtk/RenderThemeGtk2.cpp', u'Source/WebCore/platform/gtk/RenderThemeGtk3.cpp', u'Source/WebCore/platform/mac/HTMLConverter.mm', u'Source/WebCore/rendering/AutoTableLayout.cpp', u'Source/WebCore/rendering/EllipsisBox.cpp', u'Source/WebCore/rendering/FilterEffectRenderer.cpp', u'Source/WebCore/rendering/FixedTableLayout.cpp', u'Source/WebCore/rendering/FloatingObjects.cpp', u'Source/WebCore/rendering/FlowThreadController.cpp', u'Source/WebCore/rendering/HitTestResult.cpp', u'Source/WebCore/rendering/ImageQualityController.cpp', u'Source/WebCore/rendering/InlineBox.cpp', u'Source/WebCore/rendering/InlineBox.h', u'Source/WebCore/rendering/InlineFlowBox.cpp', u'Source/WebCore/rendering/InlineFlowBox.h', u'Source/WebCore/rendering/InlineIterator.h', u'Source/WebCore/rendering/InlineTextBox.cpp', u'Source/WebCore/rendering/InlineTextBox.h', u'Source/WebCore/rendering/LayoutState.cpp', u'Source/WebCore/rendering/LineWidth.cpp', u'Source/WebCore/rendering/LogicalSelectionOffsetCaches.h', u'Source/WebCore/rendering/OrderIterator.cpp', u'Source/WebCore/rendering/RenderBlock.cpp', u'Source/WebCore/rendering/RenderBlock.h', u'Source/WebCore/rendering/RenderBlockFlow.cpp', u'Source/WebCore/rendering/RenderBlockLineLayout.cpp', u'Source/WebCore/rendering/RenderBox.cpp', u'Source/WebCore/rendering/RenderBox.h', u'Source/WebCore/rendering/RenderBoxModelObject.cpp', u'Source/WebCore/rendering/RenderBoxModelObject.h', u'Source/WebCore/rendering/RenderButton.cpp', u'Source/WebCore/rendering/RenderCombineText.cpp', u'Source/WebCore/rendering/RenderCombineText.h', u'Source/WebCore/rendering/RenderCounter.cpp', u'Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp', u'Source/WebCore/rendering/RenderDeprecatedFlexibleBox.h', u'Source/WebCore/rendering/RenderDetailsMarker.cpp', u'Source/WebCore/rendering/RenderElement.cpp', u'Source/WebCore/rendering/RenderElement.h', u'Source/WebCore/rendering/RenderEmbeddedObject.cpp', u'Source/WebCore/rendering/RenderFieldset.cpp', u'Source/WebCore/rendering/RenderFileUploadControl.cpp', u'Source/WebCore/rendering/RenderFlexibleBox.cpp', u'Source/WebCore/rendering/RenderFlowThread.cpp', u'Source/WebCore/rendering/RenderFrameSet.cpp', u'Source/WebCore/rendering/RenderFullScreen.cpp', u'Source/WebCore/rendering/RenderGeometryMap.cpp', u'Source/WebCore/rendering/RenderGrid.cpp', u'Source/WebCore/rendering/RenderHTMLCanvas.cpp', u'Source/WebCore/rendering/RenderIFrame.cpp', u'Source/WebCore/rendering/RenderImage.cpp', u'Source/WebCore/rendering/RenderImageResource.cpp', u'Source/WebCore/rendering/RenderImageResourceStyleImage.cpp', u'Source/WebCore/rendering/RenderInline.cpp', u'Source/WebCore/rendering/RenderInputSpeech.cpp', u'Source/WebCore/rendering/RenderLayer.cpp', u'Source/WebCore/rendering/RenderLayer.h', u'Source/WebCore/rendering/RenderLayerBacking.cpp', u'Source/WebCore/rendering/RenderLayerCompositor.cpp', u'Source/WebCore/rendering/RenderLayerModelObject.cpp', u'Source/WebCore/rendering/RenderLineBoxList.cpp', u'Source/WebCore/rendering/RenderLineBreak.cpp', u'Source/WebCore/rendering/RenderListBox.cpp', u'Source/WebCore/rendering/RenderListItem.cpp', u'Source/WebCore/rendering/RenderListMarker.cpp', u'Source/WebCore/rendering/RenderMarquee.cpp', u'Source/WebCore/rendering/RenderMedia.cpp', u'Source/WebCore/rendering/RenderMediaControlElements.cpp', u'Source/WebCore/rendering/RenderMediaControls.cpp', u'Source/WebCore/rendering/RenderMenuList.cpp', u'Source/WebCore/rendering/RenderMultiColumnBlock.cpp', u'Source/WebCore/rendering/RenderMultiColumnBlock.h', u'Source/WebCore/rendering/RenderMultiColumnFlowThread.cpp', u'Source/WebCore/rendering/RenderMultiColumnSet.cpp', u'Source/WebCore/rendering/RenderNamedFlowFragment.cpp', u'Source/WebCore/rendering/RenderNamedFlowThread.cpp', u'Source/WebCore/rendering/RenderObject.cpp', u'Source/WebCore/rendering/RenderObject.h', u'Source/WebCore/rendering/RenderProgress.cpp', u'Source/WebCore/rendering/RenderQuote.cpp', u'Source/WebCore/rendering/RenderRegion.cpp', u'Source/WebCore/rendering/RenderReplaced.cpp', u'Source/WebCore/rendering/RenderRuby.cpp', u'Source/WebCore/rendering/RenderRubyRun.cpp', u'Source/WebCore/rendering/RenderRubyText.cpp', u'Source/WebCore/rendering/RenderScrollbar.cpp', u'Source/WebCore/rendering/RenderScrollbarPart.cpp', u'Source/WebCore/rendering/RenderSearchField.cpp', u'Source/WebCore/rendering/RenderSlider.cpp', u'Source/WebCore/rendering/RenderSnapshottedPlugIn.cpp', u'Source/WebCore/rendering/RenderTable.cpp', u'Source/WebCore/rendering/RenderTable.h', u'Source/WebCore/rendering/RenderTableCell.cpp', u'Source/WebCore/rendering/RenderTableCell.h', u'Source/WebCore/rendering/RenderTableCol.cpp', u'Source/WebCore/rendering/RenderTableCol.h', u'Source/WebCore/rendering/RenderTableRow.cpp', u'Source/WebCore/rendering/RenderTableRow.h', u'Source/WebCore/rendering/RenderTableSection.cpp', u'Source/WebCore/rendering/RenderTableSection.h', u'Source/WebCore/rendering/RenderText.cpp', u'Source/WebCore/rendering/RenderText.h', u'Source/WebCore/rendering/RenderTextControl.cpp', u'Source/WebCore/rendering/RenderTextControlMultiLine.cpp', u'Source/WebCore/rendering/RenderTextControlSingleLine.cpp', u'Source/WebCore/rendering/RenderTextFragment.cpp', u'Source/WebCore/rendering/RenderTextLineBoxes.cpp', u'Source/WebCore/rendering/RenderTextTrackCue.cpp', u'Source/WebCore/rendering/RenderTheme.cpp', u'Source/WebCore/rendering/RenderThemeMac.mm', u'Source/WebCore/rendering/RenderThemeSafari.cpp', u'Source/WebCore/rendering/RenderThemeWin.cpp', u'Source/WebCore/rendering/RenderThemeWinCE.cpp', u'Source/WebCore/rendering/RenderTreeAsText.cpp', u'Source/WebCore/rendering/RenderVideo.cpp', u'Source/WebCore/rendering/RenderView.cpp', u'Source/WebCore/rendering/RenderView.h', u'Source/WebCore/rendering/RenderWidget.cpp', u'Source/WebCore/rendering/RootInlineBox.cpp', u'Source/WebCore/rendering/SimpleLineLayout.cpp', u'Source/WebCore/rendering/SimpleLineLayoutFunctions.cpp', u'Source/WebCore/rendering/SimpleLineLayoutResolver.h', u'Source/WebCore/rendering/mathml/RenderMathMLBlock.cpp', u'Source/WebCore/rendering/mathml/RenderMathMLFenced.cpp', u'Source/WebCore/rendering/mathml/RenderMathMLFraction.cpp', u'Source/WebCore/rendering/mathml/RenderMathMLOperator.cpp', u'Source/WebCore/rendering/mathml/RenderMathMLRoot.cpp', u'Source/WebCore/rendering/mathml/RenderMathMLRow.cpp', u'Source/WebCore/rendering/mathml/RenderMathMLScripts.cpp', u'Source/WebCore/rendering/mathml/RenderMathMLSpace.cpp', u'Source/WebCore/rendering/shapes/ShapeInfo.cpp', u'Source/WebCore/rendering/shapes/ShapeInfo.h', u'Source/WebCore/rendering/shapes/ShapeInsideInfo.cpp', u'Source/WebCore/rendering/shapes/ShapeOutsideInfo.cpp', u'Source/WebCore/rendering/svg/RenderSVGBlock.cpp', u'Source/WebCore/rendering/svg/RenderSVGContainer.cpp', u'Source/WebCore/rendering/svg/RenderSVGEllipse.cpp', u'Source/WebCore/rendering/svg/RenderSVGImage.cpp', u'Source/WebCore/rendering/svg/RenderSVGInline.cpp', u'Source/WebCore/rendering/svg/RenderSVGInlineText.cpp', u'Source/WebCore/rendering/svg/RenderSVGModelObject.cpp', u'Source/WebCore/rendering/svg/RenderSVGPath.cpp', u'Source/WebCore/rendering/svg/RenderSVGRect.cpp', u'Source/WebCore/rendering/svg/RenderSVGResource.cpp', u'Source/WebCore/rendering/svg/RenderSVGResourceClipper.cpp', u'Source/WebCore/rendering/svg/RenderSVGResourceContainer.cpp', u'Source/WebCore/rendering/svg/RenderSVGResourceFilter.cpp', u'Source/WebCore/rendering/svg/RenderSVGResourceFilterPrimitive.cpp', u'Source/WebCore/rendering/svg/RenderSVGResourceMasker.cpp', u'Source/WebCore/rendering/svg/RenderSVGRoot.cpp', u'Source/WebCore/rendering/svg/RenderSVGShape.cpp', u'Source/WebCore/rendering/svg/RenderSVGShape.h', u'Source/WebCore/rendering/svg/RenderSVGText.cpp', u'Source/WebCore/rendering/svg/SVGInlineFlowBox.cpp', u'Source/WebCore/rendering/svg/SVGInlineTextBox.cpp', u'Source/WebCore/rendering/svg/SVGRenderSupport.cpp', u'Source/WebCore/rendering/svg/SVGRenderTreeAsText.cpp', u'Source/WebCore/rendering/svg/SVGRenderingContext.cpp', u'Source/WebCore/rendering/svg/SVGTextChunkBuilder.cpp', u'Source/WebCore/rendering/svg/SVGTextLayoutAttributesBuilder.cpp', u'Source/WebCore/rendering/svg/SVGTextLayoutEngine.cpp', u'Source/WebCore/rendering/svg/SVGTextLayoutEngineBaseline.cpp', u'Source/WebCore/rendering/svg/SVGTextMetrics.cpp', u'Source/WebCore/rendering/svg/SVGTextMetricsBuilder.cpp', u'Source/WebCore/rendering/svg/SVGTextQuery.cpp', u'Source/WebCore/rendering/svg/SVGTextRunRenderingContext.cpp', u'Source/WebCore/style/StyleResolveForDocument.cpp', u'Source/WebCore/style/StyleResolveTree.cpp', u'Source/WebCore/svg/SVGAnimatedColor.cpp', u'Source/WebCore/svg/SVGElement.cpp', u'Source/WebCore/svg/SVGFEDiffuseLightingElement.cpp', u'Source/WebCore/svg/SVGFEDropShadowElement.cpp', u'Source/WebCore/svg/SVGFEFloodElement.cpp', u'Source/WebCore/svg/SVGFESpecularLightingElement.cpp', u'Source/WebCore/svg/SVGFontData.cpp', u'Source/WebCore/svg/SVGGraphicsElement.cpp', u'Source/WebCore/svg/SVGLengthContext.cpp', u'Source/WebCore/svg/SVGSVGElement.cpp', u'Source/WebCore/svg/SVGStopElement.cpp', u'Source/WebCore/svg/SVGTextElement.cpp', u'Source/WebCore/svg/graphics/SVGImage.cpp', u'Source/WebKit/mac/WebView/WebFrame.mm', u'Source/WebKit/mac/WebView/WebFrameView.mm', u'Source/WebKit/mac/WebView/WebHTMLRepresentation.mm', u'Source/WebKit/mac/WebView/WebHTMLView.mm', u'Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm']" exit_code: 1
Source/WebCore/rendering/RenderListMarker.cpp:1659:  Else clause should never be on same line as else (use 2 lines)  [whitespace/newline] [4]
Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp:102:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp:364:  Omit int when using unsigned  [runtime/unsigned] [1]
Source/WebCore/rendering/RenderBox.cpp:1512:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/rendering/RenderBox.cpp:2476:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Source/WebCore/rendering/RenderBox.cpp:4588:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Source/WebCore/rendering/RenderBox.cpp:4595:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Source/WebCore/dom/Position.cpp:983:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/platform/gtk/RenderThemeGtk.cpp:338:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Source/WebCore/platform/gtk/RenderThemeGtk.cpp:357:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Source/WebCore/platform/gtk/RenderThemeGtk.cpp:385:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Source/WebCore/rendering/RenderLayer.cpp:1337:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/rendering/RenderThemeSafari.cpp:813:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/rendering/RenderThemeSafari.cpp:814:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/rendering/RenderThemeSafari.cpp:815:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/editing/DeleteSelectionCommand.cpp:585:  Missing spaces around |  [whitespace/operators] [3]
Source/WebCore/rendering/RenderBlock.cpp:4086:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/rendering/RenderBlock.cpp:4089:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/rendering/InlineBox.cpp:370:  An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
Source/WebCore/rendering/RenderThemeWin.cpp:688:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/rendering/RenderThemeWin.cpp:689:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/rendering/RenderThemeWin.cpp:689:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Total errors found: 22 in 257 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Andreas Kling 2013-10-28 14:54:40 PDT
Created attachment 215337 [details]
Snack for EWS
Comment 5 WebKit Commit Bot 2013-10-28 15:09:07 PDT
Attachment 215337 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/accessibility/AccessibilityMediaControls.cpp', u'Source/WebCore/accessibility/AccessibilityObject.cpp', u'Source/WebCore/accessibility/AccessibilityRenderObject.cpp', u'Source/WebCore/accessibility/AccessibilitySlider.cpp', u'Source/WebCore/accessibility/AccessibilityTable.cpp', u'Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceText.cpp', u'Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm', u'Source/WebCore/bindings/objc/DOM.mm', u'Source/WebCore/css/CSSComputedStyleDeclaration.cpp', u'Source/WebCore/css/CSSGradientValue.cpp', u'Source/WebCore/css/CSSGradientValue.h', u'Source/WebCore/css/StyleResolver.cpp', u'Source/WebCore/dom/Document.cpp', u'Source/WebCore/dom/Element.cpp', u'Source/WebCore/dom/Node.cpp', u'Source/WebCore/dom/NodeRenderStyle.h', u'Source/WebCore/dom/Position.cpp', u'Source/WebCore/dom/PositionIterator.cpp', u'Source/WebCore/dom/PseudoElement.cpp', u'Source/WebCore/dom/Range.cpp', u'Source/WebCore/editing/ApplyBlockElementCommand.cpp', u'Source/WebCore/editing/ApplyStyleCommand.cpp', u'Source/WebCore/editing/CompositeEditCommand.cpp', u'Source/WebCore/editing/DeleteButtonController.cpp', u'Source/WebCore/editing/DeleteSelectionCommand.cpp', u'Source/WebCore/editing/Editor.cpp', u'Source/WebCore/editing/EditorCommand.cpp', u'Source/WebCore/editing/FrameSelection.cpp', u'Source/WebCore/editing/HTMLInterchange.cpp', u'Source/WebCore/editing/InsertLineBreakCommand.cpp', u'Source/WebCore/editing/InsertParagraphSeparatorCommand.cpp', u'Source/WebCore/editing/ReplaceSelectionCommand.cpp', u'Source/WebCore/editing/TextIterator.cpp', u'Source/WebCore/editing/VisibleUnits.cpp', u'Source/WebCore/editing/htmlediting.cpp', u'Source/WebCore/editing/ios/EditorIOS.mm', u'Source/WebCore/editing/mac/EditorMac.mm', u'Source/WebCore/editing/markup.cpp', u'Source/WebCore/html/HTMLAppletElement.cpp', u'Source/WebCore/html/HTMLAreaElement.cpp', u'Source/WebCore/html/HTMLCanvasElement.cpp', u'Source/WebCore/html/HTMLElement.cpp', u'Source/WebCore/html/HTMLFormControlElement.cpp', u'Source/WebCore/html/HTMLInputElement.cpp', u'Source/WebCore/html/HTMLMediaElement.cpp', u'Source/WebCore/html/HTMLOptionElement.cpp', u'Source/WebCore/html/HTMLPlugInImageElement.cpp', u'Source/WebCore/html/HTMLTextFormControlElement.cpp', u'Source/WebCore/html/RangeInputType.cpp', u'Source/WebCore/html/TextFieldInputType.cpp', u'Source/WebCore/html/parser/HTMLResourcePreloader.cpp', u'Source/WebCore/html/shadow/MeterShadowElement.cpp', u'Source/WebCore/html/shadow/ProgressShadowElement.cpp', u'Source/WebCore/html/shadow/SliderThumbElement.cpp', u'Source/WebCore/html/shadow/TextControlInnerElements.cpp', u'Source/WebCore/inspector/InspectorLayerTreeAgent.cpp', u'Source/WebCore/inspector/InspectorOverlay.cpp', u'Source/WebCore/loader/cache/CachedImage.cpp', u'Source/WebCore/page/Chrome.cpp', u'Source/WebCore/page/DragController.cpp', u'Source/WebCore/page/EventHandler.cpp', u'Source/WebCore/page/Frame.cpp', u'Source/WebCore/page/FrameView.cpp', u'Source/WebCore/page/PrintContext.cpp', u'Source/WebCore/page/SpatialNavigation.cpp', u'Source/WebCore/page/animation/AnimationController.cpp', u'Source/WebCore/page/animation/CSSPropertyAnimation.cpp', u'Source/WebCore/page/animation/KeyframeAnimation.cpp', u'Source/WebCore/platform/efl/RenderThemeEfl.cpp', u'Source/WebCore/platform/graphics/mac/ComplexTextController.cpp', u'Source/WebCore/platform/gtk/RenderThemeGtk.cpp', u'Source/WebCore/platform/gtk/RenderThemeGtk2.cpp', u'Source/WebCore/platform/gtk/RenderThemeGtk3.cpp', u'Source/WebCore/platform/mac/HTMLConverter.mm', u'Source/WebCore/rendering/AutoTableLayout.cpp', u'Source/WebCore/rendering/EllipsisBox.cpp', u'Source/WebCore/rendering/FilterEffectRenderer.cpp', u'Source/WebCore/rendering/FixedTableLayout.cpp', u'Source/WebCore/rendering/FloatingObjects.cpp', u'Source/WebCore/rendering/FlowThreadController.cpp', u'Source/WebCore/rendering/HitTestResult.cpp', u'Source/WebCore/rendering/ImageQualityController.cpp', u'Source/WebCore/rendering/InlineBox.cpp', u'Source/WebCore/rendering/InlineBox.h', u'Source/WebCore/rendering/InlineFlowBox.cpp', u'Source/WebCore/rendering/InlineFlowBox.h', u'Source/WebCore/rendering/InlineIterator.h', u'Source/WebCore/rendering/InlineTextBox.cpp', u'Source/WebCore/rendering/InlineTextBox.h', u'Source/WebCore/rendering/LayoutState.cpp', u'Source/WebCore/rendering/LineWidth.cpp', u'Source/WebCore/rendering/LogicalSelectionOffsetCaches.h', u'Source/WebCore/rendering/OrderIterator.cpp', u'Source/WebCore/rendering/RenderBlock.cpp', u'Source/WebCore/rendering/RenderBlock.h', u'Source/WebCore/rendering/RenderBlockFlow.cpp', u'Source/WebCore/rendering/RenderBlockLineLayout.cpp', u'Source/WebCore/rendering/RenderBox.cpp', u'Source/WebCore/rendering/RenderBox.h', u'Source/WebCore/rendering/RenderBoxModelObject.cpp', u'Source/WebCore/rendering/RenderBoxModelObject.h', u'Source/WebCore/rendering/RenderButton.cpp', u'Source/WebCore/rendering/RenderCombineText.cpp', u'Source/WebCore/rendering/RenderCombineText.h', u'Source/WebCore/rendering/RenderCounter.cpp', u'Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp', u'Source/WebCore/rendering/RenderDeprecatedFlexibleBox.h', u'Source/WebCore/rendering/RenderDetailsMarker.cpp', u'Source/WebCore/rendering/RenderElement.cpp', u'Source/WebCore/rendering/RenderElement.h', u'Source/WebCore/rendering/RenderEmbeddedObject.cpp', u'Source/WebCore/rendering/RenderFieldset.cpp', u'Source/WebCore/rendering/RenderFileUploadControl.cpp', u'Source/WebCore/rendering/RenderFlexibleBox.cpp', u'Source/WebCore/rendering/RenderFlowThread.cpp', u'Source/WebCore/rendering/RenderFrameSet.cpp', u'Source/WebCore/rendering/RenderFullScreen.cpp', u'Source/WebCore/rendering/RenderGeometryMap.cpp', u'Source/WebCore/rendering/RenderGrid.cpp', u'Source/WebCore/rendering/RenderHTMLCanvas.cpp', u'Source/WebCore/rendering/RenderIFrame.cpp', u'Source/WebCore/rendering/RenderImage.cpp', u'Source/WebCore/rendering/RenderImageResource.cpp', u'Source/WebCore/rendering/RenderImageResourceStyleImage.cpp', u'Source/WebCore/rendering/RenderInline.cpp', u'Source/WebCore/rendering/RenderInputSpeech.cpp', u'Source/WebCore/rendering/RenderLayer.cpp', u'Source/WebCore/rendering/RenderLayer.h', u'Source/WebCore/rendering/RenderLayerBacking.cpp', u'Source/WebCore/rendering/RenderLayerCompositor.cpp', u'Source/WebCore/rendering/RenderLayerModelObject.cpp', u'Source/WebCore/rendering/RenderLineBoxList.cpp', u'Source/WebCore/rendering/RenderLineBreak.cpp', u'Source/WebCore/rendering/RenderListBox.cpp', u'Source/WebCore/rendering/RenderListItem.cpp', u'Source/WebCore/rendering/RenderListMarker.cpp', u'Source/WebCore/rendering/RenderMarquee.cpp', u'Source/WebCore/rendering/RenderMedia.cpp', u'Source/WebCore/rendering/RenderMediaControlElements.cpp', u'Source/WebCore/rendering/RenderMediaControls.cpp', u'Source/WebCore/rendering/RenderMenuList.cpp', u'Source/WebCore/rendering/RenderMultiColumnBlock.cpp', u'Source/WebCore/rendering/RenderMultiColumnBlock.h', u'Source/WebCore/rendering/RenderMultiColumnFlowThread.cpp', u'Source/WebCore/rendering/RenderMultiColumnSet.cpp', u'Source/WebCore/rendering/RenderNamedFlowFragment.cpp', u'Source/WebCore/rendering/RenderNamedFlowThread.cpp', u'Source/WebCore/rendering/RenderObject.cpp', u'Source/WebCore/rendering/RenderObject.h', u'Source/WebCore/rendering/RenderProgress.cpp', u'Source/WebCore/rendering/RenderQuote.cpp', u'Source/WebCore/rendering/RenderRegion.cpp', u'Source/WebCore/rendering/RenderReplaced.cpp', u'Source/WebCore/rendering/RenderRuby.cpp', u'Source/WebCore/rendering/RenderRubyRun.cpp', u'Source/WebCore/rendering/RenderRubyText.cpp', u'Source/WebCore/rendering/RenderScrollbar.cpp', u'Source/WebCore/rendering/RenderScrollbarPart.cpp', u'Source/WebCore/rendering/RenderSearchField.cpp', u'Source/WebCore/rendering/RenderSlider.cpp', u'Source/WebCore/rendering/RenderSnapshottedPlugIn.cpp', u'Source/WebCore/rendering/RenderTable.cpp', u'Source/WebCore/rendering/RenderTable.h', u'Source/WebCore/rendering/RenderTableCell.cpp', u'Source/WebCore/rendering/RenderTableCell.h', u'Source/WebCore/rendering/RenderTableCol.cpp', u'Source/WebCore/rendering/RenderTableCol.h', u'Source/WebCore/rendering/RenderTableRow.cpp', u'Source/WebCore/rendering/RenderTableRow.h', u'Source/WebCore/rendering/RenderTableSection.cpp', u'Source/WebCore/rendering/RenderTableSection.h', u'Source/WebCore/rendering/RenderText.cpp', u'Source/WebCore/rendering/RenderText.h', u'Source/WebCore/rendering/RenderTextControl.cpp', u'Source/WebCore/rendering/RenderTextControlMultiLine.cpp', u'Source/WebCore/rendering/RenderTextControlSingleLine.cpp', u'Source/WebCore/rendering/RenderTextFragment.cpp', u'Source/WebCore/rendering/RenderTextLineBoxes.cpp', u'Source/WebCore/rendering/RenderTextTrackCue.cpp', u'Source/WebCore/rendering/RenderTheme.cpp', u'Source/WebCore/rendering/RenderThemeMac.mm', u'Source/WebCore/rendering/RenderThemeSafari.cpp', u'Source/WebCore/rendering/RenderThemeWin.cpp', u'Source/WebCore/rendering/RenderThemeWinCE.cpp', u'Source/WebCore/rendering/RenderTreeAsText.cpp', u'Source/WebCore/rendering/RenderVideo.cpp', u'Source/WebCore/rendering/RenderView.cpp', u'Source/WebCore/rendering/RenderView.h', u'Source/WebCore/rendering/RenderWidget.cpp', u'Source/WebCore/rendering/RootInlineBox.cpp', u'Source/WebCore/rendering/SimpleLineLayout.cpp', u'Source/WebCore/rendering/SimpleLineLayoutFunctions.cpp', u'Source/WebCore/rendering/SimpleLineLayoutResolver.h', u'Source/WebCore/rendering/mathml/RenderMathMLBlock.cpp', u'Source/WebCore/rendering/mathml/RenderMathMLFenced.cpp', u'Source/WebCore/rendering/mathml/RenderMathMLFraction.cpp', u'Source/WebCore/rendering/mathml/RenderMathMLOperator.cpp', u'Source/WebCore/rendering/mathml/RenderMathMLRoot.cpp', u'Source/WebCore/rendering/mathml/RenderMathMLRow.cpp', u'Source/WebCore/rendering/mathml/RenderMathMLScripts.cpp', u'Source/WebCore/rendering/mathml/RenderMathMLSpace.cpp', u'Source/WebCore/rendering/shapes/ShapeInfo.cpp', u'Source/WebCore/rendering/shapes/ShapeInfo.h', u'Source/WebCore/rendering/shapes/ShapeInsideInfo.cpp', u'Source/WebCore/rendering/shapes/ShapeOutsideInfo.cpp', u'Source/WebCore/rendering/svg/RenderSVGBlock.cpp', u'Source/WebCore/rendering/svg/RenderSVGContainer.cpp', u'Source/WebCore/rendering/svg/RenderSVGEllipse.cpp', u'Source/WebCore/rendering/svg/RenderSVGImage.cpp', u'Source/WebCore/rendering/svg/RenderSVGInline.cpp', u'Source/WebCore/rendering/svg/RenderSVGInlineText.cpp', u'Source/WebCore/rendering/svg/RenderSVGModelObject.cpp', u'Source/WebCore/rendering/svg/RenderSVGPath.cpp', u'Source/WebCore/rendering/svg/RenderSVGRect.cpp', u'Source/WebCore/rendering/svg/RenderSVGResource.cpp', u'Source/WebCore/rendering/svg/RenderSVGResourceClipper.cpp', u'Source/WebCore/rendering/svg/RenderSVGResourceContainer.cpp', u'Source/WebCore/rendering/svg/RenderSVGResourceFilter.cpp', u'Source/WebCore/rendering/svg/RenderSVGResourceFilterPrimitive.cpp', u'Source/WebCore/rendering/svg/RenderSVGResourceMasker.cpp', u'Source/WebCore/rendering/svg/RenderSVGRoot.cpp', u'Source/WebCore/rendering/svg/RenderSVGShape.cpp', u'Source/WebCore/rendering/svg/RenderSVGShape.h', u'Source/WebCore/rendering/svg/RenderSVGText.cpp', u'Source/WebCore/rendering/svg/SVGInlineFlowBox.cpp', u'Source/WebCore/rendering/svg/SVGInlineTextBox.cpp', u'Source/WebCore/rendering/svg/SVGRenderSupport.cpp', u'Source/WebCore/rendering/svg/SVGRenderTreeAsText.cpp', u'Source/WebCore/rendering/svg/SVGRenderingContext.cpp', u'Source/WebCore/rendering/svg/SVGTextChunkBuilder.cpp', u'Source/WebCore/rendering/svg/SVGTextLayoutAttributesBuilder.cpp', u'Source/WebCore/rendering/svg/SVGTextLayoutEngine.cpp', u'Source/WebCore/rendering/svg/SVGTextLayoutEngineBaseline.cpp', u'Source/WebCore/rendering/svg/SVGTextMetrics.cpp', u'Source/WebCore/rendering/svg/SVGTextMetricsBuilder.cpp', u'Source/WebCore/rendering/svg/SVGTextQuery.cpp', u'Source/WebCore/rendering/svg/SVGTextRunRenderingContext.cpp', u'Source/WebCore/style/StyleResolveForDocument.cpp', u'Source/WebCore/style/StyleResolveTree.cpp', u'Source/WebCore/svg/SVGAnimatedColor.cpp', u'Source/WebCore/svg/SVGElement.cpp', u'Source/WebCore/svg/SVGFEDiffuseLightingElement.cpp', u'Source/WebCore/svg/SVGFEDropShadowElement.cpp', u'Source/WebCore/svg/SVGFEFloodElement.cpp', u'Source/WebCore/svg/SVGFESpecularLightingElement.cpp', u'Source/WebCore/svg/SVGFontData.cpp', u'Source/WebCore/svg/SVGGraphicsElement.cpp', u'Source/WebCore/svg/SVGLengthContext.cpp', u'Source/WebCore/svg/SVGSVGElement.cpp', u'Source/WebCore/svg/SVGStopElement.cpp', u'Source/WebCore/svg/SVGTextElement.cpp', u'Source/WebCore/svg/graphics/SVGImage.cpp', u'Source/WebKit/mac/WebView/WebFrame.mm', u'Source/WebKit/mac/WebView/WebFrameView.mm', u'Source/WebKit/mac/WebView/WebHTMLRepresentation.mm', u'Source/WebKit/mac/WebView/WebHTMLView.mm', u'Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm']" exit_code: 1
Source/WebCore/rendering/RenderListMarker.cpp:1659:  Else clause should never be on same line as else (use 2 lines)  [whitespace/newline] [4]
Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp:102:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp:364:  Omit int when using unsigned  [runtime/unsigned] [1]
Source/WebCore/rendering/RenderBox.cpp:1512:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/rendering/RenderBox.cpp:2476:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Source/WebCore/rendering/RenderBox.cpp:4588:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Source/WebCore/rendering/RenderBox.cpp:4595:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Source/WebCore/dom/Position.cpp:983:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/platform/gtk/RenderThemeGtk.cpp:338:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Source/WebCore/platform/gtk/RenderThemeGtk.cpp:357:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Source/WebCore/platform/gtk/RenderThemeGtk.cpp:385:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Source/WebCore/rendering/RenderLayer.cpp:1337:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/rendering/RenderThemeSafari.cpp:813:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/rendering/RenderThemeSafari.cpp:814:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/rendering/RenderThemeSafari.cpp:815:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/editing/DeleteSelectionCommand.cpp:585:  Missing spaces around |  [whitespace/operators] [3]
Source/WebCore/rendering/RenderBlock.cpp:4086:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/rendering/RenderBlock.cpp:4089:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/rendering/InlineBox.cpp:370:  An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
Source/WebCore/rendering/RenderThemeWin.cpp:688:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/rendering/RenderThemeWin.cpp:689:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/rendering/RenderThemeWin.cpp:689:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Total errors found: 22 in 257 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 EFL EWS Bot 2013-10-28 15:29:28 PDT
Comment on attachment 215337 [details]
Snack for EWS

Attachment 215337 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/16018019
Comment 7 Build Bot 2013-10-28 15:51:49 PDT
Comment on attachment 215337 [details]
Snack for EWS

Attachment 215337 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/16288010
Comment 8 kov's GTK+ EWS bot 2013-10-28 15:59:31 PDT
Comment on attachment 215337 [details]
Snack for EWS

Attachment 215337 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/16018026
Comment 9 Andreas Kling 2013-10-28 16:45:37 PDT
Created attachment 215347 [details]
Patch
Comment 10 WebKit Commit Bot 2013-10-28 16:48:52 PDT
Attachment 215347 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/accessibility/AccessibilityMediaControls.cpp', u'Source/WebCore/accessibility/AccessibilityObject.cpp', u'Source/WebCore/accessibility/AccessibilityRenderObject.cpp', u'Source/WebCore/accessibility/AccessibilitySlider.cpp', u'Source/WebCore/accessibility/AccessibilityTable.cpp', u'Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceText.cpp', u'Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm', u'Source/WebCore/bindings/objc/DOM.mm', u'Source/WebCore/css/CSSComputedStyleDeclaration.cpp', u'Source/WebCore/css/CSSGradientValue.cpp', u'Source/WebCore/css/CSSGradientValue.h', u'Source/WebCore/css/StyleResolver.cpp', u'Source/WebCore/dom/Document.cpp', u'Source/WebCore/dom/Element.cpp', u'Source/WebCore/dom/Node.cpp', u'Source/WebCore/dom/NodeRenderStyle.h', u'Source/WebCore/dom/Position.cpp', u'Source/WebCore/dom/PositionIterator.cpp', u'Source/WebCore/dom/PseudoElement.cpp', u'Source/WebCore/dom/Range.cpp', u'Source/WebCore/editing/ApplyBlockElementCommand.cpp', u'Source/WebCore/editing/ApplyStyleCommand.cpp', u'Source/WebCore/editing/CompositeEditCommand.cpp', u'Source/WebCore/editing/DeleteButtonController.cpp', u'Source/WebCore/editing/DeleteSelectionCommand.cpp', u'Source/WebCore/editing/Editor.cpp', u'Source/WebCore/editing/EditorCommand.cpp', u'Source/WebCore/editing/FrameSelection.cpp', u'Source/WebCore/editing/HTMLInterchange.cpp', u'Source/WebCore/editing/InsertLineBreakCommand.cpp', u'Source/WebCore/editing/InsertParagraphSeparatorCommand.cpp', u'Source/WebCore/editing/ReplaceSelectionCommand.cpp', u'Source/WebCore/editing/TextIterator.cpp', u'Source/WebCore/editing/VisibleUnits.cpp', u'Source/WebCore/editing/htmlediting.cpp', u'Source/WebCore/editing/ios/EditorIOS.mm', u'Source/WebCore/editing/mac/EditorMac.mm', u'Source/WebCore/editing/markup.cpp', u'Source/WebCore/html/HTMLAppletElement.cpp', u'Source/WebCore/html/HTMLAreaElement.cpp', u'Source/WebCore/html/HTMLCanvasElement.cpp', u'Source/WebCore/html/HTMLElement.cpp', u'Source/WebCore/html/HTMLFormControlElement.cpp', u'Source/WebCore/html/HTMLInputElement.cpp', u'Source/WebCore/html/HTMLMediaElement.cpp', u'Source/WebCore/html/HTMLOptionElement.cpp', u'Source/WebCore/html/HTMLPlugInImageElement.cpp', u'Source/WebCore/html/HTMLTextFormControlElement.cpp', u'Source/WebCore/html/RangeInputType.cpp', u'Source/WebCore/html/TextFieldInputType.cpp', u'Source/WebCore/html/parser/HTMLResourcePreloader.cpp', u'Source/WebCore/html/shadow/MeterShadowElement.cpp', u'Source/WebCore/html/shadow/ProgressShadowElement.cpp', u'Source/WebCore/html/shadow/SliderThumbElement.cpp', u'Source/WebCore/html/shadow/TextControlInnerElements.cpp', u'Source/WebCore/inspector/InspectorLayerTreeAgent.cpp', u'Source/WebCore/inspector/InspectorOverlay.cpp', u'Source/WebCore/loader/cache/CachedImage.cpp', u'Source/WebCore/page/Chrome.cpp', u'Source/WebCore/page/DragController.cpp', u'Source/WebCore/page/EventHandler.cpp', u'Source/WebCore/page/Frame.cpp', u'Source/WebCore/page/FrameView.cpp', u'Source/WebCore/page/PrintContext.cpp', u'Source/WebCore/page/SpatialNavigation.cpp', u'Source/WebCore/page/animation/AnimationController.cpp', u'Source/WebCore/page/animation/CSSPropertyAnimation.cpp', u'Source/WebCore/page/animation/KeyframeAnimation.cpp', u'Source/WebCore/platform/efl/RenderThemeEfl.cpp', u'Source/WebCore/platform/graphics/mac/ComplexTextController.cpp', u'Source/WebCore/platform/gtk/RenderThemeGtk.cpp', u'Source/WebCore/platform/gtk/RenderThemeGtk2.cpp', u'Source/WebCore/platform/gtk/RenderThemeGtk3.cpp', u'Source/WebCore/platform/mac/HTMLConverter.mm', u'Source/WebCore/rendering/AutoTableLayout.cpp', u'Source/WebCore/rendering/EllipsisBox.cpp', u'Source/WebCore/rendering/FilterEffectRenderer.cpp', u'Source/WebCore/rendering/FixedTableLayout.cpp', u'Source/WebCore/rendering/FloatingObjects.cpp', u'Source/WebCore/rendering/FlowThreadController.cpp', u'Source/WebCore/rendering/HitTestResult.cpp', u'Source/WebCore/rendering/ImageQualityController.cpp', u'Source/WebCore/rendering/InlineBox.cpp', u'Source/WebCore/rendering/InlineBox.h', u'Source/WebCore/rendering/InlineFlowBox.cpp', u'Source/WebCore/rendering/InlineFlowBox.h', u'Source/WebCore/rendering/InlineIterator.h', u'Source/WebCore/rendering/InlineTextBox.cpp', u'Source/WebCore/rendering/InlineTextBox.h', u'Source/WebCore/rendering/LayoutState.cpp', u'Source/WebCore/rendering/LineWidth.cpp', u'Source/WebCore/rendering/LogicalSelectionOffsetCaches.h', u'Source/WebCore/rendering/OrderIterator.cpp', u'Source/WebCore/rendering/RenderBlock.cpp', u'Source/WebCore/rendering/RenderBlock.h', u'Source/WebCore/rendering/RenderBlockFlow.cpp', u'Source/WebCore/rendering/RenderBlockLineLayout.cpp', u'Source/WebCore/rendering/RenderBox.cpp', u'Source/WebCore/rendering/RenderBox.h', u'Source/WebCore/rendering/RenderBoxModelObject.cpp', u'Source/WebCore/rendering/RenderBoxModelObject.h', u'Source/WebCore/rendering/RenderButton.cpp', u'Source/WebCore/rendering/RenderCombineText.cpp', u'Source/WebCore/rendering/RenderCombineText.h', u'Source/WebCore/rendering/RenderCounter.cpp', u'Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp', u'Source/WebCore/rendering/RenderDeprecatedFlexibleBox.h', u'Source/WebCore/rendering/RenderDetailsMarker.cpp', u'Source/WebCore/rendering/RenderElement.cpp', u'Source/WebCore/rendering/RenderElement.h', u'Source/WebCore/rendering/RenderEmbeddedObject.cpp', u'Source/WebCore/rendering/RenderFieldset.cpp', u'Source/WebCore/rendering/RenderFileUploadControl.cpp', u'Source/WebCore/rendering/RenderFlexibleBox.cpp', u'Source/WebCore/rendering/RenderFlowThread.cpp', u'Source/WebCore/rendering/RenderFrameSet.cpp', u'Source/WebCore/rendering/RenderFullScreen.cpp', u'Source/WebCore/rendering/RenderGeometryMap.cpp', u'Source/WebCore/rendering/RenderGrid.cpp', u'Source/WebCore/rendering/RenderHTMLCanvas.cpp', u'Source/WebCore/rendering/RenderIFrame.cpp', u'Source/WebCore/rendering/RenderImage.cpp', u'Source/WebCore/rendering/RenderImageResource.cpp', u'Source/WebCore/rendering/RenderImageResourceStyleImage.cpp', u'Source/WebCore/rendering/RenderInline.cpp', u'Source/WebCore/rendering/RenderInputSpeech.cpp', u'Source/WebCore/rendering/RenderLayer.cpp', u'Source/WebCore/rendering/RenderLayer.h', u'Source/WebCore/rendering/RenderLayerBacking.cpp', u'Source/WebCore/rendering/RenderLayerCompositor.cpp', u'Source/WebCore/rendering/RenderLayerModelObject.cpp', u'Source/WebCore/rendering/RenderLineBoxList.cpp', u'Source/WebCore/rendering/RenderLineBreak.cpp', u'Source/WebCore/rendering/RenderListBox.cpp', u'Source/WebCore/rendering/RenderListItem.cpp', u'Source/WebCore/rendering/RenderListMarker.cpp', u'Source/WebCore/rendering/RenderMarquee.cpp', u'Source/WebCore/rendering/RenderMedia.cpp', u'Source/WebCore/rendering/RenderMediaControlElements.cpp', u'Source/WebCore/rendering/RenderMediaControls.cpp', u'Source/WebCore/rendering/RenderMenuList.cpp', u'Source/WebCore/rendering/RenderMultiColumnBlock.cpp', u'Source/WebCore/rendering/RenderMultiColumnBlock.h', u'Source/WebCore/rendering/RenderMultiColumnFlowThread.cpp', u'Source/WebCore/rendering/RenderMultiColumnSet.cpp', u'Source/WebCore/rendering/RenderNamedFlowFragment.cpp', u'Source/WebCore/rendering/RenderNamedFlowThread.cpp', u'Source/WebCore/rendering/RenderObject.cpp', u'Source/WebCore/rendering/RenderObject.h', u'Source/WebCore/rendering/RenderProgress.cpp', u'Source/WebCore/rendering/RenderQuote.cpp', u'Source/WebCore/rendering/RenderRegion.cpp', u'Source/WebCore/rendering/RenderReplaced.cpp', u'Source/WebCore/rendering/RenderRuby.cpp', u'Source/WebCore/rendering/RenderRubyRun.cpp', u'Source/WebCore/rendering/RenderRubyText.cpp', u'Source/WebCore/rendering/RenderScrollbar.cpp', u'Source/WebCore/rendering/RenderScrollbarPart.cpp', u'Source/WebCore/rendering/RenderSearchField.cpp', u'Source/WebCore/rendering/RenderSlider.cpp', u'Source/WebCore/rendering/RenderSnapshottedPlugIn.cpp', u'Source/WebCore/rendering/RenderTable.cpp', u'Source/WebCore/rendering/RenderTable.h', u'Source/WebCore/rendering/RenderTableCell.cpp', u'Source/WebCore/rendering/RenderTableCell.h', u'Source/WebCore/rendering/RenderTableCol.cpp', u'Source/WebCore/rendering/RenderTableCol.h', u'Source/WebCore/rendering/RenderTableRow.cpp', u'Source/WebCore/rendering/RenderTableRow.h', u'Source/WebCore/rendering/RenderTableSection.cpp', u'Source/WebCore/rendering/RenderTableSection.h', u'Source/WebCore/rendering/RenderText.cpp', u'Source/WebCore/rendering/RenderText.h', u'Source/WebCore/rendering/RenderTextControl.cpp', u'Source/WebCore/rendering/RenderTextControlMultiLine.cpp', u'Source/WebCore/rendering/RenderTextControlSingleLine.cpp', u'Source/WebCore/rendering/RenderTextFragment.cpp', u'Source/WebCore/rendering/RenderTextLineBoxes.cpp', u'Source/WebCore/rendering/RenderTextTrackCue.cpp', u'Source/WebCore/rendering/RenderTheme.cpp', u'Source/WebCore/rendering/RenderThemeMac.mm', u'Source/WebCore/rendering/RenderThemeSafari.cpp', u'Source/WebCore/rendering/RenderThemeWin.cpp', u'Source/WebCore/rendering/RenderThemeWinCE.cpp', u'Source/WebCore/rendering/RenderTreeAsText.cpp', u'Source/WebCore/rendering/RenderVideo.cpp', u'Source/WebCore/rendering/RenderView.cpp', u'Source/WebCore/rendering/RenderView.h', u'Source/WebCore/rendering/RenderWidget.cpp', u'Source/WebCore/rendering/RootInlineBox.cpp', u'Source/WebCore/rendering/SimpleLineLayout.cpp', u'Source/WebCore/rendering/SimpleLineLayoutFunctions.cpp', u'Source/WebCore/rendering/SimpleLineLayoutResolver.h', u'Source/WebCore/rendering/mathml/RenderMathMLBlock.cpp', u'Source/WebCore/rendering/mathml/RenderMathMLFenced.cpp', u'Source/WebCore/rendering/mathml/RenderMathMLFraction.cpp', u'Source/WebCore/rendering/mathml/RenderMathMLOperator.cpp', u'Source/WebCore/rendering/mathml/RenderMathMLRoot.cpp', u'Source/WebCore/rendering/mathml/RenderMathMLRow.cpp', u'Source/WebCore/rendering/mathml/RenderMathMLScripts.cpp', u'Source/WebCore/rendering/mathml/RenderMathMLSpace.cpp', u'Source/WebCore/rendering/shapes/ShapeInfo.cpp', u'Source/WebCore/rendering/shapes/ShapeInfo.h', u'Source/WebCore/rendering/shapes/ShapeInsideInfo.cpp', u'Source/WebCore/rendering/shapes/ShapeOutsideInfo.cpp', u'Source/WebCore/rendering/svg/RenderSVGBlock.cpp', u'Source/WebCore/rendering/svg/RenderSVGContainer.cpp', u'Source/WebCore/rendering/svg/RenderSVGEllipse.cpp', u'Source/WebCore/rendering/svg/RenderSVGImage.cpp', u'Source/WebCore/rendering/svg/RenderSVGInline.cpp', u'Source/WebCore/rendering/svg/RenderSVGInlineText.cpp', u'Source/WebCore/rendering/svg/RenderSVGModelObject.cpp', u'Source/WebCore/rendering/svg/RenderSVGPath.cpp', u'Source/WebCore/rendering/svg/RenderSVGRect.cpp', u'Source/WebCore/rendering/svg/RenderSVGResource.cpp', u'Source/WebCore/rendering/svg/RenderSVGResourceClipper.cpp', u'Source/WebCore/rendering/svg/RenderSVGResourceContainer.cpp', u'Source/WebCore/rendering/svg/RenderSVGResourceFilter.cpp', u'Source/WebCore/rendering/svg/RenderSVGResourceFilterPrimitive.cpp', u'Source/WebCore/rendering/svg/RenderSVGResourceMasker.cpp', u'Source/WebCore/rendering/svg/RenderSVGRoot.cpp', u'Source/WebCore/rendering/svg/RenderSVGShape.cpp', u'Source/WebCore/rendering/svg/RenderSVGShape.h', u'Source/WebCore/rendering/svg/RenderSVGText.cpp', u'Source/WebCore/rendering/svg/SVGInlineFlowBox.cpp', u'Source/WebCore/rendering/svg/SVGInlineTextBox.cpp', u'Source/WebCore/rendering/svg/SVGRenderSupport.cpp', u'Source/WebCore/rendering/svg/SVGRenderTreeAsText.cpp', u'Source/WebCore/rendering/svg/SVGRenderingContext.cpp', u'Source/WebCore/rendering/svg/SVGTextChunkBuilder.cpp', u'Source/WebCore/rendering/svg/SVGTextLayoutAttributesBuilder.cpp', u'Source/WebCore/rendering/svg/SVGTextLayoutEngine.cpp', u'Source/WebCore/rendering/svg/SVGTextLayoutEngineBaseline.cpp', u'Source/WebCore/rendering/svg/SVGTextMetrics.cpp', u'Source/WebCore/rendering/svg/SVGTextMetricsBuilder.cpp', u'Source/WebCore/rendering/svg/SVGTextQuery.cpp', u'Source/WebCore/rendering/svg/SVGTextRunRenderingContext.cpp', u'Source/WebCore/style/StyleResolveForDocument.cpp', u'Source/WebCore/style/StyleResolveTree.cpp', u'Source/WebCore/svg/SVGAnimatedColor.cpp', u'Source/WebCore/svg/SVGElement.cpp', u'Source/WebCore/svg/SVGFEDiffuseLightingElement.cpp', u'Source/WebCore/svg/SVGFEDropShadowElement.cpp', u'Source/WebCore/svg/SVGFEFloodElement.cpp', u'Source/WebCore/svg/SVGFESpecularLightingElement.cpp', u'Source/WebCore/svg/SVGFontData.cpp', u'Source/WebCore/svg/SVGGraphicsElement.cpp', u'Source/WebCore/svg/SVGLengthContext.cpp', u'Source/WebCore/svg/SVGSVGElement.cpp', u'Source/WebCore/svg/SVGStopElement.cpp', u'Source/WebCore/svg/SVGTextElement.cpp', u'Source/WebCore/svg/graphics/SVGImage.cpp', u'Source/WebKit/mac/WebView/WebFrame.mm', u'Source/WebKit/mac/WebView/WebFrameView.mm', u'Source/WebKit/mac/WebView/WebHTMLRepresentation.mm', u'Source/WebKit/mac/WebView/WebHTMLView.mm', u'Source/WebKit/win/DOMCoreClasses.cpp', u'Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm']" exit_code: 1
Source/WebCore/rendering/RenderListMarker.cpp:1659:  Else clause should never be on same line as else (use 2 lines)  [whitespace/newline] [4]
Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp:102:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp:364:  Omit int when using unsigned  [runtime/unsigned] [1]
Source/WebCore/rendering/RenderBox.cpp:1512:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/rendering/RenderBox.cpp:2476:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Source/WebCore/rendering/RenderBox.cpp:4588:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Source/WebCore/rendering/RenderBox.cpp:4595:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Source/WebCore/dom/Position.cpp:983:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/platform/gtk/RenderThemeGtk.cpp:338:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Source/WebCore/platform/gtk/RenderThemeGtk.cpp:357:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Source/WebCore/platform/gtk/RenderThemeGtk.cpp:385:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Source/WebCore/rendering/RenderLayer.cpp:1337:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/rendering/RenderThemeSafari.cpp:813:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/rendering/RenderThemeSafari.cpp:814:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/rendering/RenderThemeSafari.cpp:815:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/editing/DeleteSelectionCommand.cpp:585:  Missing spaces around |  [whitespace/operators] [3]
Source/WebCore/rendering/RenderBlock.cpp:4086:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/rendering/RenderBlock.cpp:4089:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/rendering/InlineBox.cpp:370:  An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
Source/WebCore/rendering/RenderThemeWin.cpp:688:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/rendering/RenderThemeWin.cpp:689:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/rendering/RenderThemeWin.cpp:689:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Total errors found: 22 in 258 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 11 EFL EWS Bot 2013-10-28 17:00:27 PDT
Comment on attachment 215347 [details]
Patch

Attachment 215347 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/16238025
Comment 12 Andreas Kling 2013-10-28 17:02:31 PDT
Created attachment 215349 [details]
Patch

lalalala..
Comment 13 WebKit Commit Bot 2013-10-28 17:05:49 PDT
Attachment 215349 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/accessibility/AccessibilityMediaControls.cpp', u'Source/WebCore/accessibility/AccessibilityObject.cpp', u'Source/WebCore/accessibility/AccessibilityRenderObject.cpp', u'Source/WebCore/accessibility/AccessibilitySlider.cpp', u'Source/WebCore/accessibility/AccessibilityTable.cpp', u'Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceText.cpp', u'Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm', u'Source/WebCore/bindings/objc/DOM.mm', u'Source/WebCore/css/CSSComputedStyleDeclaration.cpp', u'Source/WebCore/css/CSSGradientValue.cpp', u'Source/WebCore/css/CSSGradientValue.h', u'Source/WebCore/css/StyleResolver.cpp', u'Source/WebCore/dom/Document.cpp', u'Source/WebCore/dom/Element.cpp', u'Source/WebCore/dom/Node.cpp', u'Source/WebCore/dom/NodeRenderStyle.h', u'Source/WebCore/dom/Position.cpp', u'Source/WebCore/dom/PositionIterator.cpp', u'Source/WebCore/dom/PseudoElement.cpp', u'Source/WebCore/dom/Range.cpp', u'Source/WebCore/editing/ApplyBlockElementCommand.cpp', u'Source/WebCore/editing/ApplyStyleCommand.cpp', u'Source/WebCore/editing/CompositeEditCommand.cpp', u'Source/WebCore/editing/DeleteButtonController.cpp', u'Source/WebCore/editing/DeleteSelectionCommand.cpp', u'Source/WebCore/editing/Editor.cpp', u'Source/WebCore/editing/EditorCommand.cpp', u'Source/WebCore/editing/FrameSelection.cpp', u'Source/WebCore/editing/HTMLInterchange.cpp', u'Source/WebCore/editing/InsertLineBreakCommand.cpp', u'Source/WebCore/editing/InsertParagraphSeparatorCommand.cpp', u'Source/WebCore/editing/ReplaceSelectionCommand.cpp', u'Source/WebCore/editing/TextIterator.cpp', u'Source/WebCore/editing/VisibleUnits.cpp', u'Source/WebCore/editing/htmlediting.cpp', u'Source/WebCore/editing/ios/EditorIOS.mm', u'Source/WebCore/editing/mac/EditorMac.mm', u'Source/WebCore/editing/markup.cpp', u'Source/WebCore/html/HTMLAppletElement.cpp', u'Source/WebCore/html/HTMLAreaElement.cpp', u'Source/WebCore/html/HTMLCanvasElement.cpp', u'Source/WebCore/html/HTMLElement.cpp', u'Source/WebCore/html/HTMLFormControlElement.cpp', u'Source/WebCore/html/HTMLInputElement.cpp', u'Source/WebCore/html/HTMLMediaElement.cpp', u'Source/WebCore/html/HTMLOptionElement.cpp', u'Source/WebCore/html/HTMLPlugInImageElement.cpp', u'Source/WebCore/html/HTMLTextFormControlElement.cpp', u'Source/WebCore/html/RangeInputType.cpp', u'Source/WebCore/html/TextFieldInputType.cpp', u'Source/WebCore/html/parser/HTMLResourcePreloader.cpp', u'Source/WebCore/html/shadow/MeterShadowElement.cpp', u'Source/WebCore/html/shadow/ProgressShadowElement.cpp', u'Source/WebCore/html/shadow/SliderThumbElement.cpp', u'Source/WebCore/html/shadow/TextControlInnerElements.cpp', u'Source/WebCore/inspector/InspectorLayerTreeAgent.cpp', u'Source/WebCore/inspector/InspectorOverlay.cpp', u'Source/WebCore/loader/cache/CachedImage.cpp', u'Source/WebCore/page/Chrome.cpp', u'Source/WebCore/page/DragController.cpp', u'Source/WebCore/page/EventHandler.cpp', u'Source/WebCore/page/Frame.cpp', u'Source/WebCore/page/FrameView.cpp', u'Source/WebCore/page/PrintContext.cpp', u'Source/WebCore/page/SpatialNavigation.cpp', u'Source/WebCore/page/animation/AnimationController.cpp', u'Source/WebCore/page/animation/CSSPropertyAnimation.cpp', u'Source/WebCore/page/animation/KeyframeAnimation.cpp', u'Source/WebCore/platform/efl/RenderThemeEfl.cpp', u'Source/WebCore/platform/graphics/mac/ComplexTextController.cpp', u'Source/WebCore/platform/gtk/RenderThemeGtk.cpp', u'Source/WebCore/platform/gtk/RenderThemeGtk2.cpp', u'Source/WebCore/platform/gtk/RenderThemeGtk3.cpp', u'Source/WebCore/platform/mac/HTMLConverter.mm', u'Source/WebCore/rendering/AutoTableLayout.cpp', u'Source/WebCore/rendering/EllipsisBox.cpp', u'Source/WebCore/rendering/FilterEffectRenderer.cpp', u'Source/WebCore/rendering/FixedTableLayout.cpp', u'Source/WebCore/rendering/FloatingObjects.cpp', u'Source/WebCore/rendering/FlowThreadController.cpp', u'Source/WebCore/rendering/HitTestResult.cpp', u'Source/WebCore/rendering/ImageQualityController.cpp', u'Source/WebCore/rendering/InlineBox.cpp', u'Source/WebCore/rendering/InlineBox.h', u'Source/WebCore/rendering/InlineFlowBox.cpp', u'Source/WebCore/rendering/InlineFlowBox.h', u'Source/WebCore/rendering/InlineIterator.h', u'Source/WebCore/rendering/InlineTextBox.cpp', u'Source/WebCore/rendering/InlineTextBox.h', u'Source/WebCore/rendering/LayoutState.cpp', u'Source/WebCore/rendering/LineWidth.cpp', u'Source/WebCore/rendering/LogicalSelectionOffsetCaches.h', u'Source/WebCore/rendering/OrderIterator.cpp', u'Source/WebCore/rendering/RenderBlock.cpp', u'Source/WebCore/rendering/RenderBlock.h', u'Source/WebCore/rendering/RenderBlockFlow.cpp', u'Source/WebCore/rendering/RenderBlockLineLayout.cpp', u'Source/WebCore/rendering/RenderBox.cpp', u'Source/WebCore/rendering/RenderBox.h', u'Source/WebCore/rendering/RenderBoxModelObject.cpp', u'Source/WebCore/rendering/RenderBoxModelObject.h', u'Source/WebCore/rendering/RenderButton.cpp', u'Source/WebCore/rendering/RenderCombineText.cpp', u'Source/WebCore/rendering/RenderCombineText.h', u'Source/WebCore/rendering/RenderCounter.cpp', u'Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp', u'Source/WebCore/rendering/RenderDeprecatedFlexibleBox.h', u'Source/WebCore/rendering/RenderDetailsMarker.cpp', u'Source/WebCore/rendering/RenderElement.cpp', u'Source/WebCore/rendering/RenderElement.h', u'Source/WebCore/rendering/RenderEmbeddedObject.cpp', u'Source/WebCore/rendering/RenderFieldset.cpp', u'Source/WebCore/rendering/RenderFileUploadControl.cpp', u'Source/WebCore/rendering/RenderFlexibleBox.cpp', u'Source/WebCore/rendering/RenderFlowThread.cpp', u'Source/WebCore/rendering/RenderFrameSet.cpp', u'Source/WebCore/rendering/RenderFullScreen.cpp', u'Source/WebCore/rendering/RenderGeometryMap.cpp', u'Source/WebCore/rendering/RenderGrid.cpp', u'Source/WebCore/rendering/RenderHTMLCanvas.cpp', u'Source/WebCore/rendering/RenderIFrame.cpp', u'Source/WebCore/rendering/RenderImage.cpp', u'Source/WebCore/rendering/RenderImageResource.cpp', u'Source/WebCore/rendering/RenderImageResourceStyleImage.cpp', u'Source/WebCore/rendering/RenderInline.cpp', u'Source/WebCore/rendering/RenderInputSpeech.cpp', u'Source/WebCore/rendering/RenderLayer.cpp', u'Source/WebCore/rendering/RenderLayer.h', u'Source/WebCore/rendering/RenderLayerBacking.cpp', u'Source/WebCore/rendering/RenderLayerCompositor.cpp', u'Source/WebCore/rendering/RenderLayerModelObject.cpp', u'Source/WebCore/rendering/RenderLineBoxList.cpp', u'Source/WebCore/rendering/RenderLineBreak.cpp', u'Source/WebCore/rendering/RenderListBox.cpp', u'Source/WebCore/rendering/RenderListItem.cpp', u'Source/WebCore/rendering/RenderListMarker.cpp', u'Source/WebCore/rendering/RenderMarquee.cpp', u'Source/WebCore/rendering/RenderMedia.cpp', u'Source/WebCore/rendering/RenderMediaControlElements.cpp', u'Source/WebCore/rendering/RenderMediaControls.cpp', u'Source/WebCore/rendering/RenderMenuList.cpp', u'Source/WebCore/rendering/RenderMultiColumnBlock.cpp', u'Source/WebCore/rendering/RenderMultiColumnBlock.h', u'Source/WebCore/rendering/RenderMultiColumnFlowThread.cpp', u'Source/WebCore/rendering/RenderMultiColumnSet.cpp', u'Source/WebCore/rendering/RenderNamedFlowFragment.cpp', u'Source/WebCore/rendering/RenderNamedFlowThread.cpp', u'Source/WebCore/rendering/RenderObject.cpp', u'Source/WebCore/rendering/RenderObject.h', u'Source/WebCore/rendering/RenderProgress.cpp', u'Source/WebCore/rendering/RenderQuote.cpp', u'Source/WebCore/rendering/RenderRegion.cpp', u'Source/WebCore/rendering/RenderReplaced.cpp', u'Source/WebCore/rendering/RenderRuby.cpp', u'Source/WebCore/rendering/RenderRubyRun.cpp', u'Source/WebCore/rendering/RenderRubyText.cpp', u'Source/WebCore/rendering/RenderScrollbar.cpp', u'Source/WebCore/rendering/RenderScrollbarPart.cpp', u'Source/WebCore/rendering/RenderSearchField.cpp', u'Source/WebCore/rendering/RenderSlider.cpp', u'Source/WebCore/rendering/RenderSnapshottedPlugIn.cpp', u'Source/WebCore/rendering/RenderTable.cpp', u'Source/WebCore/rendering/RenderTable.h', u'Source/WebCore/rendering/RenderTableCell.cpp', u'Source/WebCore/rendering/RenderTableCell.h', u'Source/WebCore/rendering/RenderTableCol.cpp', u'Source/WebCore/rendering/RenderTableCol.h', u'Source/WebCore/rendering/RenderTableRow.cpp', u'Source/WebCore/rendering/RenderTableRow.h', u'Source/WebCore/rendering/RenderTableSection.cpp', u'Source/WebCore/rendering/RenderTableSection.h', u'Source/WebCore/rendering/RenderText.cpp', u'Source/WebCore/rendering/RenderText.h', u'Source/WebCore/rendering/RenderTextControl.cpp', u'Source/WebCore/rendering/RenderTextControlMultiLine.cpp', u'Source/WebCore/rendering/RenderTextControlSingleLine.cpp', u'Source/WebCore/rendering/RenderTextFragment.cpp', u'Source/WebCore/rendering/RenderTextLineBoxes.cpp', u'Source/WebCore/rendering/RenderTextTrackCue.cpp', u'Source/WebCore/rendering/RenderTheme.cpp', u'Source/WebCore/rendering/RenderThemeMac.mm', u'Source/WebCore/rendering/RenderThemeSafari.cpp', u'Source/WebCore/rendering/RenderThemeWin.cpp', u'Source/WebCore/rendering/RenderThemeWinCE.cpp', u'Source/WebCore/rendering/RenderTreeAsText.cpp', u'Source/WebCore/rendering/RenderVideo.cpp', u'Source/WebCore/rendering/RenderView.cpp', u'Source/WebCore/rendering/RenderView.h', u'Source/WebCore/rendering/RenderWidget.cpp', u'Source/WebCore/rendering/RootInlineBox.cpp', u'Source/WebCore/rendering/SimpleLineLayout.cpp', u'Source/WebCore/rendering/SimpleLineLayoutFunctions.cpp', u'Source/WebCore/rendering/SimpleLineLayoutResolver.h', u'Source/WebCore/rendering/mathml/RenderMathMLBlock.cpp', u'Source/WebCore/rendering/mathml/RenderMathMLFenced.cpp', u'Source/WebCore/rendering/mathml/RenderMathMLFraction.cpp', u'Source/WebCore/rendering/mathml/RenderMathMLOperator.cpp', u'Source/WebCore/rendering/mathml/RenderMathMLRoot.cpp', u'Source/WebCore/rendering/mathml/RenderMathMLRow.cpp', u'Source/WebCore/rendering/mathml/RenderMathMLScripts.cpp', u'Source/WebCore/rendering/mathml/RenderMathMLSpace.cpp', u'Source/WebCore/rendering/shapes/ShapeInfo.cpp', u'Source/WebCore/rendering/shapes/ShapeInfo.h', u'Source/WebCore/rendering/shapes/ShapeInsideInfo.cpp', u'Source/WebCore/rendering/shapes/ShapeOutsideInfo.cpp', u'Source/WebCore/rendering/svg/RenderSVGBlock.cpp', u'Source/WebCore/rendering/svg/RenderSVGContainer.cpp', u'Source/WebCore/rendering/svg/RenderSVGEllipse.cpp', u'Source/WebCore/rendering/svg/RenderSVGImage.cpp', u'Source/WebCore/rendering/svg/RenderSVGInline.cpp', u'Source/WebCore/rendering/svg/RenderSVGInlineText.cpp', u'Source/WebCore/rendering/svg/RenderSVGModelObject.cpp', u'Source/WebCore/rendering/svg/RenderSVGPath.cpp', u'Source/WebCore/rendering/svg/RenderSVGRect.cpp', u'Source/WebCore/rendering/svg/RenderSVGResource.cpp', u'Source/WebCore/rendering/svg/RenderSVGResourceClipper.cpp', u'Source/WebCore/rendering/svg/RenderSVGResourceContainer.cpp', u'Source/WebCore/rendering/svg/RenderSVGResourceFilter.cpp', u'Source/WebCore/rendering/svg/RenderSVGResourceFilterPrimitive.cpp', u'Source/WebCore/rendering/svg/RenderSVGResourceMasker.cpp', u'Source/WebCore/rendering/svg/RenderSVGRoot.cpp', u'Source/WebCore/rendering/svg/RenderSVGShape.cpp', u'Source/WebCore/rendering/svg/RenderSVGShape.h', u'Source/WebCore/rendering/svg/RenderSVGText.cpp', u'Source/WebCore/rendering/svg/SVGInlineFlowBox.cpp', u'Source/WebCore/rendering/svg/SVGInlineTextBox.cpp', u'Source/WebCore/rendering/svg/SVGRenderSupport.cpp', u'Source/WebCore/rendering/svg/SVGRenderTreeAsText.cpp', u'Source/WebCore/rendering/svg/SVGRenderingContext.cpp', u'Source/WebCore/rendering/svg/SVGTextChunkBuilder.cpp', u'Source/WebCore/rendering/svg/SVGTextLayoutAttributesBuilder.cpp', u'Source/WebCore/rendering/svg/SVGTextLayoutEngine.cpp', u'Source/WebCore/rendering/svg/SVGTextLayoutEngineBaseline.cpp', u'Source/WebCore/rendering/svg/SVGTextMetrics.cpp', u'Source/WebCore/rendering/svg/SVGTextMetricsBuilder.cpp', u'Source/WebCore/rendering/svg/SVGTextQuery.cpp', u'Source/WebCore/rendering/svg/SVGTextRunRenderingContext.cpp', u'Source/WebCore/style/StyleResolveForDocument.cpp', u'Source/WebCore/style/StyleResolveTree.cpp', u'Source/WebCore/svg/SVGAnimatedColor.cpp', u'Source/WebCore/svg/SVGElement.cpp', u'Source/WebCore/svg/SVGFEDiffuseLightingElement.cpp', u'Source/WebCore/svg/SVGFEDropShadowElement.cpp', u'Source/WebCore/svg/SVGFEFloodElement.cpp', u'Source/WebCore/svg/SVGFESpecularLightingElement.cpp', u'Source/WebCore/svg/SVGFontData.cpp', u'Source/WebCore/svg/SVGGraphicsElement.cpp', u'Source/WebCore/svg/SVGLengthContext.cpp', u'Source/WebCore/svg/SVGSVGElement.cpp', u'Source/WebCore/svg/SVGStopElement.cpp', u'Source/WebCore/svg/SVGTextElement.cpp', u'Source/WebCore/svg/graphics/SVGImage.cpp', u'Source/WebKit/mac/WebView/WebFrame.mm', u'Source/WebKit/mac/WebView/WebFrameView.mm', u'Source/WebKit/mac/WebView/WebHTMLRepresentation.mm', u'Source/WebKit/mac/WebView/WebHTMLView.mm', u'Source/WebKit/win/DOMCoreClasses.cpp', u'Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm']" exit_code: 1
Source/WebCore/rendering/RenderListMarker.cpp:1659:  Else clause should never be on same line as else (use 2 lines)  [whitespace/newline] [4]
Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp:102:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp:364:  Omit int when using unsigned  [runtime/unsigned] [1]
Source/WebCore/rendering/RenderBox.cpp:1512:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/rendering/RenderBox.cpp:2476:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Source/WebCore/rendering/RenderBox.cpp:4588:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Source/WebCore/rendering/RenderBox.cpp:4595:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Source/WebCore/dom/Position.cpp:983:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/platform/gtk/RenderThemeGtk.cpp:338:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Source/WebCore/platform/gtk/RenderThemeGtk.cpp:357:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Source/WebCore/platform/gtk/RenderThemeGtk.cpp:385:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Source/WebCore/rendering/RenderLayer.cpp:1337:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/rendering/RenderThemeSafari.cpp:813:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/rendering/RenderThemeSafari.cpp:814:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/rendering/RenderThemeSafari.cpp:815:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/editing/DeleteSelectionCommand.cpp:585:  Missing spaces around |  [whitespace/operators] [3]
Source/WebCore/rendering/RenderBlock.cpp:4086:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/rendering/RenderBlock.cpp:4089:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/rendering/InlineBox.cpp:370:  An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
Source/WebCore/rendering/RenderThemeWin.cpp:688:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/rendering/RenderThemeWin.cpp:689:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/rendering/RenderThemeWin.cpp:689:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Total errors found: 22 in 258 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 14 EFL EWS Bot 2013-10-28 17:21:21 PDT
Comment on attachment 215349 [details]
Patch

Attachment 215349 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/16268052
Comment 15 Andreas Kling 2013-10-28 17:32:01 PDT
Created attachment 215351 [details]
Patch
Comment 16 WebKit Commit Bot 2013-10-28 17:35:33 PDT
Attachment 215351 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/accessibility/AccessibilityMediaControls.cpp', u'Source/WebCore/accessibility/AccessibilityObject.cpp', u'Source/WebCore/accessibility/AccessibilityRenderObject.cpp', u'Source/WebCore/accessibility/AccessibilitySlider.cpp', u'Source/WebCore/accessibility/AccessibilityTable.cpp', u'Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceText.cpp', u'Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm', u'Source/WebCore/bindings/objc/DOM.mm', u'Source/WebCore/css/CSSComputedStyleDeclaration.cpp', u'Source/WebCore/css/CSSGradientValue.cpp', u'Source/WebCore/css/CSSGradientValue.h', u'Source/WebCore/css/StyleResolver.cpp', u'Source/WebCore/dom/Document.cpp', u'Source/WebCore/dom/Element.cpp', u'Source/WebCore/dom/Node.cpp', u'Source/WebCore/dom/NodeRenderStyle.h', u'Source/WebCore/dom/Position.cpp', u'Source/WebCore/dom/PositionIterator.cpp', u'Source/WebCore/dom/PseudoElement.cpp', u'Source/WebCore/dom/Range.cpp', u'Source/WebCore/editing/ApplyBlockElementCommand.cpp', u'Source/WebCore/editing/ApplyStyleCommand.cpp', u'Source/WebCore/editing/CompositeEditCommand.cpp', u'Source/WebCore/editing/DeleteButtonController.cpp', u'Source/WebCore/editing/DeleteSelectionCommand.cpp', u'Source/WebCore/editing/Editor.cpp', u'Source/WebCore/editing/EditorCommand.cpp', u'Source/WebCore/editing/FrameSelection.cpp', u'Source/WebCore/editing/HTMLInterchange.cpp', u'Source/WebCore/editing/InsertLineBreakCommand.cpp', u'Source/WebCore/editing/InsertParagraphSeparatorCommand.cpp', u'Source/WebCore/editing/ReplaceSelectionCommand.cpp', u'Source/WebCore/editing/TextIterator.cpp', u'Source/WebCore/editing/VisibleUnits.cpp', u'Source/WebCore/editing/htmlediting.cpp', u'Source/WebCore/editing/ios/EditorIOS.mm', u'Source/WebCore/editing/mac/EditorMac.mm', u'Source/WebCore/editing/markup.cpp', u'Source/WebCore/html/HTMLAppletElement.cpp', u'Source/WebCore/html/HTMLAreaElement.cpp', u'Source/WebCore/html/HTMLCanvasElement.cpp', u'Source/WebCore/html/HTMLElement.cpp', u'Source/WebCore/html/HTMLFormControlElement.cpp', u'Source/WebCore/html/HTMLInputElement.cpp', u'Source/WebCore/html/HTMLMediaElement.cpp', u'Source/WebCore/html/HTMLOptionElement.cpp', u'Source/WebCore/html/HTMLPlugInImageElement.cpp', u'Source/WebCore/html/HTMLTextFormControlElement.cpp', u'Source/WebCore/html/RangeInputType.cpp', u'Source/WebCore/html/TextFieldInputType.cpp', u'Source/WebCore/html/parser/HTMLResourcePreloader.cpp', u'Source/WebCore/html/shadow/MeterShadowElement.cpp', u'Source/WebCore/html/shadow/ProgressShadowElement.cpp', u'Source/WebCore/html/shadow/SliderThumbElement.cpp', u'Source/WebCore/html/shadow/TextControlInnerElements.cpp', u'Source/WebCore/inspector/InspectorLayerTreeAgent.cpp', u'Source/WebCore/inspector/InspectorOverlay.cpp', u'Source/WebCore/loader/cache/CachedImage.cpp', u'Source/WebCore/page/Chrome.cpp', u'Source/WebCore/page/DragController.cpp', u'Source/WebCore/page/EventHandler.cpp', u'Source/WebCore/page/Frame.cpp', u'Source/WebCore/page/FrameView.cpp', u'Source/WebCore/page/PrintContext.cpp', u'Source/WebCore/page/SpatialNavigation.cpp', u'Source/WebCore/page/animation/AnimationController.cpp', u'Source/WebCore/page/animation/CSSPropertyAnimation.cpp', u'Source/WebCore/page/animation/KeyframeAnimation.cpp', u'Source/WebCore/platform/efl/RenderThemeEfl.cpp', u'Source/WebCore/platform/graphics/mac/ComplexTextController.cpp', u'Source/WebCore/platform/gtk/RenderThemeGtk.cpp', u'Source/WebCore/platform/gtk/RenderThemeGtk2.cpp', u'Source/WebCore/platform/gtk/RenderThemeGtk3.cpp', u'Source/WebCore/platform/mac/HTMLConverter.mm', u'Source/WebCore/rendering/AutoTableLayout.cpp', u'Source/WebCore/rendering/EllipsisBox.cpp', u'Source/WebCore/rendering/FilterEffectRenderer.cpp', u'Source/WebCore/rendering/FixedTableLayout.cpp', u'Source/WebCore/rendering/FloatingObjects.cpp', u'Source/WebCore/rendering/FlowThreadController.cpp', u'Source/WebCore/rendering/HitTestResult.cpp', u'Source/WebCore/rendering/ImageQualityController.cpp', u'Source/WebCore/rendering/InlineBox.cpp', u'Source/WebCore/rendering/InlineBox.h', u'Source/WebCore/rendering/InlineFlowBox.cpp', u'Source/WebCore/rendering/InlineFlowBox.h', u'Source/WebCore/rendering/InlineIterator.h', u'Source/WebCore/rendering/InlineTextBox.cpp', u'Source/WebCore/rendering/InlineTextBox.h', u'Source/WebCore/rendering/LayoutState.cpp', u'Source/WebCore/rendering/LineWidth.cpp', u'Source/WebCore/rendering/LogicalSelectionOffsetCaches.h', u'Source/WebCore/rendering/OrderIterator.cpp', u'Source/WebCore/rendering/RenderBlock.cpp', u'Source/WebCore/rendering/RenderBlock.h', u'Source/WebCore/rendering/RenderBlockFlow.cpp', u'Source/WebCore/rendering/RenderBlockLineLayout.cpp', u'Source/WebCore/rendering/RenderBox.cpp', u'Source/WebCore/rendering/RenderBox.h', u'Source/WebCore/rendering/RenderBoxModelObject.cpp', u'Source/WebCore/rendering/RenderBoxModelObject.h', u'Source/WebCore/rendering/RenderButton.cpp', u'Source/WebCore/rendering/RenderCombineText.cpp', u'Source/WebCore/rendering/RenderCombineText.h', u'Source/WebCore/rendering/RenderCounter.cpp', u'Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp', u'Source/WebCore/rendering/RenderDeprecatedFlexibleBox.h', u'Source/WebCore/rendering/RenderDetailsMarker.cpp', u'Source/WebCore/rendering/RenderElement.cpp', u'Source/WebCore/rendering/RenderElement.h', u'Source/WebCore/rendering/RenderEmbeddedObject.cpp', u'Source/WebCore/rendering/RenderFieldset.cpp', u'Source/WebCore/rendering/RenderFileUploadControl.cpp', u'Source/WebCore/rendering/RenderFlexibleBox.cpp', u'Source/WebCore/rendering/RenderFlowThread.cpp', u'Source/WebCore/rendering/RenderFrameSet.cpp', u'Source/WebCore/rendering/RenderFullScreen.cpp', u'Source/WebCore/rendering/RenderGeometryMap.cpp', u'Source/WebCore/rendering/RenderGrid.cpp', u'Source/WebCore/rendering/RenderHTMLCanvas.cpp', u'Source/WebCore/rendering/RenderIFrame.cpp', u'Source/WebCore/rendering/RenderImage.cpp', u'Source/WebCore/rendering/RenderImageResource.cpp', u'Source/WebCore/rendering/RenderImageResourceStyleImage.cpp', u'Source/WebCore/rendering/RenderInline.cpp', u'Source/WebCore/rendering/RenderInputSpeech.cpp', u'Source/WebCore/rendering/RenderLayer.cpp', u'Source/WebCore/rendering/RenderLayer.h', u'Source/WebCore/rendering/RenderLayerBacking.cpp', u'Source/WebCore/rendering/RenderLayerCompositor.cpp', u'Source/WebCore/rendering/RenderLayerModelObject.cpp', u'Source/WebCore/rendering/RenderLineBoxList.cpp', u'Source/WebCore/rendering/RenderLineBreak.cpp', u'Source/WebCore/rendering/RenderListBox.cpp', u'Source/WebCore/rendering/RenderListItem.cpp', u'Source/WebCore/rendering/RenderListMarker.cpp', u'Source/WebCore/rendering/RenderMarquee.cpp', u'Source/WebCore/rendering/RenderMedia.cpp', u'Source/WebCore/rendering/RenderMediaControlElements.cpp', u'Source/WebCore/rendering/RenderMediaControls.cpp', u'Source/WebCore/rendering/RenderMenuList.cpp', u'Source/WebCore/rendering/RenderMultiColumnBlock.cpp', u'Source/WebCore/rendering/RenderMultiColumnBlock.h', u'Source/WebCore/rendering/RenderMultiColumnFlowThread.cpp', u'Source/WebCore/rendering/RenderMultiColumnSet.cpp', u'Source/WebCore/rendering/RenderNamedFlowFragment.cpp', u'Source/WebCore/rendering/RenderNamedFlowThread.cpp', u'Source/WebCore/rendering/RenderObject.cpp', u'Source/WebCore/rendering/RenderObject.h', u'Source/WebCore/rendering/RenderProgress.cpp', u'Source/WebCore/rendering/RenderQuote.cpp', u'Source/WebCore/rendering/RenderRegion.cpp', u'Source/WebCore/rendering/RenderReplaced.cpp', u'Source/WebCore/rendering/RenderRuby.cpp', u'Source/WebCore/rendering/RenderRubyRun.cpp', u'Source/WebCore/rendering/RenderRubyText.cpp', u'Source/WebCore/rendering/RenderScrollbar.cpp', u'Source/WebCore/rendering/RenderScrollbarPart.cpp', u'Source/WebCore/rendering/RenderSearchField.cpp', u'Source/WebCore/rendering/RenderSlider.cpp', u'Source/WebCore/rendering/RenderSnapshottedPlugIn.cpp', u'Source/WebCore/rendering/RenderTable.cpp', u'Source/WebCore/rendering/RenderTable.h', u'Source/WebCore/rendering/RenderTableCell.cpp', u'Source/WebCore/rendering/RenderTableCell.h', u'Source/WebCore/rendering/RenderTableCol.cpp', u'Source/WebCore/rendering/RenderTableCol.h', u'Source/WebCore/rendering/RenderTableRow.cpp', u'Source/WebCore/rendering/RenderTableRow.h', u'Source/WebCore/rendering/RenderTableSection.cpp', u'Source/WebCore/rendering/RenderTableSection.h', u'Source/WebCore/rendering/RenderText.cpp', u'Source/WebCore/rendering/RenderText.h', u'Source/WebCore/rendering/RenderTextControl.cpp', u'Source/WebCore/rendering/RenderTextControlMultiLine.cpp', u'Source/WebCore/rendering/RenderTextControlSingleLine.cpp', u'Source/WebCore/rendering/RenderTextFragment.cpp', u'Source/WebCore/rendering/RenderTextLineBoxes.cpp', u'Source/WebCore/rendering/RenderTextTrackCue.cpp', u'Source/WebCore/rendering/RenderTheme.cpp', u'Source/WebCore/rendering/RenderThemeMac.mm', u'Source/WebCore/rendering/RenderThemeSafari.cpp', u'Source/WebCore/rendering/RenderThemeWin.cpp', u'Source/WebCore/rendering/RenderThemeWinCE.cpp', u'Source/WebCore/rendering/RenderTreeAsText.cpp', u'Source/WebCore/rendering/RenderVideo.cpp', u'Source/WebCore/rendering/RenderView.cpp', u'Source/WebCore/rendering/RenderView.h', u'Source/WebCore/rendering/RenderWidget.cpp', u'Source/WebCore/rendering/RootInlineBox.cpp', u'Source/WebCore/rendering/SimpleLineLayout.cpp', u'Source/WebCore/rendering/SimpleLineLayoutFunctions.cpp', u'Source/WebCore/rendering/SimpleLineLayoutResolver.h', u'Source/WebCore/rendering/mathml/RenderMathMLBlock.cpp', u'Source/WebCore/rendering/mathml/RenderMathMLFenced.cpp', u'Source/WebCore/rendering/mathml/RenderMathMLFraction.cpp', u'Source/WebCore/rendering/mathml/RenderMathMLOperator.cpp', u'Source/WebCore/rendering/mathml/RenderMathMLRoot.cpp', u'Source/WebCore/rendering/mathml/RenderMathMLRow.cpp', u'Source/WebCore/rendering/mathml/RenderMathMLScripts.cpp', u'Source/WebCore/rendering/mathml/RenderMathMLSpace.cpp', u'Source/WebCore/rendering/shapes/ShapeInfo.cpp', u'Source/WebCore/rendering/shapes/ShapeInfo.h', u'Source/WebCore/rendering/shapes/ShapeInsideInfo.cpp', u'Source/WebCore/rendering/shapes/ShapeOutsideInfo.cpp', u'Source/WebCore/rendering/svg/RenderSVGBlock.cpp', u'Source/WebCore/rendering/svg/RenderSVGContainer.cpp', u'Source/WebCore/rendering/svg/RenderSVGEllipse.cpp', u'Source/WebCore/rendering/svg/RenderSVGImage.cpp', u'Source/WebCore/rendering/svg/RenderSVGInline.cpp', u'Source/WebCore/rendering/svg/RenderSVGInlineText.cpp', u'Source/WebCore/rendering/svg/RenderSVGModelObject.cpp', u'Source/WebCore/rendering/svg/RenderSVGPath.cpp', u'Source/WebCore/rendering/svg/RenderSVGRect.cpp', u'Source/WebCore/rendering/svg/RenderSVGResource.cpp', u'Source/WebCore/rendering/svg/RenderSVGResourceClipper.cpp', u'Source/WebCore/rendering/svg/RenderSVGResourceContainer.cpp', u'Source/WebCore/rendering/svg/RenderSVGResourceFilter.cpp', u'Source/WebCore/rendering/svg/RenderSVGResourceFilterPrimitive.cpp', u'Source/WebCore/rendering/svg/RenderSVGResourceMasker.cpp', u'Source/WebCore/rendering/svg/RenderSVGRoot.cpp', u'Source/WebCore/rendering/svg/RenderSVGShape.cpp', u'Source/WebCore/rendering/svg/RenderSVGShape.h', u'Source/WebCore/rendering/svg/RenderSVGText.cpp', u'Source/WebCore/rendering/svg/SVGInlineFlowBox.cpp', u'Source/WebCore/rendering/svg/SVGInlineTextBox.cpp', u'Source/WebCore/rendering/svg/SVGRenderSupport.cpp', u'Source/WebCore/rendering/svg/SVGRenderTreeAsText.cpp', u'Source/WebCore/rendering/svg/SVGRenderingContext.cpp', u'Source/WebCore/rendering/svg/SVGTextChunkBuilder.cpp', u'Source/WebCore/rendering/svg/SVGTextLayoutAttributesBuilder.cpp', u'Source/WebCore/rendering/svg/SVGTextLayoutEngine.cpp', u'Source/WebCore/rendering/svg/SVGTextLayoutEngineBaseline.cpp', u'Source/WebCore/rendering/svg/SVGTextMetrics.cpp', u'Source/WebCore/rendering/svg/SVGTextMetricsBuilder.cpp', u'Source/WebCore/rendering/svg/SVGTextQuery.cpp', u'Source/WebCore/rendering/svg/SVGTextRunRenderingContext.cpp', u'Source/WebCore/style/StyleResolveForDocument.cpp', u'Source/WebCore/style/StyleResolveTree.cpp', u'Source/WebCore/svg/SVGAnimatedColor.cpp', u'Source/WebCore/svg/SVGElement.cpp', u'Source/WebCore/svg/SVGFEDiffuseLightingElement.cpp', u'Source/WebCore/svg/SVGFEDropShadowElement.cpp', u'Source/WebCore/svg/SVGFEFloodElement.cpp', u'Source/WebCore/svg/SVGFESpecularLightingElement.cpp', u'Source/WebCore/svg/SVGFontData.cpp', u'Source/WebCore/svg/SVGGraphicsElement.cpp', u'Source/WebCore/svg/SVGLengthContext.cpp', u'Source/WebCore/svg/SVGSVGElement.cpp', u'Source/WebCore/svg/SVGStopElement.cpp', u'Source/WebCore/svg/SVGTextElement.cpp', u'Source/WebCore/svg/graphics/SVGImage.cpp', u'Source/WebKit/mac/WebView/WebFrame.mm', u'Source/WebKit/mac/WebView/WebFrameView.mm', u'Source/WebKit/mac/WebView/WebHTMLRepresentation.mm', u'Source/WebKit/mac/WebView/WebHTMLView.mm', u'Source/WebKit/win/DOMCoreClasses.cpp', u'Source/WebKit2/WebProcess/WebPage/TapHighlightController.cpp', u'Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm']" exit_code: 1
Source/WebCore/rendering/RenderListMarker.cpp:1659:  Else clause should never be on same line as else (use 2 lines)  [whitespace/newline] [4]
Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp:102:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp:364:  Omit int when using unsigned  [runtime/unsigned] [1]
Source/WebCore/rendering/RenderBox.cpp:1512:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/rendering/RenderBox.cpp:2476:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Source/WebCore/rendering/RenderBox.cpp:4588:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Source/WebCore/rendering/RenderBox.cpp:4595:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Source/WebCore/dom/Position.cpp:983:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/platform/gtk/RenderThemeGtk.cpp:338:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Source/WebCore/platform/gtk/RenderThemeGtk.cpp:357:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Source/WebCore/platform/gtk/RenderThemeGtk.cpp:385:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Source/WebCore/rendering/RenderLayer.cpp:1337:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/rendering/RenderThemeSafari.cpp:813:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/rendering/RenderThemeSafari.cpp:814:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/rendering/RenderThemeSafari.cpp:815:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/editing/DeleteSelectionCommand.cpp:585:  Missing spaces around |  [whitespace/operators] [3]
Source/WebCore/rendering/RenderBlock.cpp:4086:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/rendering/RenderBlock.cpp:4089:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/rendering/InlineBox.cpp:370:  An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
Source/WebCore/rendering/RenderThemeWin.cpp:688:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/rendering/RenderThemeWin.cpp:689:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/rendering/RenderThemeWin.cpp:689:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Total errors found: 22 in 259 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 17 Andreas Kling 2013-10-28 17:58:46 PDT
Created attachment 215354 [details]
It's happening!
Comment 18 WebKit Commit Bot 2013-10-28 18:02:02 PDT
Attachment 215354 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/accessibility/AccessibilityMediaControls.cpp', u'Source/WebCore/accessibility/AccessibilityObject.cpp', u'Source/WebCore/accessibility/AccessibilityRenderObject.cpp', u'Source/WebCore/accessibility/AccessibilitySlider.cpp', u'Source/WebCore/accessibility/AccessibilityTable.cpp', u'Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceText.cpp', u'Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm', u'Source/WebCore/bindings/objc/DOM.mm', u'Source/WebCore/css/CSSComputedStyleDeclaration.cpp', u'Source/WebCore/css/CSSGradientValue.cpp', u'Source/WebCore/css/CSSGradientValue.h', u'Source/WebCore/css/StyleResolver.cpp', u'Source/WebCore/dom/Document.cpp', u'Source/WebCore/dom/Element.cpp', u'Source/WebCore/dom/Node.cpp', u'Source/WebCore/dom/NodeRenderStyle.h', u'Source/WebCore/dom/Position.cpp', u'Source/WebCore/dom/PositionIterator.cpp', u'Source/WebCore/dom/PseudoElement.cpp', u'Source/WebCore/dom/Range.cpp', u'Source/WebCore/editing/ApplyBlockElementCommand.cpp', u'Source/WebCore/editing/ApplyStyleCommand.cpp', u'Source/WebCore/editing/CompositeEditCommand.cpp', u'Source/WebCore/editing/DeleteButtonController.cpp', u'Source/WebCore/editing/DeleteSelectionCommand.cpp', u'Source/WebCore/editing/Editor.cpp', u'Source/WebCore/editing/EditorCommand.cpp', u'Source/WebCore/editing/FrameSelection.cpp', u'Source/WebCore/editing/HTMLInterchange.cpp', u'Source/WebCore/editing/InsertLineBreakCommand.cpp', u'Source/WebCore/editing/InsertParagraphSeparatorCommand.cpp', u'Source/WebCore/editing/ReplaceSelectionCommand.cpp', u'Source/WebCore/editing/TextIterator.cpp', u'Source/WebCore/editing/VisibleUnits.cpp', u'Source/WebCore/editing/htmlediting.cpp', u'Source/WebCore/editing/ios/EditorIOS.mm', u'Source/WebCore/editing/mac/EditorMac.mm', u'Source/WebCore/editing/markup.cpp', u'Source/WebCore/html/HTMLAppletElement.cpp', u'Source/WebCore/html/HTMLAreaElement.cpp', u'Source/WebCore/html/HTMLCanvasElement.cpp', u'Source/WebCore/html/HTMLElement.cpp', u'Source/WebCore/html/HTMLFormControlElement.cpp', u'Source/WebCore/html/HTMLInputElement.cpp', u'Source/WebCore/html/HTMLMediaElement.cpp', u'Source/WebCore/html/HTMLOptionElement.cpp', u'Source/WebCore/html/HTMLPlugInImageElement.cpp', u'Source/WebCore/html/HTMLTextFormControlElement.cpp', u'Source/WebCore/html/RangeInputType.cpp', u'Source/WebCore/html/TextFieldInputType.cpp', u'Source/WebCore/html/parser/HTMLResourcePreloader.cpp', u'Source/WebCore/html/shadow/MeterShadowElement.cpp', u'Source/WebCore/html/shadow/ProgressShadowElement.cpp', u'Source/WebCore/html/shadow/SliderThumbElement.cpp', u'Source/WebCore/html/shadow/TextControlInnerElements.cpp', u'Source/WebCore/inspector/InspectorLayerTreeAgent.cpp', u'Source/WebCore/inspector/InspectorOverlay.cpp', u'Source/WebCore/loader/cache/CachedImage.cpp', u'Source/WebCore/page/Chrome.cpp', u'Source/WebCore/page/DragController.cpp', u'Source/WebCore/page/EventHandler.cpp', u'Source/WebCore/page/Frame.cpp', u'Source/WebCore/page/FrameView.cpp', u'Source/WebCore/page/PrintContext.cpp', u'Source/WebCore/page/SpatialNavigation.cpp', u'Source/WebCore/page/animation/AnimationController.cpp', u'Source/WebCore/page/animation/CSSPropertyAnimation.cpp', u'Source/WebCore/page/animation/KeyframeAnimation.cpp', u'Source/WebCore/platform/efl/RenderThemeEfl.cpp', u'Source/WebCore/platform/graphics/mac/ComplexTextController.cpp', u'Source/WebCore/platform/gtk/RenderThemeGtk.cpp', u'Source/WebCore/platform/gtk/RenderThemeGtk2.cpp', u'Source/WebCore/platform/gtk/RenderThemeGtk3.cpp', u'Source/WebCore/platform/mac/HTMLConverter.mm', u'Source/WebCore/rendering/AutoTableLayout.cpp', u'Source/WebCore/rendering/EllipsisBox.cpp', u'Source/WebCore/rendering/FilterEffectRenderer.cpp', u'Source/WebCore/rendering/FixedTableLayout.cpp', u'Source/WebCore/rendering/FloatingObjects.cpp', u'Source/WebCore/rendering/FlowThreadController.cpp', u'Source/WebCore/rendering/HitTestResult.cpp', u'Source/WebCore/rendering/ImageQualityController.cpp', u'Source/WebCore/rendering/InlineBox.cpp', u'Source/WebCore/rendering/InlineBox.h', u'Source/WebCore/rendering/InlineFlowBox.cpp', u'Source/WebCore/rendering/InlineFlowBox.h', u'Source/WebCore/rendering/InlineIterator.h', u'Source/WebCore/rendering/InlineTextBox.cpp', u'Source/WebCore/rendering/InlineTextBox.h', u'Source/WebCore/rendering/LayoutState.cpp', u'Source/WebCore/rendering/LineWidth.cpp', u'Source/WebCore/rendering/LogicalSelectionOffsetCaches.h', u'Source/WebCore/rendering/OrderIterator.cpp', u'Source/WebCore/rendering/RenderBlock.cpp', u'Source/WebCore/rendering/RenderBlock.h', u'Source/WebCore/rendering/RenderBlockFlow.cpp', u'Source/WebCore/rendering/RenderBlockLineLayout.cpp', u'Source/WebCore/rendering/RenderBox.cpp', u'Source/WebCore/rendering/RenderBox.h', u'Source/WebCore/rendering/RenderBoxModelObject.cpp', u'Source/WebCore/rendering/RenderBoxModelObject.h', u'Source/WebCore/rendering/RenderButton.cpp', u'Source/WebCore/rendering/RenderCombineText.cpp', u'Source/WebCore/rendering/RenderCombineText.h', u'Source/WebCore/rendering/RenderCounter.cpp', u'Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp', u'Source/WebCore/rendering/RenderDeprecatedFlexibleBox.h', u'Source/WebCore/rendering/RenderDetailsMarker.cpp', u'Source/WebCore/rendering/RenderElement.cpp', u'Source/WebCore/rendering/RenderElement.h', u'Source/WebCore/rendering/RenderEmbeddedObject.cpp', u'Source/WebCore/rendering/RenderFieldset.cpp', u'Source/WebCore/rendering/RenderFileUploadControl.cpp', u'Source/WebCore/rendering/RenderFlexibleBox.cpp', u'Source/WebCore/rendering/RenderFlowThread.cpp', u'Source/WebCore/rendering/RenderFrameSet.cpp', u'Source/WebCore/rendering/RenderFullScreen.cpp', u'Source/WebCore/rendering/RenderGeometryMap.cpp', u'Source/WebCore/rendering/RenderGrid.cpp', u'Source/WebCore/rendering/RenderHTMLCanvas.cpp', u'Source/WebCore/rendering/RenderIFrame.cpp', u'Source/WebCore/rendering/RenderImage.cpp', u'Source/WebCore/rendering/RenderImageResource.cpp', u'Source/WebCore/rendering/RenderImageResourceStyleImage.cpp', u'Source/WebCore/rendering/RenderInline.cpp', u'Source/WebCore/rendering/RenderInputSpeech.cpp', u'Source/WebCore/rendering/RenderLayer.cpp', u'Source/WebCore/rendering/RenderLayer.h', u'Source/WebCore/rendering/RenderLayerBacking.cpp', u'Source/WebCore/rendering/RenderLayerCompositor.cpp', u'Source/WebCore/rendering/RenderLayerModelObject.cpp', u'Source/WebCore/rendering/RenderLineBoxList.cpp', u'Source/WebCore/rendering/RenderLineBreak.cpp', u'Source/WebCore/rendering/RenderListBox.cpp', u'Source/WebCore/rendering/RenderListItem.cpp', u'Source/WebCore/rendering/RenderListMarker.cpp', u'Source/WebCore/rendering/RenderMarquee.cpp', u'Source/WebCore/rendering/RenderMedia.cpp', u'Source/WebCore/rendering/RenderMediaControlElements.cpp', u'Source/WebCore/rendering/RenderMediaControls.cpp', u'Source/WebCore/rendering/RenderMenuList.cpp', u'Source/WebCore/rendering/RenderMultiColumnBlock.cpp', u'Source/WebCore/rendering/RenderMultiColumnBlock.h', u'Source/WebCore/rendering/RenderMultiColumnFlowThread.cpp', u'Source/WebCore/rendering/RenderMultiColumnSet.cpp', u'Source/WebCore/rendering/RenderNamedFlowFragment.cpp', u'Source/WebCore/rendering/RenderNamedFlowThread.cpp', u'Source/WebCore/rendering/RenderObject.cpp', u'Source/WebCore/rendering/RenderObject.h', u'Source/WebCore/rendering/RenderProgress.cpp', u'Source/WebCore/rendering/RenderQuote.cpp', u'Source/WebCore/rendering/RenderRegion.cpp', u'Source/WebCore/rendering/RenderReplaced.cpp', u'Source/WebCore/rendering/RenderRuby.cpp', u'Source/WebCore/rendering/RenderRubyRun.cpp', u'Source/WebCore/rendering/RenderRubyText.cpp', u'Source/WebCore/rendering/RenderScrollbar.cpp', u'Source/WebCore/rendering/RenderScrollbarPart.cpp', u'Source/WebCore/rendering/RenderSearchField.cpp', u'Source/WebCore/rendering/RenderSlider.cpp', u'Source/WebCore/rendering/RenderSnapshottedPlugIn.cpp', u'Source/WebCore/rendering/RenderTable.cpp', u'Source/WebCore/rendering/RenderTable.h', u'Source/WebCore/rendering/RenderTableCell.cpp', u'Source/WebCore/rendering/RenderTableCell.h', u'Source/WebCore/rendering/RenderTableCol.cpp', u'Source/WebCore/rendering/RenderTableCol.h', u'Source/WebCore/rendering/RenderTableRow.cpp', u'Source/WebCore/rendering/RenderTableRow.h', u'Source/WebCore/rendering/RenderTableSection.cpp', u'Source/WebCore/rendering/RenderTableSection.h', u'Source/WebCore/rendering/RenderText.cpp', u'Source/WebCore/rendering/RenderText.h', u'Source/WebCore/rendering/RenderTextControl.cpp', u'Source/WebCore/rendering/RenderTextControlMultiLine.cpp', u'Source/WebCore/rendering/RenderTextControlSingleLine.cpp', u'Source/WebCore/rendering/RenderTextFragment.cpp', u'Source/WebCore/rendering/RenderTextLineBoxes.cpp', u'Source/WebCore/rendering/RenderTextTrackCue.cpp', u'Source/WebCore/rendering/RenderTheme.cpp', u'Source/WebCore/rendering/RenderThemeMac.mm', u'Source/WebCore/rendering/RenderThemeSafari.cpp', u'Source/WebCore/rendering/RenderThemeWin.cpp', u'Source/WebCore/rendering/RenderThemeWinCE.cpp', u'Source/WebCore/rendering/RenderTreeAsText.cpp', u'Source/WebCore/rendering/RenderVideo.cpp', u'Source/WebCore/rendering/RenderView.cpp', u'Source/WebCore/rendering/RenderView.h', u'Source/WebCore/rendering/RenderWidget.cpp', u'Source/WebCore/rendering/RootInlineBox.cpp', u'Source/WebCore/rendering/SimpleLineLayout.cpp', u'Source/WebCore/rendering/SimpleLineLayoutFunctions.cpp', u'Source/WebCore/rendering/SimpleLineLayoutResolver.h', u'Source/WebCore/rendering/mathml/RenderMathMLBlock.cpp', u'Source/WebCore/rendering/mathml/RenderMathMLFenced.cpp', u'Source/WebCore/rendering/mathml/RenderMathMLFraction.cpp', u'Source/WebCore/rendering/mathml/RenderMathMLOperator.cpp', u'Source/WebCore/rendering/mathml/RenderMathMLRoot.cpp', u'Source/WebCore/rendering/mathml/RenderMathMLRow.cpp', u'Source/WebCore/rendering/mathml/RenderMathMLScripts.cpp', u'Source/WebCore/rendering/mathml/RenderMathMLSpace.cpp', u'Source/WebCore/rendering/shapes/ShapeInfo.cpp', u'Source/WebCore/rendering/shapes/ShapeInfo.h', u'Source/WebCore/rendering/shapes/ShapeInsideInfo.cpp', u'Source/WebCore/rendering/shapes/ShapeOutsideInfo.cpp', u'Source/WebCore/rendering/svg/RenderSVGBlock.cpp', u'Source/WebCore/rendering/svg/RenderSVGContainer.cpp', u'Source/WebCore/rendering/svg/RenderSVGEllipse.cpp', u'Source/WebCore/rendering/svg/RenderSVGImage.cpp', u'Source/WebCore/rendering/svg/RenderSVGInline.cpp', u'Source/WebCore/rendering/svg/RenderSVGInlineText.cpp', u'Source/WebCore/rendering/svg/RenderSVGModelObject.cpp', u'Source/WebCore/rendering/svg/RenderSVGPath.cpp', u'Source/WebCore/rendering/svg/RenderSVGRect.cpp', u'Source/WebCore/rendering/svg/RenderSVGResource.cpp', u'Source/WebCore/rendering/svg/RenderSVGResourceClipper.cpp', u'Source/WebCore/rendering/svg/RenderSVGResourceContainer.cpp', u'Source/WebCore/rendering/svg/RenderSVGResourceFilter.cpp', u'Source/WebCore/rendering/svg/RenderSVGResourceFilterPrimitive.cpp', u'Source/WebCore/rendering/svg/RenderSVGResourceMasker.cpp', u'Source/WebCore/rendering/svg/RenderSVGRoot.cpp', u'Source/WebCore/rendering/svg/RenderSVGShape.cpp', u'Source/WebCore/rendering/svg/RenderSVGShape.h', u'Source/WebCore/rendering/svg/RenderSVGText.cpp', u'Source/WebCore/rendering/svg/SVGInlineFlowBox.cpp', u'Source/WebCore/rendering/svg/SVGInlineTextBox.cpp', u'Source/WebCore/rendering/svg/SVGRenderSupport.cpp', u'Source/WebCore/rendering/svg/SVGRenderTreeAsText.cpp', u'Source/WebCore/rendering/svg/SVGRenderingContext.cpp', u'Source/WebCore/rendering/svg/SVGTextChunkBuilder.cpp', u'Source/WebCore/rendering/svg/SVGTextLayoutAttributesBuilder.cpp', u'Source/WebCore/rendering/svg/SVGTextLayoutEngine.cpp', u'Source/WebCore/rendering/svg/SVGTextLayoutEngineBaseline.cpp', u'Source/WebCore/rendering/svg/SVGTextMetrics.cpp', u'Source/WebCore/rendering/svg/SVGTextMetricsBuilder.cpp', u'Source/WebCore/rendering/svg/SVGTextQuery.cpp', u'Source/WebCore/rendering/svg/SVGTextRunRenderingContext.cpp', u'Source/WebCore/style/StyleResolveForDocument.cpp', u'Source/WebCore/style/StyleResolveTree.cpp', u'Source/WebCore/svg/SVGAnimatedColor.cpp', u'Source/WebCore/svg/SVGElement.cpp', u'Source/WebCore/svg/SVGFEDiffuseLightingElement.cpp', u'Source/WebCore/svg/SVGFEDropShadowElement.cpp', u'Source/WebCore/svg/SVGFEFloodElement.cpp', u'Source/WebCore/svg/SVGFESpecularLightingElement.cpp', u'Source/WebCore/svg/SVGFontData.cpp', u'Source/WebCore/svg/SVGGraphicsElement.cpp', u'Source/WebCore/svg/SVGLengthContext.cpp', u'Source/WebCore/svg/SVGSVGElement.cpp', u'Source/WebCore/svg/SVGStopElement.cpp', u'Source/WebCore/svg/SVGTextElement.cpp', u'Source/WebCore/svg/graphics/SVGImage.cpp', u'Source/WebKit/mac/WebView/WebFrame.mm', u'Source/WebKit/mac/WebView/WebFrameView.mm', u'Source/WebKit/mac/WebView/WebHTMLRepresentation.mm', u'Source/WebKit/mac/WebView/WebHTMLView.mm', u'Source/WebKit/win/DOMCoreClasses.cpp', u'Source/WebKit2/WebProcess/WebPage/TapHighlightController.cpp', u'Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm']" exit_code: 1
Source/WebCore/rendering/RenderListMarker.cpp:1659:  Else clause should never be on same line as else (use 2 lines)  [whitespace/newline] [4]
Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp:102:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp:364:  Omit int when using unsigned  [runtime/unsigned] [1]
Source/WebCore/rendering/RenderBox.cpp:1512:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/rendering/RenderBox.cpp:2476:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Source/WebCore/rendering/RenderBox.cpp:4588:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Source/WebCore/rendering/RenderBox.cpp:4595:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Source/WebCore/dom/Position.cpp:983:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/platform/gtk/RenderThemeGtk.cpp:338:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Source/WebCore/platform/gtk/RenderThemeGtk.cpp:357:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Source/WebCore/platform/gtk/RenderThemeGtk.cpp:385:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Source/WebCore/rendering/RenderLayer.cpp:1337:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/rendering/RenderThemeSafari.cpp:813:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/rendering/RenderThemeSafari.cpp:814:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/rendering/RenderThemeSafari.cpp:815:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/editing/DeleteSelectionCommand.cpp:585:  Missing spaces around |  [whitespace/operators] [3]
Source/WebCore/rendering/RenderBlock.cpp:4086:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/rendering/RenderBlock.cpp:4089:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/rendering/InlineBox.cpp:370:  An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
Source/WebCore/rendering/RenderThemeWin.cpp:688:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/rendering/RenderThemeWin.cpp:689:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/rendering/RenderThemeWin.cpp:689:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Total errors found: 22 in 260 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 19 Anders Carlsson 2013-10-28 19:17:27 PDT
Comment on attachment 215354 [details]
It's happening!

View in context: https://bugs.webkit.org/attachment.cgi?id=215354&action=review

>> Source/WebCore/editing/DeleteSelectionCommand.cpp:585
>> +        ASSERT(!textNode->renderer() ||textNode->renderer()->style().collapseWhiteSpace());
> 
> Missing spaces around |  [whitespace/operators] [3]

Please fix.

>> Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp:364
>> +            unsigned int flexGroup = child->style().boxFlexGroup();
> 
> Omit int when using unsigned  [runtime/unsigned] [1]

Yes, omit int please.
Comment 20 Andreas Kling 2013-10-28 19:57:11 PDT
Committed r158163: <http://trac.webkit.org/changeset/158163>