RESOLVED FIXED 123411
Upstream remaining PLATFORM(IOS) and ENABLE(REMOTE_INSPECTOR) pieces 
https://bugs.webkit.org/show_bug.cgi?id=123411
Summary Upstream remaining PLATFORM(IOS) and ENABLE(REMOTE_INSPECTOR) pieces
Joseph Pecoraro
Reported 2013-10-28 11:33:32 PDT
This completes the upstreaming of iOS remote inspector code.
Attachments
[PATCH] Proposed Fix (44.73 KB, patch)
2013-10-28 12:27 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2013-10-28 12:27:02 PDT
Created attachment 215323 [details] [PATCH] Proposed Fix
WebKit Commit Bot
Comment 2 2013-10-28 12:28:26 PDT
Attachment 215323 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/inspector/InspectorClient.h', u'Source/WebCore/inspector/InspectorDOMAgent.cpp', u'Source/WebCore/inspector/InspectorOverlay.cpp', u'Source/WebCore/inspector/InspectorOverlay.h', u'Source/WebKit/ChangeLog', u'Source/WebKit/WebKit.xcodeproj/project.pbxproj', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/WebCoreSupport/WebInspectorClient.h', u'Source/WebKit/mac/WebInspector/WebInspector.h', u'Source/WebKit/mac/WebInspector/WebInspector.mm', u'Source/WebKit/mac/WebInspector/WebNodeHighlight.h', u'Source/WebKit/mac/WebInspector/WebNodeHighlight.mm', u'Source/WebKit/mac/WebInspector/WebNodeHighlightView.h', u'Source/WebKit/mac/WebInspector/WebNodeHighlightView.mm', u'Source/WebKit/mac/WebInspector/WebNodeHighlighter.mm', u'Source/WebKit/mac/WebView/WebIndicateLayer.h', u'Source/WebKit/mac/WebView/WebIndicateLayer.mm', u'Source/WebKit/mac/WebView/WebView.mm', u'Source/WebKit/mac/WebView/WebViewData.h', u'Source/WebKit/mac/WebView/WebViewData.mm']" exit_code: 1 Source/WebKit/mac/WebView/WebIndicateLayer.h:33: This { should be at the end of the previous line [whitespace/braces] [4] Total errors found: 1 in 21 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 3 2013-10-28 15:07:06 PDT
Comment on attachment 215323 [details] [PATCH] Proposed Fix Clearing flags on attachment: 215323 Committed r158137: <http://trac.webkit.org/changeset/158137>
WebKit Commit Bot
Comment 4 2013-10-28 15:07:08 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.