Bug 123408 - Clean up ScopedEventQueue
Summary: Clean up ScopedEventQueue
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-28 09:52 PDT by Zan Dobersek
Modified: 2013-10-29 00:41 PDT (History)
3 users (show)

See Also:

Attachments
Patch (6.19 KB, patch)
2013-10-28 09:59 PDT, Zan Dobersek 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2013-10-28 09:52:49 PDT 
Clean up ScopedEventQueue
Comment 1 Zan Dobersek 2013-10-28 09:59:21 PDT 
Created attachment 215316 [details]
Patch
Comment 2 Darin Adler 2013-10-28 10:08:57 PDT 
Comment on attachment 215316 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=215316&action=review

> Source/WebCore/dom/ScopedEventQueue.cpp:77
> +    Vector<RefPtr<Event>> queuedEvents;
> +    queuedEvents.swap(m_queuedEvents);

We should use move instead of swap here:

    Vector<RefPtr<Event>> queuedEvents = std::move(m_queuedEvents);
Comment 3 Zan Dobersek 2013-10-29 00:41:04 PDT 
Committed r158182: <http://trac.webkit.org/changeset/158182>