Bug 123386 - Make new bug link in flakiness dashboard configurable
Summary: Make new bug link in flakiness dashboard configurable
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Website (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-10-25 23:47 PDT by Ryosuke Niwa
Modified: 2013-10-26 17:47 PDT (History)
6 users (show)

See Also:

Attachments
Makes the new bug link configurable (4.66 KB, patch)
2013-10-25 23:52 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Add the missing ChangeLog (5.87 KB, patch)
2013-10-25 23:55 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2013-10-25 23:47:54 PDT 
It's desirable for new bug link to be configurable so that we can add other bug trackers as needed.

<rdar://problem/15320291>
Comment 1 Ryosuke Niwa 2013-10-25 23:52:53 PDT 
Created attachment 215241 [details]
Makes the new bug link configurable
Comment 2 Ryosuke Niwa 2013-10-25 23:55:40 PDT 
Created attachment 215242 [details]
Add the missing ChangeLog
Comment 3 Alexey Proskuryakov 2013-10-26 16:56:19 PDT 
Comment on attachment 215242 [details]
Add the missing ChangeLog

View in context: https://bugs.webkit.org/attachment.cgi?id=215242&action=review

r=me

> Websites/test-results/public/index.html:310
> +            if (!build.revision(repositories[i].id))
> +                continue;

Is this actually part of this patch?
Comment 4 Ryosuke Niwa 2013-10-26 17:22:05 PDT 
Comment on attachment 215242 [details]
Add the missing ChangeLog

View in context: https://bugs.webkit.org/attachment.cgi?id=215242&action=review

>> Websites/test-results/public/index.html:310
>> +                continue;
> 
> Is this actually part of this patch?

Yes. It's somewhat unrelated but the line beneath was throwing an exception if a build object didn't contain all repository info.
e.g. missing Safari revision.
Comment 5 WebKit Commit Bot 2013-10-26 17:47:10 PDT 
Comment on attachment 215242 [details]
Add the missing ChangeLog

Clearing flags on attachment: 215242

Committed r158095: <http://trac.webkit.org/changeset/158095>
Comment 6 WebKit Commit Bot 2013-10-26 17:47:12 PDT 
All reviewed patches have been landed.  Closing bug.