Bug 123372 - Refactor parser rollback logic
Summary: Refactor parser rollback logic
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Oliver Hunt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-25 16:23 PDT by Oliver Hunt
Modified: 2013-10-25 18:19 PDT (History)
0 users

See Also:

Attachments
Patch (5.88 KB, patch)
2013-10-25 16:24 PDT, Oliver Hunt 		beidson: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2013-10-25 16:23:59 PDT 
Refactor parser rollback logic
Comment 1 Oliver Hunt 2013-10-25 16:24:50 PDT 
Created attachment 215229 [details]
Patch
Comment 2 Oliver Hunt 2013-10-25 17:23:39 PDT 
Committed r158074: <http://trac.webkit.org/changeset/158074>
Comment 3 Geoffrey Garen 2013-10-25 17:56:33 PDT 
Comment on attachment 215229 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=215229&action=review

> Source/JavaScriptCore/parser/Parser.cpp:202
> +    auto savePoint = createSavePoint();

In cases like this, I think the code is more self-documenting, and not harder to write, if it says "SavePoint savePoint = ...".
Comment 4 Filip Pizlo 2013-10-25 18:19:07 PDT 
Comment on attachment 215229 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=215229&action=review

R=me too fwiw.

>> Source/JavaScriptCore/parser/Parser.cpp:202
>> +    auto savePoint = createSavePoint();
> 
> In cases like this, I think the code is more self-documenting, and not harder to write, if it says "SavePoint savePoint = ...".

+1

This is one of those situations where types are cool.