Bug 123368 - Web Inspector: Remove a lot of the current Timelines code to make room for a new implementation
Summary: Web Inspector: Remove a lot of the current Timelines code to make room for a ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-10-25 15:56 PDT by Timothy Hatcher
Modified: 2014-01-20 18:59 PST (History)
4 users (show)

See Also:

Attachments
Patch (105.31 KB, patch)
2013-10-25 15:57 PDT, Timothy Hatcher 		joepeck: review+
timothy: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2013-10-25 15:56:10 PDT 
We are redoing how the Timelines sidebar and view work. To do this we need to remove the current version to make it easier to add the new stuff.
Comment 1 Radar WebKit Bug Importer 2013-10-25 15:56:47 PDT 
<rdar://problem/15324355>
Comment 2 Timothy Hatcher 2013-10-25 15:57:27 PDT 
Created attachment 215225 [details]
Patch
Comment 3 Joseph Pecoraro 2013-10-28 10:25:03 PDT 
Comment on attachment 215225 [details]
Patch

rs=me
Comment 4 Joseph Pecoraro 2013-10-28 10:26:27 PDT 
Comment on attachment 215225 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=215225&action=review

> Source/WebInspectorUI/ChangeLog:18
> +        * UserInterface/InstrumentSidebarPanel.js: Removed.

You might also need to remove "Removed" files from vcproj files: (I only care about removals, not new files)

WebInspectorUI.vcxproj/WebInspectorUI.vcxproj
552:    <None Include="..\UserInterface\InstrumentSidebarPanel.js" />

WebInspectorUI.vcxproj/WebInspectorUI.vcxproj.filters
606:    <None Include="..\UserInterface\InstrumentSidebarPanel.js">
Comment 5 Timothy Hatcher 2014-01-20 18:59:34 PST 
https://trac.webkit.org/changeset/162397