Bug 123364 - Web Inspector: Single click on links in non-read-only TextEditors should not follow links
Summary: Web Inspector: Single click on links in non-read-only TextEditors should not ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-10-25 15:11 PDT by Timothy Hatcher
Modified: 2019-04-03 14:04 PDT (History)
4 users (show)

See Also:


Attachments
Patch (5.60 KB, patch)
2019-04-03 13:17 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2013-10-25 15:11:55 PDT
We should make command-click be required for link following in all non-read-only TextEditors.

Note: See SourceCodeTextEditor's tokenTrackingControllerHighlightedRangeWasClicked, TextEditor's _openClickedLinks and CSSStyleDeclarationTextEditor's tokenTrackingControllerHighlightedRangeWasClicked.
Comment 1 Radar WebKit Bug Importer 2013-10-25 15:12:19 PDT
<rdar://problem/15323913>
Comment 2 Devin Rousso 2019-04-03 13:17:32 PDT
Created attachment 366634 [details]
Patch
Comment 3 WebKit Commit Bot 2019-04-03 14:04:03 PDT
Comment on attachment 366634 [details]
Patch

Clearing flags on attachment: 366634

Committed r243826: <https://trac.webkit.org/changeset/243826>
Comment 4 WebKit Commit Bot 2019-04-03 14:04:05 PDT
All reviewed patches have been landed.  Closing bug.