Bug 123356 - Web Inspector: Change how the load and content ready event timestamps are tracked.
Summary: Web Inspector: Change how the load and content ready event timestamps are tra...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-10-25 13:14 PDT by Timothy Hatcher
Modified: 2014-01-20 18:59 PST (History)
4 users (show)

See Also:

Attachments
Patch (7.13 KB, patch)
2013-10-25 13:16 PDT, Timothy Hatcher 		no flags Details | Formatted Diff | Diff
Patch (7.14 KB, patch)
2013-10-25 13:37 PDT, Timothy Hatcher 		joepeck: review+
timothy: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2013-10-25 13:14:46 PDT 
We should track the timestamps per frame. This will be needed by some up coming Timeline changes.
Comment 1 Radar WebKit Bug Importer 2013-10-25 13:14:56 PDT 
<rdar://problem/15322597>
Comment 2 Timothy Hatcher 2013-10-25 13:16:50 PDT 
Created attachment 215202 [details]
Patch
Comment 3 Timothy Hatcher 2013-10-25 13:37:03 PDT 
Created attachment 215207 [details]
Patch
Comment 4 Joseph Pecoraro 2013-10-25 15:33:30 PDT 
Comment on attachment 215207 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=215207&action=review

r=me

> Source/WebInspectorUI/UserInterface/TimelineManager.js:-61
> -        return this._loadEventTime;

You are removing this._loadEventTime, you can remove this instance variable from:

   1. The constructor
   2. _clear
   3. Replace the use in _addRecord to look at the MainFrame

On IRC you've handled these.
Comment 5 Timothy Hatcher 2014-01-20 18:59:49 PST 
https://trac.webkit.org/changeset/162398