Bug 123351 - Merge viewInWindowStateDidChange into viewStateDidChange
Summary: Merge viewInWindowStateDidChange into viewStateDidChange
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-25 11:40 PDT by Gavin Barraclough
Modified: 2013-10-25 12:43 PDT (History)
0 users

See Also:

Attachments
Fix (7.08 KB, patch)
2013-10-25 11:46 PDT, Gavin Barraclough 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2013-10-25 11:40:30 PDT 
We want to unify all these messages.
Comment 1 Gavin Barraclough 2013-10-25 11:46:47 PDT 
Created attachment 215196 [details]
Fix
Comment 2 Tim Horton 2013-10-25 11:52:24 PDT 
Comment on attachment 215196 [details]
Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=215196&action=review

> Source/WebKit2/UIProcess/WebPageProxy.cpp:1032
> +#if ENABLE(INPUT_TYPE_COLOR_POPOVER)
> +        else {
> +            // When leaving the current page, close the popover color well.
> +            if (m_colorPicker)
> +                endColorPicker();
> +        }
> +#endif

oO
Comment 3 Gavin Barraclough 2013-10-25 12:43:25 PDT 
Fixed in r158034