Bug 123344 - Don't invalidate all fonts when a web font is loaded
Summary: Don't invalidate all fonts when a web font is loaded
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-25 08:24 PDT by Antti Koivisto
Modified: 2013-10-25 10:59 PDT (History)
10 users (show)

See Also:

Attachments
for bots (8.00 KB, patch)
2013-10-25 08:25 PDT, Antti Koivisto 		buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2 (489.59 KB, application/zip)
2013-10-25 09:23 PDT, Build Bot 		no flags Details
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion (523.52 KB, application/zip)
2013-10-25 09:43 PDT, Build Bot 		no flags Details
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion (527.22 KB, application/zip)
2013-10-25 10:51 PDT, Build Bot 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2013-10-25 08:24:36 PDT 
This generates unnecessary work
Comment 1 Antti Koivisto 2013-10-25 08:25:15 PDT 
Created attachment 215177 [details]
for bots
Comment 2 WebKit Commit Bot 2013-10-25 08:26:46 PDT 
Attachment 215177 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/css/CSSFontSelector.cpp', u'Source/WebCore/css/CSSFontSelector.h', u'Source/WebCore/platform/graphics/Font.cpp', u'Source/WebCore/platform/graphics/FontGlyphs.cpp', u'Source/WebCore/platform/graphics/FontGlyphs.h', u'Source/WebCore/platform/graphics/FontSelector.h', u'Source/WebCore/rendering/RenderText.cpp']" exit_code: 1
Source/WebCore/platform/graphics/Font.cpp:165:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Build Bot 2013-10-25 09:22:58 PDT 
Comment on attachment 215177 [details]
for bots

Attachment 215177 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/12448008

New failing tests:
fast/css/font-face-multiple-remote-sources.html
Comment 4 Build Bot 2013-10-25 09:23:00 PDT 
Created attachment 215181 [details]
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-09  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 5 Build Bot 2013-10-25 09:43:33 PDT 
Comment on attachment 215177 [details]
for bots

Attachment 215177 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/10348272

New failing tests:
fast/css/font-face-multiple-remote-sources.html
Comment 6 Build Bot 2013-10-25 09:43:36 PDT 
Created attachment 215185 [details]
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-05  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 7 Build Bot 2013-10-25 10:51:32 PDT 
Comment on attachment 215177 [details]
for bots

Attachment 215177 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/11898088

New failing tests:
fast/css/font-face-multiple-remote-sources.html
Comment 8 Build Bot 2013-10-25 10:51:35 PDT 
Created attachment 215191 [details]
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-07  Port: mac-mountainlion  Platform: Mac OS X 10.8.5