Bug 123341 – Improve JSC Parser error messages

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Oliver Hunt]

Improve JSC Parser error messages

[Oliver Hunt]

Created attachment 215175 [details]
Patch

[EFL EWS Bot]

Comment on attachment 215175 [details]
Patch

Attachment 215175 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/12348042

[EFL EWS Bot]

Comment on attachment 215175 [details]
Patch

Attachment 215175 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/10898092

[Build Bot]

Comment on attachment 215175 [details]
Patch

Attachment 215175 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/12228067

[Build Bot]

Comment on attachment 215175 [details]
Patch

Attachment 215175 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/12438006

New failing tests:
http/tests/workers/worker-importScripts.html
http/tests/workers/shared-worker-importScripts.html
fast/regex/dom/non-pattern-characters.html

[Build Bot]

Created attachment 215179 [details]
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-12  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Oliver Hunt]

Created attachment 215180 [details]
Patch

[EFL EWS Bot]

Comment on attachment 215180 [details]
Patch

Attachment 215180 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/12458005

[EFL EWS Bot]

Comment on attachment 215180 [details]
Patch

Attachment 215180 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/12428005

[Oliver Hunt]

Created attachment 215182 [details]
Patch

[EFL EWS Bot]

Comment on attachment 215182 [details]
Patch

Attachment 215182 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/10188007

[EFL EWS Bot]

Comment on attachment 215182 [details]
Patch

Attachment 215182 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/12508005

[Andreas Kling]

Comment on attachment 215182 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=215182&action=review

> LayoutTests/fast/regex/dom/non-pattern-characters-expected.txt:36
> +PASS /\/ threw exception SyntaxError: Unexpected token '/'. Invalid regular expression..

"Invalid regular expression" seems to have two periods (..) at the end, unlike other errors.

[Oliver Hunt]

Created attachment 215184 [details]
Appease efl build

[Andreas Kling]

Comment on attachment 215184 [details]
Appease efl build

View in context: https://bugs.webkit.org/attachment.cgi?id=215184&action=review

r=me, assuming ews digs it.

> Source/JavaScriptCore/parser/Parser.cpp:107
> +    , m_lastFunctionName(0)

nullptr

> Source/JavaScriptCore/parser/Parser.cpp:1045
> +    return 0;

nullptr

> Source/JavaScriptCore/parser/Parser.cpp:1055
> +    m_lastFunctionName = 0;

nullptr

> Source/JavaScriptCore/parser/Parser.cpp:2014
> +    ASSERT_NOT_REACHED();
> +    return "error";

Why not just RELEASE_ASSERT_NOT_REACHED here?

[Oliver Hunt]

Committed r158014: <http://trac.webkit.org/changeset/158014>