Bug 123341 - Improve JSC Parser error messages
Summary: Improve JSC Parser error messages
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Oliver Hunt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-25 07:54 PDT by Oliver Hunt
Modified: 2013-10-25 10:11 PDT (History)
4 users (show)

See Also:

Attachments
Patch (606.23 KB, patch)
2013-10-25 08:01 PDT, Oliver Hunt 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2 (517.12 KB, application/zip)
2013-10-25 08:51 PDT, Build Bot 		no flags Details
Patch (606.29 KB, patch)
2013-10-25 08:52 PDT, Oliver Hunt 		no flags Details | Formatted Diff | Diff
Patch (609.79 KB, patch)
2013-10-25 09:23 PDT, Oliver Hunt 		no flags Details | Formatted Diff | Diff
Appease efl build (609.84 KB, patch)
2013-10-25 09:37 PDT, Oliver Hunt 		kling: review+
Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2013-10-25 07:54:33 PDT 
Improve JSC Parser error messages
Comment 1 Oliver Hunt 2013-10-25 08:01:08 PDT 
Created attachment 215175 [details]
Patch
Comment 2 EFL EWS Bot 2013-10-25 08:06:02 PDT 
Comment on attachment 215175 [details]
Patch

Attachment 215175 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/12348042
Comment 3 EFL EWS Bot 2013-10-25 08:06:38 PDT 
Comment on attachment 215175 [details]
Patch

Attachment 215175 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/10898092
Comment 4 Build Bot 2013-10-25 08:41:11 PDT 
Comment on attachment 215175 [details]
Patch

Attachment 215175 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/12228067
Comment 5 Build Bot 2013-10-25 08:51:35 PDT 
Comment on attachment 215175 [details]
Patch

Attachment 215175 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/12438006

New failing tests:
http/tests/workers/worker-importScripts.html
http/tests/workers/shared-worker-importScripts.html
fast/regex/dom/non-pattern-characters.html
Comment 6 Build Bot 2013-10-25 08:51:37 PDT 
Created attachment 215179 [details]
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-12  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 7 Oliver Hunt 2013-10-25 08:52:33 PDT 
Created attachment 215180 [details]
Patch
Comment 8 EFL EWS Bot 2013-10-25 08:55:39 PDT 
Comment on attachment 215180 [details]
Patch

Attachment 215180 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/12458005
Comment 9 EFL EWS Bot 2013-10-25 09:05:03 PDT 
Comment on attachment 215180 [details]
Patch

Attachment 215180 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/12428005
Comment 10 Oliver Hunt 2013-10-25 09:23:56 PDT 
Created attachment 215182 [details]
Patch
Comment 11 EFL EWS Bot 2013-10-25 09:29:03 PDT 
Comment on attachment 215182 [details]
Patch

Attachment 215182 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/10188007
Comment 12 EFL EWS Bot 2013-10-25 09:29:44 PDT 
Comment on attachment 215182 [details]
Patch

Attachment 215182 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/12508005
Comment 13 Andreas Kling 2013-10-25 09:32:56 PDT 
Comment on attachment 215182 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=215182&action=review

> LayoutTests/fast/regex/dom/non-pattern-characters-expected.txt:36
> +PASS /\/ threw exception SyntaxError: Unexpected token '/'. Invalid regular expression..

"Invalid regular expression" seems to have two periods (..) at the end, unlike other errors.
Comment 14 Oliver Hunt 2013-10-25 09:37:36 PDT 
Created attachment 215184 [details]
Appease efl build
Comment 15 Andreas Kling 2013-10-25 09:45:52 PDT 
Comment on attachment 215184 [details]
Appease efl build

View in context: https://bugs.webkit.org/attachment.cgi?id=215184&action=review

r=me, assuming ews digs it.

> Source/JavaScriptCore/parser/Parser.cpp:107
> +    , m_lastFunctionName(0)

nullptr

> Source/JavaScriptCore/parser/Parser.cpp:1045
> +    return 0;

nullptr

> Source/JavaScriptCore/parser/Parser.cpp:1055
> +    m_lastFunctionName = 0;

nullptr

> Source/JavaScriptCore/parser/Parser.cpp:2014
> +    ASSERT_NOT_REACHED();
> +    return "error";

Why not just RELEASE_ASSERT_NOT_REACHED here?
Comment 16 Oliver Hunt 2013-10-25 10:11:46 PDT 
Committed r158014: <http://trac.webkit.org/changeset/158014>