Bug 123323 – Move ViewStateFlags out of WebPageProxy

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Gavin Barraclough]

WebPageProxy contains an enum and typedef that provide a bitfield of flags describing the visibility of the view containing the page. We're going to want to use this bitfield in a message to the WebProcess, so moving out from the UIProcess to shared code. Creating struct 'ViewState' to scope the enum and typedef. Renamed ViewStateFlags to ViewState::Flags, and removed redundant 'View' from enum entries.

[Gavin Barraclough]

Created attachment 215144 [details]
Fix

[WebKit Commit Bot]

Attachment 215144 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Shared/ViewState.h', u'Source/WebKit2/UIProcess/API/mac/WKView.mm', u'Source/WebKit2/UIProcess/WebPageProxy.cpp', u'Source/WebKit2/UIProcess/WebPageProxy.h', u'Source/WebKit2/WebKit2.xcodeproj/project.pbxproj']" exit_code: 1
Source/WebKit2/UIProcess/WebPageProxy.h:327:  The parameter name "flags" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[EFL EWS Bot]

Comment on attachment 215144 [details]
Fix

Attachment 215144 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/11928069

[Gavin Barraclough]

Fixed in r158026

[Gavin Barraclough]

Ooops, relanded 158027/158028.