Bug 123323 - Move ViewStateFlags out of WebPageProxy
Summary: Move ViewStateFlags out of WebPageProxy
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2013-10-24 23:51 PDT by Gavin Barraclough
Modified: 2013-10-25 11:24 PDT (History)
11 users (show)

See Also:

Fix (15.92 KB, patch)
2013-10-24 23:54 PDT, Gavin Barraclough
sam: review+
eflews.bot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2013-10-24 23:51:34 PDT
WebPageProxy contains an enum and typedef that provide a bitfield of flags describing the visibility of the view containing the page. We're going to want to use this bitfield in a message to the WebProcess, so moving out from the UIProcess to shared code. Creating struct 'ViewState' to scope the enum and typedef. Renamed ViewStateFlags to ViewState::Flags, and removed redundant 'View' from enum entries.
Comment 1 Gavin Barraclough 2013-10-24 23:54:08 PDT
Created attachment 215144 [details]
Comment 2 WebKit Commit Bot 2013-10-24 23:55:34 PDT
Attachment 215144 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Shared/ViewState.h', u'Source/WebKit2/UIProcess/API/mac/WKView.mm', u'Source/WebKit2/UIProcess/WebPageProxy.cpp', u'Source/WebKit2/UIProcess/WebPageProxy.h', u'Source/WebKit2/WebKit2.xcodeproj/project.pbxproj']" exit_code: 1
Source/WebKit2/UIProcess/WebPageProxy.h:327:  The parameter name "flags" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 6 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 EFL EWS Bot 2013-10-25 02:02:44 PDT
Comment on attachment 215144 [details]

Attachment 215144 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/11928069
Comment 4 Gavin Barraclough 2013-10-25 11:18:47 PDT
Fixed in r158026
Comment 5 Gavin Barraclough 2013-10-25 11:24:32 PDT
Ooops, relanded 158027/158028.