Bug 123318 - Move RenderBlock functions only used by RenderBlockFlow to RenderBlockFlow
Summary: Move RenderBlock functions only used by RenderBlockFlow to RenderBlockFlow
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-24 21:32 PDT by Sam Weinig
Modified: 2013-10-28 12:21 PDT (History)
5 users (show)

See Also:

Attachments
Patch 1 (31.59 KB, patch)
2013-10-24 21:34 PDT, Sam Weinig 		hyatt: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2013-10-24 21:32:00 PDT 
Move RenderBlock functions only used by RenderBlockFlow to RenderBlockFlow
Comment 1 Sam Weinig 2013-10-24 21:34:24 PDT 
Created attachment 215141 [details]
Patch 1
Comment 2 WebKit Commit Bot 2013-10-24 21:36:54 PDT 
Attachment 215141 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/rendering/LineLayoutState.h', u'Source/WebCore/rendering/RenderBlock.cpp', u'Source/WebCore/rendering/RenderBlock.h', u'Source/WebCore/rendering/RenderBlockFlow.cpp', u'Source/WebCore/rendering/RenderBlockFlow.h', u'Source/WebCore/rendering/RenderBlockLineLayout.cpp']" exit_code: 1
Source/WebCore/rendering/RenderBlockFlow.cpp:1649:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Dave Hyatt 2013-10-25 11:06:40 PDT 
Comment on attachment 215141 [details]
Patch 1

r=me
Comment 4 Sam Weinig 2013-10-28 12:21:02 PDT 
Committed r158121: <http://trac.webkit.org/changeset/158121>