WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
123318
Move RenderBlock functions only used by RenderBlockFlow to RenderBlockFlow
https://bugs.webkit.org/show_bug.cgi?id=123318
Summary
Move RenderBlock functions only used by RenderBlockFlow to RenderBlockFlow
Sam Weinig
Reported
2013-10-24 21:32:00 PDT
Move RenderBlock functions only used by RenderBlockFlow to RenderBlockFlow
Attachments
Patch 1
(31.59 KB, patch)
2013-10-24 21:34 PDT
,
Sam Weinig
hyatt
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Sam Weinig
Comment 1
2013-10-24 21:34:24 PDT
Created
attachment 215141
[details]
Patch 1
WebKit Commit Bot
Comment 2
2013-10-24 21:36:54 PDT
Attachment 215141
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/rendering/LineLayoutState.h', u'Source/WebCore/rendering/RenderBlock.cpp', u'Source/WebCore/rendering/RenderBlock.h', u'Source/WebCore/rendering/RenderBlockFlow.cpp', u'Source/WebCore/rendering/RenderBlockFlow.h', u'Source/WebCore/rendering/RenderBlockLineLayout.cpp']" exit_code: 1 Source/WebCore/rendering/RenderBlockFlow.cpp:1649: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Dave Hyatt
Comment 3
2013-10-25 11:06:40 PDT
Comment on
attachment 215141
[details]
Patch 1 r=me
Sam Weinig
Comment 4
2013-10-28 12:21:02 PDT
Committed
r158121
: <
http://trac.webkit.org/changeset/158121
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug