Bug 123312 – Fix or disable some deprecation warnings

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Mark Rowe (bdash)]

Fix or disable some deprecation warnings

[Mark Rowe (bdash)]

Created attachment 215136 [details]
Patch

[WebKit Commit Bot]

Attachment 215136 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/Panels/WebAuthenticationPanel.m', u'Source/WebKit/mac/WebView/WebClipView.mm']" exit_code: 1
Source/WebKit/mac/ChangeLog:3:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Darin Adler]

Comment on attachment 215136 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=215136&action=review

> Source/WebKit/mac/WebView/WebClipView.mm:79
>      [self releaseGState];

We should find out if there’s some better way for us to work around the clipping issue.

[Mark Rowe (bdash)]

Comment on attachment 215136 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=215136&action=review

>> Source/WebKit/mac/WebView/WebClipView.mm:79
>>      [self releaseGState];
> 
> We should find out if there’s some better way for us to work around the clipping issue.

A first step would be determining whether it's still a real problem. It's possible that other changes in the past 10 years have removed the need for this workaround. I couldn't see any easy way to test that though.

[WebKit Commit Bot]

Comment on attachment 215136 [details]
Patch

Clearing flags on attachment: 215136

Committed r158036: <http://trac.webkit.org/changeset/158036>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.