Bug 123304 - Result of focus-option-control-on-page.html depends on system preferences
Summary: Result of focus-option-control-on-page.html depends on system preferences
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-24 18:02 PDT by Simon Fraser (smfr)
Modified: 2013-10-29 23:51 PDT (History)
3 users (show)

See Also:

Attachments
proposed fix (8.66 KB, patch)
2013-10-29 22:58 PDT, Alexey Proskuryakov 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2013-10-24 18:02:24 PDT 
focus-option-control-on-page.html depends on your Full Keyboard Access system prefs. Marking it [ Pass Failure ]
Comment 1 Alexey Proskuryakov 2013-10-25 00:25:23 PDT 
This is not as easy as I hoped - this is not a global preference, but one in com.apple.universalaccess domain, so we can't just override it AFAIK.

Will probably need to add SPI to WK1 and WK2 to bypass reading the actual preference.
Comment 2 Alexey Proskuryakov 2013-10-29 22:58:38 PDT 
Created attachment 215474 [details]
proposed fix
Comment 3 WebKit Commit Bot 2013-10-29 23:50:36 PDT 
The commit-queue encountered the following flaky tests while processing attachment 215474 [details]:

media/track/track-text-track-cue-list.html bug 123497 (authors: annacc@chromium.org and eric.carlson@apple.com)
The commit-queue is continuing to process your patch.
Comment 4 WebKit Commit Bot 2013-10-29 23:51:49 PDT 
Comment on attachment 215474 [details]
proposed fix

Clearing flags on attachment: 215474

Committed r158256: <http://trac.webkit.org/changeset/158256>
Comment 5 WebKit Commit Bot 2013-10-29 23:51:51 PDT 
All reviewed patches have been landed.  Closing bug.