Bug 123300 - Simplify window occlusion detection code
Summary: Simplify window occlusion detection code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gavin Barraclough
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-24 16:20 PDT by Gavin Barraclough
Modified: 2013-10-24 17:42 PDT (History)
3 users (show)

See Also:


Attachments
Fix (7.61 KB, patch)
2013-10-24 16:30 PDT, Gavin Barraclough
thorton: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2013-10-24 16:20:17 PDT
Also, add missing viewStateDidChange.
Comment 1 Gavin Barraclough 2013-10-24 16:30:23 PDT
Created attachment 215120 [details]
Fix
Comment 2 Build Bot 2013-10-24 16:54:46 PDT
Comment on attachment 215120 [details]
Fix

Attachment 215120 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/10268189
Comment 3 Tim Horton 2013-10-24 16:55:18 PDT
Comment on attachment 215120 [details]
Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=215120&action=review

> Source/WebKit2/ChangeLog:10
> +        dectection being dynamically toggled). Simpler to just rely of the actual value

s/of/on/
Comment 4 Tim Horton 2013-10-24 16:56:18 PDT
As long as you protect it with a 10.9+ check.
Comment 5 Build Bot 2013-10-24 17:11:55 PDT
Comment on attachment 215120 [details]
Fix

Attachment 215120 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/10398221
Comment 6 Gavin Barraclough 2013-10-24 17:42:16 PDT
Fixed in r157968