Bug 123299 - The GetById->GetByOffset AI-based optimization should actually do things
Summary: The GetById->GetByOffset AI-based optimization should actually do things
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-24 16:10 PDT by Filip Pizlo
Modified: 2013-10-28 10:18 PDT (History)
7 users (show)

See Also:


Attachments
the patch (1.27 KB, patch)
2013-10-24 16:12 PDT, Filip Pizlo
oliver: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2013-10-24 16:10:46 PDT
Somehow or another, we ended up turning this optimization off by making GetByIdStatus not set m_state to Simple.  The result was that we'd return a GetByIdStatus advertising that it has NoInformation, and the abstract interpreter would assume that it can't optimize the GetById.

Lol.
Comment 1 Filip Pizlo 2013-10-24 16:12:54 PDT
Created attachment 215118 [details]
the patch
Comment 2 Filip Pizlo 2013-10-28 10:18:36 PDT
Landed in http://trac.webkit.org/changeset/158114