WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
123299
The GetById->GetByOffset AI-based optimization should actually do things
https://bugs.webkit.org/show_bug.cgi?id=123299
Summary
The GetById->GetByOffset AI-based optimization should actually do things
Filip Pizlo
Reported
2013-10-24 16:10:46 PDT
Somehow or another, we ended up turning this optimization off by making GetByIdStatus not set m_state to Simple. The result was that we'd return a GetByIdStatus advertising that it has NoInformation, and the abstract interpreter would assume that it can't optimize the GetById. Lol.
Attachments
the patch
(1.27 KB, patch)
2013-10-24 16:12 PDT
,
Filip Pizlo
oliver
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Filip Pizlo
Comment 1
2013-10-24 16:12:54 PDT
Created
attachment 215118
[details]
the patch
Filip Pizlo
Comment 2
2013-10-28 10:18:36 PDT
Landed in
http://trac.webkit.org/changeset/158114
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug