RESOLVED FIXED 123294
Uncomplicate some of SVGTextRunRenderingContext. 
https://bugs.webkit.org/show_bug.cgi?id=123294
Summary Uncomplicate some of SVGTextRunRenderingContext.
Andreas Kling
Reported 2013-10-24 15:31:54 PDT
Patch forthcoming.
Attachments
Patch (17.99 KB, patch)
2013-10-24 15:33 PDT, Andreas Kling 		koivisto: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2013-10-24 15:33:24 PDT
Created attachment 215112 [details] Patch
Antti Koivisto
Comment 2 2013-10-24 15:39:59 PDT
Comment on attachment 215112 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=215112&action=review > Source/WebCore/ChangeLog:10 > + - Constructor now takes a RenderObject&. RenderObject :( > Source/WebCore/rendering/svg/SVGTextRunRenderingContext.cpp:56 > -static inline RenderObject* firstParentRendererForNonTextNode(RenderObject* renderer) > +static inline RenderElement& firstParentRendererForNonTextNode(RenderObject& renderer) The name is totally misleading. > Source/WebCore/rendering/svg/SVGTextRunRenderingContext.cpp:59 > + if (renderer.isText()) { > + ASSERT(renderer.parent()); Text renderers always have parent. The assert doesn't add anything.
Andreas Kling
Comment 3 2013-10-24 16:33:50 PDT
Committed r157960: <http://trac.webkit.org/changeset/157960>
Note You need to log in before you can comment on or make changes to this bug.