Bug 123288 - Crash in WebCore::NavigationScheduler::startTimer()
Summary: Crash in WebCore::NavigationScheduler::startTimer()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-10-24 13:23 PDT by Daniel Bates
Modified: 2013-10-24 14:39 PDT (History)
5 users (show)

See Also:


Attachments
Patch and API test (12.92 KB, patch)
2013-10-24 13:27 PDT, Daniel Bates
ap: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2013-10-24 13:23:47 PDT
Currently NavigationScheduler::startTimer() synchronously notifies the client of a scheduled redirect r before notifying the Web Inspector. If a client chooses to cancel r upon receiving this callback then NavigationScheduler::m_redirect will become null and we'll subsequently crash when informing the Web Inspector that r was scheduled. Instead, NavigationScheduler::startTimer() should notify the Web Inspector before it notifies the client of a scheduled redirect.
Comment 1 Daniel Bates 2013-10-24 13:24:50 PDT
<rdar://problem/14055644>
Comment 2 Daniel Bates 2013-10-24 13:27:35 PDT
Created attachment 215100 [details]
Patch and API test
Comment 3 Alexey Proskuryakov 2013-10-24 13:37:09 PDT
Comment on attachment 215100 [details]
Patch and API test

View in context: https://bugs.webkit.org/attachment.cgi?id=215100&action=review

r=me. Please wait for EWS to become green.

> Tools/TestWebKitAPI/Tests/mac/WillPerformClientRedirectToURLCrash.html:4
> +<iframe id="frame" src="about: blank"></iframe>

Maybe "about:blank" to make it less confusing?

> Tools/TestWebKitAPI/Tests/mac/WillPerformClientRedirectToURLCrash.mm:34
> +static NSURL* testURL()

Star is misplaced.
Comment 4 Daniel Bates 2013-10-24 14:39:19 PDT
Committed r157957: <http://trac.webkit.org/changeset/157957>