RESOLVED FIXED 123286
SVG: applyResource() should take a RenderElement&. 
https://bugs.webkit.org/show_bug.cgi?id=123286
Summary SVG: applyResource() should take a RenderElement&.
Andreas Kling
Reported 2013-10-24 12:45:44 PDT
Tightening show goes on.
Attachments
Patch (34.15 KB, patch)
2013-10-24 12:46 PDT, Andreas Kling 		koivisto: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2013-10-24 12:46:39 PDT
Created attachment 215096 [details] Patch
Darin Adler
Comment 2 2013-10-24 12:49:51 PDT
Comment on attachment 215096 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=215096&action=review > Source/WebCore/rendering/svg/SVGTextRunRenderingContext.cpp:58 > -static inline RenderObject* firstParentRendererForNonTextNode(RenderObject* renderer) > +static inline RenderElement* firstParentRendererForNonTextNode(RenderObject* renderer) > { > ASSERT(renderer); ASSERT(renderer) is usually a clue that the argument should be a reference, not a pointer. > Source/WebCore/rendering/svg/SVGTextRunRenderingContext.cpp:197 > + if (activePaintingResource->applyResource(*parentRenderObject, parentRenderObjectStyle, context, resourceMode)) { What guarantees that parentRenderObject won’t be null here?
Andreas Kling
Comment 3 2013-10-25 05:26:42 PDT
Committed r158004: <http://trac.webkit.org/changeset/158004>
Note You need to log in before you can comment on or make changes to this bug.