Bug 123285 - [Mac] Add helper methods to convert CMTime <--> MediaTime
Summary: [Mac] Add helper methods to convert CMTime <--> MediaTime
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-24 12:26 PDT by Jer Noble
Modified: 2013-10-25 00:05 PDT (History)
7 users (show)

See Also:

Attachments
Patch (7.78 KB, patch)
2013-10-24 12:38 PDT, Jer Noble 		eric.carlson: review+
Details | Formatted Diff | Diff
Patch for landing (7.85 KB, patch)
2013-10-24 12:52 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch for landing (13.86 KB, patch)
2013-10-24 14:43 PDT, Jer Noble 		commit-queue: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2013-10-24 12:26:45 PDT 
[Mac] Add helper methods to convert CMTime <--> MediaTime
Comment 1 Jer Noble 2013-10-24 12:38:30 PDT 
Created attachment 215095 [details]
Patch
Comment 2 Jer Noble 2013-10-24 12:52:25 PDT 
Created attachment 215097 [details]
Patch for landing
Comment 3 Jer Noble 2013-10-24 12:55:46 PDT 
Comment on attachment 215097 [details]
Patch for landing

Whoops, need to add new files to the Xcode project.
Comment 4 Build Bot 2013-10-24 13:19:34 PDT 
Comment on attachment 215097 [details]
Patch for landing

Attachment 215097 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/10248167
Comment 5 Build Bot 2013-10-24 13:36:26 PDT 
Comment on attachment 215097 [details]
Patch for landing

Attachment 215097 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/10208171
Comment 6 Jer Noble 2013-10-24 14:43:49 PDT 
Created attachment 215106 [details]
Patch for landing
Comment 7 WebKit Commit Bot 2013-10-24 15:47:29 PDT 
Comment on attachment 215106 [details]
Patch for landing

Rejecting attachment 215106 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 215106, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WTF/ChangeLog contains OOPS!.

Full output: http://webkit-queues.appspot.com/results/10348180
Comment 8 Jer Noble 2013-10-25 00:05:43 PDT 
Committed r157991: <http://trac.webkit.org/changeset/157991>