Bug 123270 - Uninitialized member causes crash when DFG JIT is not enabled.
Summary: Uninitialized member causes crash when DFG JIT is not enabled.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-24 07:14 PDT by peavo
Modified: 2013-10-24 09:05 PDT (History)
3 users (show)

See Also:


Attachments
Patch (1.46 KB, patch)
2013-10-24 07:19 PDT, peavo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description peavo 2013-10-24 07:14:37 PDT
The data member sizeOfLastScratchBuffer in the VM class is only initialized if DFG JIT is enabled, even though it's defined regardless.
This causes an early crash on Windows, which doesn't have DFG JIT enabled.
Comment 1 peavo 2013-10-24 07:19:12 PDT
Created attachment 215063 [details]
Patch
Comment 2 Brent Fulgham 2013-10-24 09:01:39 PDT
Comment on attachment 215063 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2013-10-24 09:05:12 PDT
Comment on attachment 215063 [details]
Patch

Clearing flags on attachment: 215063

Committed r157930: <http://trac.webkit.org/changeset/157930>
Comment 4 WebKit Commit Bot 2013-10-24 09:05:14 PDT
All reviewed patches have been landed.  Closing bug.