Bug 123267 - Element iterator functions should take reference
Summary: Element iterator functions should take reference
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-24 06:13 PDT by Antti Koivisto
Modified: 2013-10-24 06:24 PDT (History)
2 users (show)

See Also:


Attachments
patch (68.42 KB, patch)
2013-10-24 06:15 PDT, Antti Koivisto
kling: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2013-10-24 06:13:38 PDT
The argument has to be non-null.
Comment 1 Antti Koivisto 2013-10-24 06:15:50 PDT
Created attachment 215058 [details]
patch
Comment 2 Andreas Kling 2013-10-24 06:21:56 PDT
Comment on attachment 215058 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=215058&action=review

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:2712
> +    for (auto area = areaDescendants.begin(), end = areaDescendants.end() ; area != end; ++area) {

One extra space here.
Comment 3 Antti Koivisto 2013-10-24 06:24:56 PDT
https://trac.webkit.org/r157924