WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
123264
Remove HTMLMediaElement.startTime
https://bugs.webkit.org/show_bug.cgi?id=123264
Summary
Remove HTMLMediaElement.startTime
Xabier Rodríguez Calvar
Reported
2013-10-24 04:00:29 PDT
Remove HTMLMediaElement.startTime
Attachments
Patch
(6.01 KB, patch)
2013-10-24 04:15 PDT
,
Xabier Rodríguez Calvar
no flags
Details
Formatted Diff
Diff
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2
(595.16 KB, application/zip)
2013-10-24 05:04 PDT
,
Build Bot
no flags
Details
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion
(750.57 KB, application/zip)
2013-10-24 05:45 PDT
,
Build Bot
no flags
Details
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion
(693.79 KB, application/zip)
2013-10-24 06:49 PDT
,
Build Bot
no flags
Details
Patch
(13.90 KB, patch)
2013-10-24 12:21 PDT
,
Xabier Rodríguez Calvar
no flags
Details
Formatted Diff
Diff
Patch
(9.80 KB, patch)
2013-10-25 03:04 PDT
,
Xabier Rodríguez Calvar
calvaris
: commit-queue-
Details
Formatted Diff
Diff
Patch
(10.90 KB, patch)
2013-10-25 04:33 PDT
,
Xabier Rodríguez Calvar
no flags
Details
Formatted Diff
Diff
Patch
(12.20 KB, patch)
2013-10-26 15:53 PDT
,
Xabier Rodríguez Calvar
no flags
Details
Formatted Diff
Diff
Show Obsolete
(4)
View All
Add attachment
proposed patch, testcase, etc.
Xabier Rodríguez Calvar
Comment 1
2013-10-24 04:15:09 PDT
Created
attachment 215051
[details]
Patch Backported from Blink at
https://codereview.chromium.org/32583003
. After following the discussions at
http://code.google.com/p/chromium/issues/detail?id=309473
, I think it also makes sense to have this in WebKit. I am also planning to backport
http://code.google.com/p/chromium/issues/detail?id=309474
too.
Build Bot
Comment 2
2013-10-24 05:04:26 PDT
Comment on
attachment 215051
[details]
Patch
Attachment 215051
[details]
did not pass mac-wk2-ews (mac-wk2): Output:
http://webkit-queues.appspot.com/results/10388040
New failing tests: media/controls-styling-strict.html media/video-no-audio.html media/controls-strict.html media/audio-controls-rendering.html media/controls-without-preload.html
Build Bot
Comment 3
2013-10-24 05:04:29 PDT
Created
attachment 215054
[details]
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-13 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Build Bot
Comment 4
2013-10-24 05:45:49 PDT
Comment on
attachment 215051
[details]
Patch
Attachment 215051
[details]
did not pass mac-ews (mac): Output:
http://webkit-queues.appspot.com/results/10388047
New failing tests: media/video-no-audio.html media/controls-strict.html media/controls-styling-strict.html media/audio-controls-rendering.html media/controls-without-preload.html media/controls-after-reload.html
Build Bot
Comment 5
2013-10-24 05:45:51 PDT
Created
attachment 215056
[details]
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-08 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Build Bot
Comment 6
2013-10-24 06:49:43 PDT
Comment on
attachment 215051
[details]
Patch
Attachment 215051
[details]
did not pass mac-ews (mac): Output:
http://webkit-queues.appspot.com/results/10358058
New failing tests: media/video-no-audio.html media/controls-strict.html media/controls-styling-strict.html media/audio-controls-rendering.html media/controls-without-preload.html media/controls-after-reload.html
Build Bot
Comment 7
2013-10-24 06:49:45 PDT
Created
attachment 215061
[details]
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-03 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Eric Carlson
Comment 8
2013-10-24 08:46:03 PDT
Comment on
attachment 215051
[details]
Patch Ah, the failures happen because you didn't update the Mac port's JavaScript based media controller.
Eric Carlson
Comment 9
2013-10-24 08:49:26 PDT
(In reply to
comment #8
)
> (From update of
attachment 215051
[details]
) > Ah, the failures happen because you didn't update the Mac port's JavaScript based media controller.
Source/WebCore/Modules/mediacontrols/mediaControlsApple.js
Xabier Rodríguez Calvar
Comment 10
2013-10-24 12:21:00 PDT
Created
attachment 215093
[details]
Patch Removed startTime from the apple controls and some other places.
Eric Carlson
Comment 11
2013-10-24 14:57:36 PDT
Comment on
attachment 215093
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=215093&action=review
r=me, but please revert the changes to HTML_Timed_Media_Elements.html
> Websites/webkit.org/ChangeLog:9 > + * specs/HTML_Timed_Media_Elements.html: Removed traces of > + startTime.
This ancient spec shouldn't be edited.
Xabier Rodríguez Calvar
Comment 12
2013-10-25 03:04:45 PDT
Created
attachment 215157
[details]
Patch Removed startTime from the apple controls and some other places.
Xabier Rodríguez Calvar
Comment 13
2013-10-25 04:14:27 PDT
Comment on
attachment 215157
[details]
Patch GObject DOM symbols update is missing
Xabier Rodríguez Calvar
Comment 14
2013-10-25 04:33:30 PDT
Created
attachment 215162
[details]
Patch Removed the spec update and updated GObject DOM symbols.
Xabier Rodríguez Calvar
Comment 15
2013-10-25 04:35:21 PDT
(In reply to
comment #14
)
> Created an attachment (id=215162) [details] > Patch > > Removed the spec update and updated GObject DOM symbols.
Carlos, would you mind checking the GObject DOM symbols as Eric reviwed the rest? Then I will be able the set the cq+
Carlos Garcia Campos
Comment 16
2013-10-25 04:45:48 PDT
(In reply to
comment #15
)
> (In reply to
comment #14
) > > Created an attachment (id=215162) [details] [details] > > Patch > > > > Removed the spec update and updated GObject DOM symbols. > > Carlos, would you mind checking the GObject DOM symbols as Eric reviwed the rest? Then I will be able the set the cq+
Instead of removing the symbol, you should add a custom implementation in Source/WebCore/bindings/gobject/WebKitDOMCustom to not break the API/ABI.
Xabier Rodríguez Calvar
Comment 17
2013-10-26 15:53:28 PDT
Created
attachment 215262
[details]
Patch Added custom implementation to not break the API and fixed symbols.
Carlos Garcia Campos
Comment 18
2013-10-28 04:17:33 PDT
Comment on
attachment 215262
[details]
Patch GObject DOM bindings changes look good to me
Xabier Rodríguez Calvar
Comment 19
2013-10-28 04:41:55 PDT
(In reply to
comment #17
)
> Created an attachment (id=215262) [details] > Patch > > Added custom implementation to not break the API and fixed symbols.
Eric, could you please r+?
WebKit Commit Bot
Comment 20
2013-10-28 09:10:00 PDT
Comment on
attachment 215262
[details]
Patch Clearing flags on attachment: 215262 Committed
r158112
: <
http://trac.webkit.org/changeset/158112
>
WebKit Commit Bot
Comment 21
2013-10-28 09:10:04 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug