Bug 123261 - [GTK] Deprecate public dispatch_event method in objects implementing EventTarget interface
Summary: [GTK] Deprecate public dispatch_event method in objects implementing EventTar...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2013-10-24 03:20 PDT by Carlos Garcia Campos
Modified: 2013-10-26 04:00 PDT (History)
6 users (show)

See Also:

Attachments
Patch (63.19 KB, patch)
2013-10-24 03:29 PDT, Carlos Garcia Campos 		gustavo: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2013-10-24 03:20:04 PDT 
The interface function should be used instead. add/remove_event_listener methods are not duplicated also because they are skipped by the script generator because they receive an EventListener as argument. We need a special case for dispatch_event that is currently generated twice, a public version using the object type as first parameter and the private one used to implement the interface receiving the interface type as first argument.
Comment 1 Carlos Garcia Campos 2013-10-24 03:29:17 PDT 
Created attachment 215049 [details]
Patch
Comment 2 Gustavo Noronha (kov) 2013-10-24 05:06:39 PDT 
Comment on attachment 215049 [details]
Patch

LGTM
Comment 3 Carlos Garcia Campos 2013-10-26 04:00:27 PDT 
Committed r158083: <http://trac.webkit.org/changeset/158083>