Bug 123257 – [GTK] Disable css-image-orientation

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Gyuyoung Kim]

About 30 tests have been failed since r157909 on GTK port only. I think these regressions happen because GTK port only enables css-image-orientation now. So, I'd like to disable it at the moment. I file a bug(Bug 123256) to enable this feature again. I'd like to investigate why those regression occur on the bug.

[Gyuyoung Kim]

Created attachment 215036 [details]
Patch

[Gyuyoung Kim]

Added Martin and Carlos.

[Martin Robinson]

Comment on attachment 215036 [details]
Patch

Are the tests skipped now or are they still failing on the bot?

[Gyuyoung Kim]

(In reply to comment #3)
> (From update of attachment 215036 [details])
> Are the tests skipped now or are they still failing on the bot?

They are still failing on the bot. Do you want to skip them instead of disabling the css-image-orientation ?

[Gyuyoung Kim]

Created attachment 215066 [details]
Patch

It looks Martin wants to skip failure tests instead of disabling this feature.

[Martin Robinson]

(In reply to comment #4)
> (In reply to comment #3)
> > (From update of attachment 215036 [details] [details])
> > Are the tests skipped now or are they still failing on the bot?
> 
> They are still failing on the bot. Do you want to skip them instead of disabling the css-image-orientation ?

Sorry, for the confusion. I didn't reply in time. I just wanted to ensure that if they were skipped, that your patch unskipped them. Since they aren't skipped now, this isn'tan issue. If you don't mind, I prefer your original patch.

[Gyuyoung Kim]

Comment on attachment 215036 [details]
Patch

I want to handle this patch according to your guide.

[WebKit Commit Bot]

Comment on attachment 215036 [details]
Patch

Clearing flags on attachment: 215036

Committed r157929: <http://trac.webkit.org/changeset/157929>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.