Bug 123257 - [GTK] Disable css-image-orientation
Summary: [GTK] Disable css-image-orientation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-24 01:12 PDT by Gyuyoung Kim
Modified: 2013-10-24 08:58 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.67 KB, patch)
2013-10-24 01:24 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Patch (3.81 KB, patch)
2013-10-24 08:22 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2013-10-24 01:12:37 PDT 
About 30 tests have been failed since r157909 on GTK port only. I think these regressions happen because GTK port only enables css-image-orientation now. So, I'd like to disable it at the moment. I file a bug(Bug 123256) to enable this feature again. I'd like to investigate why those regression occur on the bug.
Comment 1 Gyuyoung Kim 2013-10-24 01:24:08 PDT 
Created attachment 215036 [details]
Patch
Comment 2 Gyuyoung Kim 2013-10-24 01:25:23 PDT 
Added Martin and Carlos.
Comment 3 Martin Robinson 2013-10-24 06:43:17 PDT 
Comment on attachment 215036 [details]
Patch

Are the tests skipped now or are they still failing on the bot?
Comment 4 Gyuyoung Kim 2013-10-24 07:50:26 PDT 
(In reply to comment #3)
> (From update of attachment 215036 [details])
> Are the tests skipped now or are they still failing on the bot?

They are still failing on the bot. Do you want to skip them instead of disabling the css-image-orientation ?
Comment 5 Gyuyoung Kim 2013-10-24 08:22:17 PDT 
Created attachment 215066 [details]
Patch

It looks Martin wants to skip failure tests instead of disabling this feature.
Comment 6 Martin Robinson 2013-10-24 08:30:47 PDT 
(In reply to comment #4)
> (In reply to comment #3)
> > (From update of attachment 215036 [details] [details])
> > Are the tests skipped now or are they still failing on the bot?
> 
> They are still failing on the bot. Do you want to skip them instead of disabling the css-image-orientation ?

Sorry, for the confusion. I didn't reply in time. I just wanted to ensure that if they were skipped, that your patch unskipped them. Since they aren't skipped now, this isn'tan issue. If you don't mind, I prefer your original patch.
Comment 7 Gyuyoung Kim 2013-10-24 08:32:37 PDT 
Comment on attachment 215036 [details]
Patch

I want to handle this patch according to your guide.
Comment 8 WebKit Commit Bot 2013-10-24 08:58:29 PDT 
Comment on attachment 215036 [details]
Patch

Clearing flags on attachment: 215036

Committed r157929: <http://trac.webkit.org/changeset/157929>
Comment 9 WebKit Commit Bot 2013-10-24 08:58:32 PDT 
All reviewed patches have been landed.  Closing bug.