Bug 123251 - [EFL] Compilation warning in DumpRenderTreeView.cpp on 64-Bit
Summary: [EFL] Compilation warning in DumpRenderTreeView.cpp on 64-Bit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-23 23:23 PDT by Sanghyup Lee
Modified: 2013-10-24 04:40 PDT (History)
5 users (show)

See Also:


Attachments
Patch (1.59 KB, patch)
2013-10-23 23:29 PDT, Sanghyup Lee
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sanghyup Lee 2013-10-23 23:23:14 PDT
The "%llu" format specifier is used to print an uint64_t value in DumpRenderTreeView.cpp. This causes a warning on 64-Bit where "%lu" is expected.
We should make use of the PRIu64 macro from inttypes.h to avoid this issue.
Comment 1 Sanghyup Lee 2013-10-23 23:29:41 PDT
Created attachment 215029 [details]
Patch
Comment 2 Csaba Osztrogonác 2013-10-24 04:17:28 PDT
Comment on attachment 215029 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2013-10-24 04:40:16 PDT
Comment on attachment 215029 [details]
Patch

Clearing flags on attachment: 215029

Committed r157922: <http://trac.webkit.org/changeset/157922>
Comment 4 WebKit Commit Bot 2013-10-24 04:40:18 PDT
All reviewed patches have been landed.  Closing bug.