Bug 123246 - Remove ThreadSafeCoordinatedSurface and CertificateInfoCurl
Summary: Remove ThreadSafeCoordinatedSurface and CertificateInfoCurl
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-23 21:12 PDT by Alex Christensen
Modified: 2013-10-24 07:31 PDT (History)
8 users (show)

See Also:

Attachments
Patch (13.58 KB, patch)
2013-10-23 21:13 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2013-10-23 21:12:19 PDT 
ThreadSafeCoordinatedSurface.cpp, ThreadSafeCoordinatedSurface.h,  and CertificateInfoCurl.cpp have some syntax errors that haven't been fixed for a while, and WinCairo compiles without them but not with them.  I think they're dead code.  ThreadSafeCoordinatedSurface was only in Qt, and CertificateInfoCurl was recently added to fix a problem that doesn't exist anymore.  Let's remove them if it doesn't break any EWS bots.
Comment 1 Alex Christensen 2013-10-23 21:13:57 PDT 
Created attachment 215026 [details]
Patch
Comment 2 Noam Rosenthal 2013-10-23 23:37:50 PDT 
ryumiel, are you still pursuing threaded coordinated graphics?
Comment 3 Gwang Yoon Hwang 2013-10-24 01:33:02 PDT 
(In reply to comment #2)
> ryumiel, are you still pursuing threaded coordinated graphics?

Oh, yes. I'm cleaning up threaded coordinated graphics at downstream while.
I'll restart up-streaming codes as soon as the stabilization stage finished.
(I hope it ends in this month.)
Comment 4 Noam Rosenthal 2013-10-24 01:40:04 PDT 
(In reply to comment #3)
> (In reply to comment #2)
> > ryumiel, are you still pursuing threaded coordinated graphics?
> 
> Oh, yes. I'm cleaning up threaded coordinated graphics at downstream while.
> I'll restart up-streaming codes as soon as the stabilization stage finished.
> (I hope it ends in this month.)

OK, and are you still using this version of ThreadedCoordinatedSurface?
Comment 5 Gwang Yoon Hwang 2013-10-24 02:05:12 PDT 
(In reply to comment #4)
> (In reply to comment #3)
> > (In reply to comment #2)
> > > ryumiel, are you still pursuing threaded coordinated graphics?
> > 
> > Oh, yes. I'm cleaning up threaded coordinated graphics at downstream while.
> > I'll restart up-streaming codes as soon as the stabilization stage finished.
> > (I hope it ends in this month.)
> 
> OK, and are you still using this version of ThreadedCoordinatedSurface?

Oh, We had refactored ThreadedCoordinatedSurface to remove duplicated codes.
If it is better to upload refactored version, I'll update these things.
Comment 6 WebKit Commit Bot 2013-10-24 07:31:11 PDT 
Comment on attachment 215026 [details]
Patch

Clearing flags on attachment: 215026

Committed r157928: <http://trac.webkit.org/changeset/157928>
Comment 7 WebKit Commit Bot 2013-10-24 07:31:13 PDT 
All reviewed patches have been landed.  Closing bug.