RESOLVED FIXED 123246
Remove ThreadSafeCoordinatedSurface and CertificateInfoCurl 
https://bugs.webkit.org/show_bug.cgi?id=123246
Summary Remove ThreadSafeCoordinatedSurface and CertificateInfoCurl
Alex Christensen
Reported 2013-10-23 21:12:19 PDT
ThreadSafeCoordinatedSurface.cpp, ThreadSafeCoordinatedSurface.h, and CertificateInfoCurl.cpp have some syntax errors that haven't been fixed for a while, and WinCairo compiles without them but not with them. I think they're dead code. ThreadSafeCoordinatedSurface was only in Qt, and CertificateInfoCurl was recently added to fix a problem that doesn't exist anymore. Let's remove them if it doesn't break any EWS bots.
Attachments
Patch (13.58 KB, patch)
2013-10-23 21:13 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2013-10-23 21:13:57 PDT
Created attachment 215026 [details] Patch
Noam Rosenthal
Comment 2 2013-10-23 23:37:50 PDT
ryumiel, are you still pursuing threaded coordinated graphics?
Gwang Yoon Hwang
Comment 3 2013-10-24 01:33:02 PDT
(In reply to comment #2) > ryumiel, are you still pursuing threaded coordinated graphics? Oh, yes. I'm cleaning up threaded coordinated graphics at downstream while. I'll restart up-streaming codes as soon as the stabilization stage finished. (I hope it ends in this month.)
Noam Rosenthal
Comment 4 2013-10-24 01:40:04 PDT
(In reply to comment #3) > (In reply to comment #2) > > ryumiel, are you still pursuing threaded coordinated graphics? > > Oh, yes. I'm cleaning up threaded coordinated graphics at downstream while. > I'll restart up-streaming codes as soon as the stabilization stage finished. > (I hope it ends in this month.) OK, and are you still using this version of ThreadedCoordinatedSurface?
Gwang Yoon Hwang
Comment 5 2013-10-24 02:05:12 PDT
(In reply to comment #4) > (In reply to comment #3) > > (In reply to comment #2) > > > ryumiel, are you still pursuing threaded coordinated graphics? > > > > Oh, yes. I'm cleaning up threaded coordinated graphics at downstream while. > > I'll restart up-streaming codes as soon as the stabilization stage finished. > > (I hope it ends in this month.) > > OK, and are you still using this version of ThreadedCoordinatedSurface? Oh, We had refactored ThreadedCoordinatedSurface to remove duplicated codes. If it is better to upload refactored version, I'll update these things.
WebKit Commit Bot
Comment 6 2013-10-24 07:31:11 PDT
Comment on attachment 215026 [details] Patch Clearing flags on attachment: 215026 Committed r157928: <http://trac.webkit.org/changeset/157928>
WebKit Commit Bot
Comment 7 2013-10-24 07:31:13 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.