Bug 123215 - Windows should build Texture Mapper files
Summary: Windows should build Texture Mapper files
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-23 12:59 PDT by Alex Christensen
Modified: 2013-10-31 23:37 PDT (History)
2 users (show)

See Also:

Attachments
Patch (36.43 KB, patch)
2013-10-23 13:01 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2013-10-23 12:59:40 PDT 
I've added Texture Mapper and Coordinated Graphics to the Windows build.  They're necessary to build WinCairo with accelerated compositing, and they're protected with macros, so they shouldn't break the AppleWin build.  Haven't tested the AppleWin build, though.
Comment 1 Alex Christensen 2013-10-23 13:01:55 PDT 
Created attachment 214984 [details]
Patch
Comment 2 Brent Fulgham 2013-10-23 13:34:18 PDT 
Comment on attachment 214984 [details]
Patch

r=me, but it looks like you need to manually land the changes due to VS project file merge errors.
Comment 3 Alex Christensen 2013-10-31 14:55:52 PDT 
r157895
Comment 4 Brent Fulgham 2013-10-31 14:56:54 PDT 
Change landed in http://trac.webkit.org/changeset/157895.
Comment 5 Brent Fulgham 2013-10-31 14:57:12 PDT 
Comment on attachment 214984 [details]
Patch

Clearing flags now that patches are landed.
Comment 6 Chen Zhixiang 2013-10-31 23:37:13 PDT 
Hi, there is a problem: if accelerated compositing is disabled, then CSS transform can only do 2d affine transform, not supporting 3d perspective transform.

To support CSS 3d perspective transform, accelerated compositing & texture mapper MUST be both enabled.

I'm  working on a WinCE port with Skia graphics backend, trying to fix this problem, but is now stubbed.