Bug 123214 - CA should be separated from ACCELERATED_COMPOSITING on Windows
Summary: CA should be separated from ACCELERATED_COMPOSITING on Windows
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-23 12:35 PDT by Alex Christensen
Modified: 2019-09-12 19:50 PDT (History)
5 users (show)

See Also:

Attachments
Patch (10.59 KB, patch)
2013-10-23 12:41 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2013-10-23 12:35:24 PDT 
I got WinCairo to compile and run without crashing using ACCELERATED_COMPOSITING.  The poster circle example (https://www.webkit.org/blog-files/3d-transforms/poster-circle.html) runs the cpu, but doesn't draw anything, so I'm still missing something, but I'll start uploading my changes for review.

Until now, AppleWin was the only port using ACCELERATED_COMPOSITING, so no effort was given to distinguish between the CA code and the ACCELERATED_COMPOSITING code.  I've separated the two.
Comment 1 Alex Christensen 2013-10-23 12:41:13 PDT 
Created attachment 214982 [details]
Patch
Comment 2 Brent Fulgham 2013-10-23 13:31:42 PDT 
Comment on attachment 214982 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2013-10-23 13:57:37 PDT 
Comment on attachment 214982 [details]
Patch

Clearing flags on attachment: 214982

Committed r157884: <http://trac.webkit.org/changeset/157884>
Comment 4 WebKit Commit Bot 2013-10-23 13:57:38 PDT 
All reviewed patches have been landed.  Closing bug.