Bug 123207 - Clean-up in Atomics.h
Summary: Clean-up in Atomics.h
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Allan Sandfeld Jensen
Depends on:
Reported: 2013-10-23 07:35 PDT by Allan Sandfeld Jensen
Modified: 2013-10-23 10:40 PDT (History)
7 users (show)

See Also:

Patch (2.31 KB, patch)
2013-10-23 07:37 PDT, Allan Sandfeld Jensen
no flags Details | Formatted Diff | Diff
Patch (2.29 KB, patch)
2013-10-23 07:55 PDT, Allan Sandfeld Jensen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Allan Sandfeld Jensen 2013-10-23 07:35:12 PDT
Atomics.h has two confusing and bit-rotted ifdefs with comments.

The first about CPU(SPARC64) was rendered obsolete when we switch from __exchange_and_add to __sync_add_and_fetch.

The second was caused by a wrong definition that apparently only caused trouble on GCC.
Comment 1 Allan Sandfeld Jensen 2013-10-23 07:37:17 PDT
Created attachment 214959 [details]
Comment 2 EFL EWS Bot 2013-10-23 07:42:02 PDT
Comment on attachment 214959 [details]

Attachment 214959 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/9858014
Comment 3 Allan Sandfeld Jensen 2013-10-23 07:55:12 PDT
Created attachment 214961 [details]
Comment 4 WebKit Commit Bot 2013-10-23 10:40:23 PDT
Comment on attachment 214961 [details]

Clearing flags on attachment: 214961

Committed r157865: <http://trac.webkit.org/changeset/157865>
Comment 5 WebKit Commit Bot 2013-10-23 10:40:25 PDT
All reviewed patches have been landed.  Closing bug.