WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
123207
Clean-up in Atomics.h
https://bugs.webkit.org/show_bug.cgi?id=123207
Summary
Clean-up in Atomics.h
Allan Sandfeld Jensen
Reported
2013-10-23 07:35:12 PDT
Atomics.h has two confusing and bit-rotted ifdefs with comments. The first about CPU(SPARC64) was rendered obsolete when we switch from __exchange_and_add to __sync_add_and_fetch. The second was caused by a wrong definition that apparently only caused trouble on GCC.
Attachments
Patch
(2.31 KB, patch)
2013-10-23 07:37 PDT
,
Allan Sandfeld Jensen
no flags
Details
Formatted Diff
Diff
Patch
(2.29 KB, patch)
2013-10-23 07:55 PDT
,
Allan Sandfeld Jensen
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Allan Sandfeld Jensen
Comment 1
2013-10-23 07:37:17 PDT
Created
attachment 214959
[details]
Patch
EFL EWS Bot
Comment 2
2013-10-23 07:42:02 PDT
Comment on
attachment 214959
[details]
Patch
Attachment 214959
[details]
did not pass efl-ews (efl): Output:
http://webkit-queues.appspot.com/results/9858014
Allan Sandfeld Jensen
Comment 3
2013-10-23 07:55:12 PDT
Created
attachment 214961
[details]
Patch
WebKit Commit Bot
Comment 4
2013-10-23 10:40:23 PDT
Comment on
attachment 214961
[details]
Patch Clearing flags on attachment: 214961 Committed
r157865
: <
http://trac.webkit.org/changeset/157865
>
WebKit Commit Bot
Comment 5
2013-10-23 10:40:25 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug