Bug 123199 – [WINCE]Input tag of range type is not painted

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Zhuang Zhigang]

On WinCE port, the Input tag of number type is not painted.
Such as below:
<input type="number" name="number" value="100" >

In fact, the method of "RenderThemeWinCE::paintSliderTrack" and "RenderThemeWinCE::paintSliderThumb" was implemented, but wrong value was returned.
It is expected a value of false if we want to paint it.

[Zhuang Zhigang]

Created attachment 214940 [details]
paint input tag of number type on WINCE port

A patch that can fix this problem.

[Zhuang Zhigang]

(In reply to comment #0)
> On WinCE port, the Input tag of number type is not painted.
> Such as below:
> <input type="number" name="number" value="100" >
> 
> In fact, the method of "RenderThemeWinCE::paintSliderTrack" and "RenderThemeWinCE::paintSliderThumb" was implemented, but wrong value was returned.
> It is expected a value of false if we want to paint it.

Sorry, I made a mistake.It is the problem of input range type. Changed the summary and will upload a new patch.

the Input tag of range type is not painted on WINCE port
Such as below:
<input type="range" name="range" value="100" >

[Zhuang Zhigang]

Created attachment 215014 [details]
Paint the input tag of range type on WinCE port.

[Patrick R. Gansterer]

Comment on attachment 215014 [details]
Paint the input tag of range type on WinCE port.

Please set the r? flag to get the patch reviewed and into the tree.

[Brent Fulgham]

Comment on attachment 215014 [details]
Paint the input tag of range type on WinCE port.

View in context: https://bugs.webkit.org/attachment.cgi?id=215014&action=review

r=me

> Source/WebCore/rendering/RenderThemeWinCE.cpp:512
> +    return false;

It's strange that we expect these methods to always return 'false'. Doesn't seem like there is much point in having a return value!

[WebKit Commit Bot]

Comment on attachment 215014 [details]
Paint the input tag of range type on WinCE port.

Clearing flags on attachment: 215014

Committed r158364: <http://trac.webkit.org/changeset/158364>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.