RESOLVED FIXED 123196
jitCompileAndSetHeuristics should DeferGCForAWhile 
https://bugs.webkit.org/show_bug.cgi?id=123196
Summary jitCompileAndSetHeuristics should DeferGCForAWhile
Filip Pizlo
Reported 2013-10-22 20:35:27 PDT
Patch forthcoming. This was causing crashes like: 0 com.apple.JavaScriptCore 0x000000010c7ff5d0 JSC::ConservativeRoots::add(void*, void*, JSC::JITStubRoutineSet&, JSC::CodeBlockSet&) + 80 (ConservativeRoots.cpp:108) 1 com.apple.JavaScriptCore 0x000000010c90ba95 JSC::Heap::markRoots() + 181 (Heap.cpp:469) 2 com.apple.JavaScriptCore 0x000000010c90ce39 JSC::Heap::collect(JSC::Heap::SweepToggle) + 409 (Heap.cpp:784) 3 com.apple.JavaScriptCore 0x000000010ca1afa5 JSC::LLInt::jitCompileAndSetHeuristics(JSC::CodeBlock*, JSC::ExecState*) + 373 (DeferGC.h:46) 4 com.apple.JavaScriptCore 0x000000010ca1476c llint_replace + 140 (LLIntSlowPaths.cpp:413) 5 com.apple.JavaScriptCore 0x000000010ca1e557 llint_op_ret + 28 ...
Attachments
the patch (1.57 KB, patch)
2013-10-22 20:42 PDT, Filip Pizlo 		mhahnenberg: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2013-10-22 20:42:35 PDT
Created attachment 214922 [details] the patch
Mark Hahnenberg
Comment 2 2013-10-22 21:06:04 PDT
Comment on attachment 214922 [details] the patch r=me
Filip Pizlo
Comment 3 2013-10-23 10:54:36 PDT
Landed in http://trac.webkit.org/changeset/157868
Note You need to log in before you can comment on or make changes to this bug.