Bug 123196 - jitCompileAndSetHeuristics should DeferGCForAWhile
Summary: jitCompileAndSetHeuristics should DeferGCForAWhile
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-22 20:35 PDT by Filip Pizlo
Modified: 2013-10-23 10:54 PDT (History)
8 users (show)

See Also:

Attachments
the patch (1.57 KB, patch)
2013-10-22 20:42 PDT, Filip Pizlo 		mhahnenberg: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2013-10-22 20:35:27 PDT 
Patch forthcoming.

This was causing crashes like:

0   com.apple.JavaScriptCore      	0x000000010c7ff5d0 JSC::ConservativeRoots::add(void*, void*, JSC::JITStubRoutineSet&, JSC::CodeBlockSet&) + 80 (ConservativeRoots.cpp:108)
1   com.apple.JavaScriptCore      	0x000000010c90ba95 JSC::Heap::markRoots() + 181 (Heap.cpp:469)
2   com.apple.JavaScriptCore      	0x000000010c90ce39 JSC::Heap::collect(JSC::Heap::SweepToggle) + 409 (Heap.cpp:784)
3   com.apple.JavaScriptCore      	0x000000010ca1afa5 JSC::LLInt::jitCompileAndSetHeuristics(JSC::CodeBlock*, JSC::ExecState*) + 373 (DeferGC.h:46)
4   com.apple.JavaScriptCore      	0x000000010ca1476c llint_replace + 140 (LLIntSlowPaths.cpp:413)
5   com.apple.JavaScriptCore      	0x000000010ca1e557 llint_op_ret + 28
...
Comment 1 Filip Pizlo 2013-10-22 20:42:35 PDT 
Created attachment 214922 [details]
the patch
Comment 2 Mark Hahnenberg 2013-10-22 21:06:04 PDT 
Comment on attachment 214922 [details]
the patch

r=me
Comment 3 Filip Pizlo 2013-10-23 10:54:36 PDT 
Landed in http://trac.webkit.org/changeset/157868