Bug 123179 - REGRESSION: `if (false === (true && undefined)) console.log("wrong!");` logs "wrong!", shouldn't!
Summary: REGRESSION: `if (false === (true && undefined)) console.log("wrong!");` logs ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Geoffrey Garen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-10-22 15:51 PDT by Geoffrey Garen
Modified: 2013-10-22 16:58 PDT (History)
3 users (show)

See Also:


Attachments
Patch (3.64 KB, patch)
2013-10-22 15:55 PDT, Geoffrey Garen
mhahnenberg: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2 (436.63 KB, application/zip)
2013-10-22 16:46 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2013-10-22 15:51:56 PDT
<rdar://problem/14961702>
Comment 1 Geoffrey Garen 2013-10-22 15:55:33 PDT
Created attachment 214895 [details]
Patch
Comment 2 Mark Hahnenberg 2013-10-22 16:01:05 PDT
Comment on attachment 214895 [details]
Patch

r=me
Comment 3 Oliver Hunt 2013-10-22 16:04:40 PDT
Comment on attachment 214895 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=214895&action=review

> Source/JavaScriptCore/parser/ResultType.h:132
> +            if (op1.definitelyIsString() || op2.definitelyIsString())

why || instead of && for this case? what delightful piece of semantics am i missing?
Comment 4 Geoffrey Garen 2013-10-22 16:05:55 PDT
Comment on attachment 214895 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=214895&action=review

>> Source/JavaScriptCore/parser/ResultType.h:132
>> +            if (op1.definitelyIsString() || op2.definitelyIsString())
> 
> why || instead of && for this case? what delightful piece of semantics am i missing?

Oops!
Comment 5 Build Bot 2013-10-22 16:46:42 PDT
Comment on attachment 214895 [details]
Patch

Attachment 214895 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/4358033

New failing tests:
js/dom/branch-fold-correctness.html
Comment 6 Build Bot 2013-10-22 16:46:44 PDT
Created attachment 214904 [details]
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-09  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 7 Geoffrey Garen 2013-10-22 16:58:18 PDT
Committed r157830: <http://trac.webkit.org/changeset/157830>