Bug 123162 - CTTE: Modernize RenderBlock a bit
Summary: CTTE: Modernize RenderBlock a bit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-22 07:16 PDT by Sam Weinig
Modified: 2013-10-22 16:57 PDT (History)
9 users (show)

See Also:

Attachments
Patch (282.30 KB, patch)
2013-10-22 07:17 PDT, Sam Weinig 		kling: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2013-10-22 07:16:03 PDT 
CTTE: Modernize RenderBlock a bit
Comment 1 Sam Weinig 2013-10-22 07:17:18 PDT 
Created attachment 214856 [details]
Patch
Comment 2 Andreas Kling 2013-10-22 07:25:49 PDT 
Comment on attachment 214856 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=214856&action=review

> Source/WebCore/rendering/InlineIterator.h:199
> +static inline RenderObject* bidiNextShared(RenderElement& root, RenderObject* current, Observer* observer = 0, EmptyInlineBehavior emptyInlineBehavior = SkipEmptyInlines, bool* endOfInlinePtr = 0)

0 -> nullptr
This comment repeated for each case of missing modernization!
Comment 3 Sam Weinig 2013-10-22 16:57:25 PDT 
Committed r157828: <http://trac.webkit.org/changeset/157828>