Bug 123150 - Introduce RENDER_OBJECT_TYPE_CASTS to replace manual toFoo() in child render object
Summary: Introduce RENDER_OBJECT_TYPE_CASTS to replace manual toFoo() in child render ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-22 04:47 PDT by Gyuyoung Kim
Modified: 2013-10-23 18:28 PDT (History)
2 users (show)

See Also:

Attachments
Patch (69.73 KB, patch)
2013-10-22 04:50 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Patch (70.09 KB, patch)
2013-10-23 00:55 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2013-10-22 04:47:01 PDT 
As a step to let toFoo use TYPE_CASTS_BASE, toRenderFoo() can use it for child render object. So, this patch introduces RENDER_OBJECT_TYPE_CASTS based on the TYPE_CASTS_BASE. This will generate plenty more helper functions for render object type cast.
Comment 1 Gyuyoung Kim 2013-10-22 04:50:56 PDT 
Created attachment 214839 [details]
Patch
Comment 2 Gyuyoung Kim 2013-10-22 17:09:11 PDT 
CC'ing Kling
Comment 3 Gyuyoung Kim 2013-10-23 00:55:10 PDT 
Created attachment 214936 [details]
Patch
Comment 4 WebKit Commit Bot 2013-10-23 18:28:39 PDT 
Comment on attachment 214936 [details]
Patch

Clearing flags on attachment: 214936

Committed r157907: <http://trac.webkit.org/changeset/157907>
Comment 5 WebKit Commit Bot 2013-10-23 18:28:42 PDT 
All reviewed patches have been landed.  Closing bug.