Bug 123144 - [GTK] enable media-stream in build-webkit
Summary: [GTK] enable media-stream in build-webkit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 79203
  Show dependency tree / graph
 
Reported: 2013-10-22 02:24 PDT by Philippe Normand
Modified: 2013-10-29 09:32 PDT (History)
6 users (show)

See Also:

Attachments
enable mediastream in autofools (6.50 KB, patch)
2013-10-22 02:30 PDT, Philippe Normand 		mrobinson: review-
Details | Formatted Diff | Diff
enable media-stream in GTK build (1.75 KB, patch)
2013-10-28 02:09 PDT, Philippe Normand 		gtk-ews: commit-queue-
Details | Formatted Diff | Diff
enable media-stream in GTK build (2.56 KB, patch)
2013-10-28 03:45 PDT, Philippe Normand 		gtk-ews: commit-queue-
Details | Formatted Diff | Diff
enable media-stream in GTK build (3.29 KB, patch)
2013-10-28 04:07 PDT, Philippe Normand 		mrobinson: review+
Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2013-10-22 02:24:34 PDT 
SSIA
Comment 1 Philippe Normand 2013-10-22 02:30:22 PDT 
Created attachment 214826 [details]
enable mediastream in autofools
Comment 2 Martin Robinson 2013-10-23 13:07:18 PDT 
Comment on attachment 214826 [details]
enable mediastream in autofools

View in context: https://bugs.webkit.org/attachment.cgi?id=214826&action=review

I'm okay with enabling media stream for build-webkit, but let's not add a configure flag.

> Source/autotools/ReadCommandLineArguments.m4:133
> +AC_MSG_CHECKING([whether to enable media stream support])
> +AC_ARG_ENABLE(media_stream, 
> +    AC_HELP_STRING([--enable-media-stream], [enable media stream support (incomplete) [default=no]]),
> +    [],
> +    [enable_media_stream="no"])
> +AC_MSG_RESULT([$enable_media_stream])
> +

I don't think we actually need a configuration flag for this. It's incomplete and we don't typically add flags for web features. The existing flags are exceptions to this rule.
Comment 3 Philippe Normand 2013-10-25 08:29:25 PDT 
So how is it supposed to work without the configure option? All this patch relies on it.

I only want MEDIA_STREAM on for developer builds...
Comment 4 Martin Robinson 2013-10-25 09:06:21 PDT 
(In reply to comment #3)
> So how is it supposed to work without the configure option? All this patch relies on it.
> 
> I only want MEDIA_STREAM on for developer builds...

If you don't add the setting to %configurableFeatures, the default will be overridden by WebKitBuild/Release/WebKitFeatureOverrides.txt, which is combined with the default options during configuration with the defaults defined in SetupWebKitFeatures.m4.
Comment 5 Philippe Normand 2013-10-28 02:09:28 PDT 
Created attachment 215290 [details]
enable media-stream in GTK build
Comment 6 kov's GTK+ EWS bot 2013-10-28 03:33:00 PDT 
Comment on attachment 215290 [details]
enable media-stream in GTK build

Attachment 215290 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/15608065
Comment 7 Philippe Normand 2013-10-28 03:45:54 PDT 
Created attachment 215293 [details]
enable media-stream in GTK build
Comment 8 kov's GTK+ EWS bot 2013-10-28 04:02:02 PDT 
Comment on attachment 215293 [details]
enable media-stream in GTK build

Attachment 215293 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/15568087
Comment 9 Philippe Normand 2013-10-28 04:07:17 PDT 
Created attachment 215294 [details]
enable media-stream in GTK build
Comment 10 Philippe Normand 2013-10-29 09:32:12 PDT 
Committed r158194: <http://trac.webkit.org/changeset/158194>