Bug 123136 - [Cocoa] Add load delegate method for didChangeBackForwardList
Summary: [Cocoa] Add load delegate method for didChangeBackForwardList
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: mitz
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-21 22:06 PDT by mitz
Modified: 2013-10-21 22:15 PDT (History)
0 users

See Also:

Attachments
Patch (3.51 KB, patch)
2013-10-21 22:08 PDT, mitz 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2013-10-21 22:06:29 PDT 
[Cocoa] Add load delegate method for didChangeBackForwardList
Comment 1 mitz 2013-10-21 22:08:09 PDT 
Created attachment 214817 [details]
Patch
Comment 2 Anders Carlsson 2013-10-21 22:13:39 PDT 
Comment on attachment 214817 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=214817&action=review

> Source/WebKit2/UIProcess/API/mac/WKBrowsingContextController.mm:496
> +    if ([browsingContext.loadDelegate respondsToSelector:@selector(browsingContextControllerDidChangedBackForwardList:addedItem:removedItems:)]) {

I think this would look better with an early return (unless this is the parttern we're using elsewhere).
Comment 3 mitz 2013-10-21 22:15:16 PDT 
Committed <http://trac.webkit.org/r157776>.