Bug 123130 – Remote Layer Tree: Implement superlayer, removeFromSuperlayer, replaceSublayer, and adoptSublayers

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Tim Horton]

There are a few remaining unimplemented layer hierarchy properties that were left that way because they're more complicated than the others. But, we need them!

[Tim Horton]

Created attachment 214807 [details]
patch

[Sam Weinig]

Comment on attachment 214807 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=214807&action=review

> Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:74
> +        static_cast<PlatformCALayerRemote*>(layer.get())->m_superlayer = nullptr;

Can we add a checked cast function for this (e.g. toPlatformCALayerRemote() that asserts the type is PlatformCALayerRemote)?

> Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemote.h:157
> +    PlatformCALayer* m_superlayer;

Seems like m_superlayer is always a PlatformCALayerRemote. Can we make the type more specific here?

[Tim Horton]

Created attachment 214872 [details]
address sam's comments

[Tim Horton]

Created attachment 214876 [details]
we'll assert that they're PlatformCALayerRemotes in just one place

[Anders Carlsson]

Comment on attachment 214876 [details]
we'll assert that they're PlatformCALayerRemotes in just one place

View in context: https://bugs.webkit.org/attachment.cgi?id=214876&action=review

> Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:154
> +    PlatformCALayerList& siblings = m_children;

I don't think you need to use this local variable. Also, it is misnamed.

[Tim Horton]

http://trac.webkit.org/changeset/157852