Bug 123120 - Remove platform #ifdefs from WebDataSourcePrivate.h
Summary: Remove platform #ifdefs from WebDataSourcePrivate.h
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac Unspecified
: P2 Normal
Assignee: Daniel Bates
Keywords: InRadar
Depends on:
Reported: 2013-10-21 15:13 PDT by Daniel Bates
Modified: 2013-10-21 15:44 PDT (History)
2 users (show)

See Also:

Patch (3.46 KB, patch)
2013-10-21 15:18 PDT, Daniel Bates
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2013-10-21 15:13:19 PDT
WebKit API/SPI headers should not use platform #ifdefs. Currently we only declare the SPI functions -[WebDataSource _setAllowToBeMemoryMapped], -[WebDataSource setDataSourceDelegate:], and -[WebDataSource dataSourceDelegate] when building with disk image cache enabled on iOS. Instead we should always declare these functions and provide a trivial implementation for them when building with disk image cache disabled.
Comment 1 Daniel Bates 2013-10-21 15:17:08 PDT
Comment 2 Daniel Bates 2013-10-21 15:18:31 PDT
Created attachment 214783 [details]
Comment 3 Daniel Bates 2013-10-21 15:44:59 PDT
Committed r157753: <http://trac.webkit.org/changeset/157753>