WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
123120
Remove platform #ifdefs from WebDataSourcePrivate.h
https://bugs.webkit.org/show_bug.cgi?id=123120
Summary
Remove platform #ifdefs from WebDataSourcePrivate.h
Daniel Bates
Reported
2013-10-21 15:13:19 PDT
WebKit API/SPI headers should not use platform #ifdefs. Currently we only declare the SPI functions -[WebDataSource _setAllowToBeMemoryMapped], -[WebDataSource setDataSourceDelegate:], and -[WebDataSource dataSourceDelegate] when building with disk image cache enabled on iOS. Instead we should always declare these functions and provide a trivial implementation for them when building with disk image cache disabled.
Attachments
Patch
(3.46 KB, patch)
2013-10-21 15:18 PDT
,
Daniel Bates
andersca
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Daniel Bates
Comment 1
2013-10-21 15:17:08 PDT
<
rdar://problem/15275533
>
Daniel Bates
Comment 2
2013-10-21 15:18:31 PDT
Created
attachment 214783
[details]
Patch
Daniel Bates
Comment 3
2013-10-21 15:44:59 PDT
Committed
r157753
: <
http://trac.webkit.org/changeset/157753
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug