Bug 123115 - [iOS] Upstream OS-version-specific install paths for JavaScriptCore.framework
Summary: [iOS] Upstream OS-version-specific install paths for JavaScriptCore.framework
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-10-21 13:08 PDT by Daniel Bates
Modified: 2013-10-22 08:45 PDT (History)
6 users (show)

See Also:


Attachments
Patch (2.08 KB, patch)
2013-10-21 13:12 PDT, Daniel Bates
no flags Details | Formatted Diff | Diff
Patch (2.08 KB, patch)
2013-10-21 13:15 PDT, Daniel Bates
no flags Details | Formatted Diff | Diff
Patch (2.09 KB, patch)
2013-10-21 13:41 PDT, Daniel Bates
no flags Details | Formatted Diff | Diff
Patch (2.44 KB, patch)
2013-10-21 17:10 PDT, Daniel Bates
no flags Details | Formatted Diff | Diff
Patch (2.44 KB, patch)
2013-10-21 17:18 PDT, Daniel Bates
aestes: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2013-10-21 13:08:19 PDT
Add support for running JavaScriptCore-based apps, built against the iOS 7 SDK, on older versions of iOS.
Comment 1 Daniel Bates 2013-10-21 13:09:11 PDT
<rdar://problem/13696872>
Comment 2 Daniel Bates 2013-10-21 13:12:02 PDT
Created attachment 214768 [details]
Patch
Comment 3 Daniel Bates 2013-10-21 13:15:05 PDT
Created attachment 214769 [details]
Patch
Comment 4 Daniel Bates 2013-10-21 13:41:45 PDT
Created attachment 214774 [details]
Patch
Comment 5 Joseph Pecoraro 2013-10-21 17:00:25 PDT
Comment on attachment 214774 [details]
Patch

r=me
Comment 6 Daniel Bates 2013-10-21 17:03:06 PDT
Comment on attachment 214774 [details]
Patch

Clearing review flag as this approach will not work.
Comment 7 Daniel Bates 2013-10-21 17:10:04 PDT
Created attachment 214797 [details]
Patch
Comment 8 WebKit Commit Bot 2013-10-21 17:11:57 PDT
Attachment 214797 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSBase.cpp', u'Source/JavaScriptCore/ChangeLog']" exit_code: 1
Source/JavaScriptCore/API/JSBase.cpp:153:  install_name_4_3 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/JavaScriptCore/API/JSBase.cpp:154:  install_name_5_0 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/JavaScriptCore/API/JSBase.cpp:155:  install_name_5_1 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/JavaScriptCore/API/JSBase.cpp:156:  install_name_6_0 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/JavaScriptCore/API/JSBase.cpp:157:  install_name_6_1 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 5 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 9 Daniel Bates 2013-10-21 17:12:32 PDT
After talking with Joseph Pecoraro and Andy Estes in person today (10/21) we felt the preprocessor macro made the code less readable.
Comment 10 Daniel Bates 2013-10-21 17:18:17 PDT
Created attachment 214798 [details]
Patch
Comment 11 Daniel Bates 2013-10-22 08:45:33 PDT
Committed r157794: <http://trac.webkit.org/changeset/157794>