RESOLVED FIXED 123115
[iOS] Upstream OS-version-specific install paths for JavaScriptCore.framework 
https://bugs.webkit.org/show_bug.cgi?id=123115
Summary [iOS] Upstream OS-version-specific install paths for JavaScriptCore.framework
Daniel Bates
Reported 2013-10-21 13:08:19 PDT
Add support for running JavaScriptCore-based apps, built against the iOS 7 SDK, on older versions of iOS.
Attachments
Patch (2.08 KB, patch)
2013-10-21 13:12 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Patch (2.08 KB, patch)
2013-10-21 13:15 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Patch (2.09 KB, patch)
2013-10-21 13:41 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Patch (2.44 KB, patch)
2013-10-21 17:10 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Patch (2.44 KB, patch)
2013-10-21 17:18 PDT, Daniel Bates 		aestes: review+
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2013-10-21 13:09:11 PDT
<rdar://problem/13696872>
Daniel Bates
Comment 2 2013-10-21 13:12:02 PDT
Created attachment 214768 [details] Patch
Daniel Bates
Comment 3 2013-10-21 13:15:05 PDT
Created attachment 214769 [details] Patch
Daniel Bates
Comment 4 2013-10-21 13:41:45 PDT
Created attachment 214774 [details] Patch
Joseph Pecoraro
Comment 5 2013-10-21 17:00:25 PDT
Comment on attachment 214774 [details] Patch r=me
Daniel Bates
Comment 6 2013-10-21 17:03:06 PDT
Comment on attachment 214774 [details] Patch Clearing review flag as this approach will not work.
Daniel Bates
Comment 7 2013-10-21 17:10:04 PDT
Created attachment 214797 [details] Patch
WebKit Commit Bot
Comment 8 2013-10-21 17:11:57 PDT
Attachment 214797 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSBase.cpp', u'Source/JavaScriptCore/ChangeLog']" exit_code: 1 Source/JavaScriptCore/API/JSBase.cpp:153: install_name_4_3 is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/JavaScriptCore/API/JSBase.cpp:154: install_name_5_0 is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/JavaScriptCore/API/JSBase.cpp:155: install_name_5_1 is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/JavaScriptCore/API/JSBase.cpp:156: install_name_6_0 is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/JavaScriptCore/API/JSBase.cpp:157: install_name_6_1 is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 5 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Daniel Bates
Comment 9 2013-10-21 17:12:32 PDT
After talking with Joseph Pecoraro and Andy Estes in person today (10/21) we felt the preprocessor macro made the code less readable.
Daniel Bates
Comment 10 2013-10-21 17:18:17 PDT
Created attachment 214798 [details] Patch
Daniel Bates
Comment 11 2013-10-22 08:45:33 PDT
Committed r157794: <http://trac.webkit.org/changeset/157794>
Note You need to log in before you can comment on or make changes to this bug.